KnockOutWhist/KnockOutWhist-Web
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 32 Wiki Activity

feat(ui): Implement countless feature using the SJWP #89

Merged
Janis merged 11 commits from feat/implement-events into main 2025-11-27 08:53:38 +01:00
Conversation 2 Commits 11 Files Changed 14 +291 -48
15 changed files with 291 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 1ca410bc4b - Show all commits

3
knockoutwhistweb/app/model/sessions/UserSession.scala
View File

@@ -2,11 +2,10 @@ package model.sessions
import de.knockoutwhist.events.player.{RequestCardEvent, RequestTieChoiceEvent, RequestTrumpSuitEvent} import de.knockoutwhist.events.player.{RequestCardEvent, RequestTieChoiceEvent, RequestTrumpSuitEvent}
import de.knockoutwhist.utils.events.SimpleEvent import de.knockoutwhist.utils.events.SimpleEvent
import logic.PodManager
import logic.game.GameLobby import logic.game.GameLobby
Janis marked this conversation as resolved Outdated
Janis commented 2025-11-27 08:28:17 +01:00
Outdated
Review
Copy Link

Excessive imports

Excessive imports
import model.users.User import model.users.User
import play.api.libs.json.Format.GenericFormat import play.api.libs.json.Format.GenericFormat
import play.api.libs.json.{JsError, JsObject, JsResult, JsSuccess, JsValue} import play.api.libs.json.{JsObject, JsValue}
import java.util.UUID import java.util.UUID
import java.util.concurrent.locks.ReentrantLock import java.util.concurrent.locks.ReentrantLock

3
knockoutwhistweb/app/model/sessions/UserWebsocketActor.scala
View File

@@ -1,9 +1,6 @@
package model.sessions package model.sessions
import de.knockoutwhist.utils.events.SimpleEvent import de.knockoutwhist.utils.events.SimpleEvent
import logic.PodManager
import logic.game.GameLobby
import model.users.User
import org.apache.pekko.actor.{Actor, ActorRef} import org.apache.pekko.actor.{Actor, ActorRef}
lq64 marked this conversation as resolved Outdated
Janis commented 2025-11-27 08:26:00 +01:00
Outdated
Review
Copy Link

Fix imports

Fix imports
import play.api.libs.json.{JsObject, JsValue, Json} import play.api.libs.json.{JsObject, JsValue, Json}
import util.WebsocketEventMapper import util.WebsocketEventMapper

1
knockoutwhistweb/app/model/users/User.scala
View File

@@ -1,6 +1,5 @@
package model.users package model.users
import play.api.libs.json.{Format, Json}
lq64 marked this conversation as resolved
Janis commented 2025-11-27 08:05:24 +01:00
Review
Copy Link

Ne

Ne
import java.util.UUID import java.util.UUID

4
knockoutwhistweb/public/javascripts/events.js
View File

@@ -144,12 +144,14 @@ function trickEndEvent(eventData) {
} }
function newTrickEvent() { function newTrickEvent() {
Janis marked this conversation as resolved
Janis commented 2025-11-27 08:06:42 +01:00
Review
Copy Link

playable cards reset

playable cards reset
const firstCardContainer = $('#first-card-container'); const firstCardContainer = $('#first-card-container');
const emptyHtml = '';
let newHtml = ''; let newHtml = '';
newHtml += ` newHtml += `
<img src="/assets/images/cards/1B.png" alt="Blank Card" width="80px" style="border-radius: 6px"/> <img src="/assets/images/cards/1B.png" alt="Blank Card" width="80px" style="border-radius: 6px"/>
`; `;
firstCardContainer.html(newHtml); firstCardContainer.html(newHtml);
const playedCardsContainer = $('#trick-cards-container')
playedCardsContainer.html(emptyHtml)
} }
function requestCardEvent(eventData) { function requestCardEvent(eventData) {
const player = eventData.player; const player = eventData.player;