KnockOutWhist/KnockOutWhist-Web
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 32 Wiki Activity

feat(ui): Implement countless feature using the SJWP #89

Merged
Janis merged 11 commits from feat/implement-events into main 2025-11-27 08:53:38 +01:00
Conversation 2 Commits 11 Files Changed 14 +295 -48
16 changed files with 295 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit efda2961c8 - Show all commits

2
knockoutwhistweb/app/logic/game/GameLobby.scala
View File

@@ -2,7 +2,7 @@ package logic.game
import de.knockoutwhist.cards.{Hand, Suit} import de.knockoutwhist.cards.{Hand, Suit}
import de.knockoutwhist.control.GameLogic import de.knockoutwhist.control.GameLogic
import de.knockoutwhist.control.GameState.{InGame, Lobby, MainMenu} import de.knockoutwhist.control.GameState.{Lobby, MainMenu}
Janis marked this conversation as resolved Outdated
Janis commented 2025-11-27 08:23:54 +01:00
Outdated
Review
Copy Link

Remove unused import

Remove unused import
import de.knockoutwhist.control.controllerBaseImpl.sublogic.util.{MatchUtil, PlayerUtil} import de.knockoutwhist.control.controllerBaseImpl.sublogic.util.{MatchUtil, PlayerUtil}
import de.knockoutwhist.events.global.{GameStateChangeEvent, SessionClosed} import de.knockoutwhist.events.global.{GameStateChangeEvent, SessionClosed}
import de.knockoutwhist.events.player.PlayerEvent import de.knockoutwhist.events.player.PlayerEvent

2
knockoutwhistweb/app/model/sessions/UserSession.scala
View File

@@ -39,7 +39,7 @@ class UserSession(val user: User, val host: Boolean, val gameLobby: GameLobby) e
canInteract = None canInteract = None
} }
def handleWebResponse(eventType: String, data: JsObject, user: User, gameLobby: GameLobby): Unit = { def handleWebResponse(eventType: String, data: JsObject): Unit = {
Janis marked this conversation as resolved Outdated
Janis commented 2025-11-27 08:24:31 +01:00
Outdated
Review
Copy Link

Parameters are too much.

Parameters are too much.
lock.lock() lock.lock()
val result = Try { val result = Try {
eventType match { eventType match {

2
knockoutwhistweb/app/model/sessions/UserWebsocketActor.scala
View File

@@ -77,7 +77,7 @@ class UserWebsocketActor(
val event = eventOpt.get val event = eventOpt.get
val data = (json \ "data").asOpt[JsObject].getOrElse(Json.obj()) val data = (json \ "data").asOpt[JsObject].getOrElse(Json.obj())
val result = Try { val result = Try {
session.handleWebResponse(event, data, session.user, session.gameLobby) session.handleWebResponse(event, data)
lq64 marked this conversation as resolved Outdated
Janis commented 2025-11-27 08:26:14 +01:00
Outdated
Review
Copy Link

Ne

Ne
} }
if (result.isSuccess) { if (result.isSuccess) {
transmitJsonToClient(Json.obj( transmitJsonToClient(Json.obj(