From d471eef7afc885e52ec2d68c0eb63321acccb5e6 Mon Sep 17 00:00:00 2001
From: "Lala, Shahd" <Shahd.Lala@sybit.de>
Date: Mon, 4 May 2026 09:56:09 +0200
Subject: [PATCH] feat: abstract buttons

---
 src/app/button-template.css                   | 40 +++++++++
 .../input-card/input-card.component.css       | 16 +---
 .../input-card/input-card.component.html      |  2 +-
 .../login-dialog/login-dialog.component.css   | 24 +-----
 .../login-dialog/login-dialog.component.html  |  6 +-
 .../promotion-dialog.component.css            | 84 +++++--------------
 .../promotion-dialog.component.html           |  5 +-
 .../register-dialog.component.css             | 24 +-----
 .../register-dialog.component.html            |  6 +-
 .../components/toolbar/toolbar.component.css  |  2 +
 .../components/toolbar/toolbar.component.html |  8 +-
 src/app/pages/game/game.component.css         |  2 +
 src/app/pages/game/game.component.html        |  2 +-
 src/app/pages/welcome/welcome.component.css   |  2 +
 src/app/pages/welcome/welcome.component.html  | 24 +++---
 15 files changed, 103 insertions(+), 144 deletions(-)
 create mode 100644 src/app/button-template.css

diff --git a/src/app/button-template.css b/src/app/button-template.css
new file mode 100644
index 0000000..9bf4095
--- /dev/null
+++ b/src/app/button-template.css
@@ -0,0 +1,40 @@
+/* Shared Button Template */
+
+.app-btn {
+  background: var(--btn-bg);
+  color: var(--btn-fg);
+  border: none;
+  border-radius: 2px;
+  padding: 0.6rem 1rem;
+  font-family: 'Space Mono', monospace;
+  font-size: 11px;
+  font-weight: 700;
+  letter-spacing: 1px;
+  cursor: pointer;
+  box-shadow: var(--btn-glow);
+  transition: transform 0.2s ease, filter 0.2s ease, background 1.6s ease, box-shadow 1.6s ease;
+  display: inline-flex;
+  align-items: center;
+  justify-content: center;
+  outline: none;
+  text-transform: uppercase;
+}
+
+.app-btn:hover:enabled {
+  transform: scale(1.05);
+  filter: brightness(1.15);
+}
+
+.app-btn:active:enabled {
+  transform: scale(0.98);
+}
+
+.app-btn:disabled {
+  opacity: 0.65;
+  cursor: not-allowed;
+  box-shadow: none;
+}
+
+.app-btn.w-100 {
+  width: 100%;
+}
diff --git a/src/app/components/input-card/input-card.component.css b/src/app/components/input-card/input-card.component.css
index b4cb7a4..df6cc1c 100644
--- a/src/app/components/input-card/input-card.component.css
+++ b/src/app/components/input-card/input-card.component.css
@@ -40,21 +40,7 @@
 
 }
 
-.input-card .btn {
-  border: var(--button-border);
-  border-radius: var(--border-radius-sm);
-  background: var(--color-bg-button);
-  color: var(--color-text-primary);
-  padding: var(--button-padding);
-  cursor: pointer;
-  font-weight: 600;
-  transition: background-color 0.2s, color 0.2s;
-}
-
-.input-card .btn:hover {
-  background: var(--color-bg-button-hover);
-  color: var(--color-text-button-hover);
-}
+@import '../../button-template.css';
 
 .hint-text {
   margin: 0;
diff --git a/src/app/components/input-card/input-card.component.html b/src/app/components/input-card/input-card.component.html
index 34b9d1a..0239946 100644
--- a/src/app/components/input-card/input-card.component.html
+++ b/src/app/components/input-card/input-card.component.html
@@ -21,7 +21,7 @@
     />
   }
 
-  <button type="button" class="btn w-100" (click)="onButtonClick()">
+  <button type="button" class="app-btn w-100" (click)="onButtonClick()">
     {{ buttonLabel }}
   </button>
 
diff --git a/src/app/components/login-dialog/login-dialog.component.css b/src/app/components/login-dialog/login-dialog.component.css
index 31739c6..6a0a6a9 100644
--- a/src/app/components/login-dialog/login-dialog.component.css
+++ b/src/app/components/login-dialog/login-dialog.component.css
@@ -27,35 +27,17 @@
   text-align: center;
 }
 
+@import '../../button-template.css';
+
 .dialog-actions {
   display: flex;
   gap: 0.6rem;
   flex-wrap: wrap;
 }
 
-.dialog-btn {
+.dialog-actions .app-btn {
   flex: 1;
   min-width: 120px;
-  background: var(--btn-bg);
-  color: var(--btn-fg);
-  border: none;
-  border-radius: 2px;
-  padding: 0.55rem 0.75rem;
-  font-family: 'Space Mono', monospace;
-  font-size: 11px;
-  font-weight: 700;
-  letter-spacing: 1px;
-  cursor: pointer;
-  box-shadow: var(--btn-glow);
-}
-
-.dialog-btn:hover:enabled {
-  filter: brightness(1.12);
-}
-
-.dialog-btn:disabled {
-  opacity: 0.65;
-  cursor: not-allowed;
 }
 
 .dialog-input {
diff --git a/src/app/components/login-dialog/login-dialog.component.html b/src/app/components/login-dialog/login-dialog.component.html
index 185c899..0f3d9e4 100644
--- a/src/app/components/login-dialog/login-dialog.component.html
+++ b/src/app/components/login-dialog/login-dialog.component.html
@@ -22,9 +22,9 @@
       }
 
       <div class="dialog-actions">
-        <button type="button" class="dialog-btn" (click)="openRegister()">Create account</button>
-        <button type="button" class="dialog-btn" (click)="closeDialog()">Cancel</button>
-        <button type="button" class="dialog-btn" (click)="onSubmit()" [disabled]="isLoading || loginForm.invalid">
+        <button type="button" class="app-btn" (click)="openRegister()">Create account</button>
+        <button type="button" class="app-btn" (click)="closeDialog()">Cancel</button>
+        <button type="submit" class="app-btn" [disabled]="isLoading || loginForm.invalid">
           @if (isLoading) {
           <span class="spinner-border spinner-border-sm me-2" role="status" aria-hidden="true"></span>
           }
diff --git a/src/app/components/promotion-dialog/promotion-dialog.component.css b/src/app/components/promotion-dialog/promotion-dialog.component.css
index 578f349..8b77042 100644
--- a/src/app/components/promotion-dialog/promotion-dialog.component.css
+++ b/src/app/components/promotion-dialog/promotion-dialog.component.css
@@ -20,9 +20,10 @@
 }
 
 .promotion-dialog {
-  background: white;
-  border-radius: 8px;
-  box-shadow: 0 4px 16px rgba(0, 0, 0, 0.2);
+  background: var(--dlg-bg, white);
+  border: 1.5px solid var(--dlg-border, #ddd);
+  border-radius: 4px;
+  box-shadow: var(--bb-glow, 0 4px 16px rgba(0, 0, 0, 0.2));
   max-width: 400px;
   width: 90%;
   animation: slideUp 0.3s ease;
@@ -44,32 +45,14 @@
   justify-content: space-between;
   align-items: center;
   padding: 20px;
-  border-bottom: 1px solid #e0e0e0;
+  border-bottom: 1px solid var(--bb-border, #e0e0e0);
 
   h3 {
     margin: 0;
+    font-family: 'Bebas Neue', sans-serif;
     font-size: 18px;
     font-weight: 600;
-    color: #333;
-  }
-
-  .close-btn {
-    background: none;
-    border: none;
-    font-size: 24px;
-    cursor: pointer;
-    color: #999;
-    padding: 0;
-    width: 30px;
-    height: 30px;
-    display: flex;
-    align-items: center;
-    justify-content: center;
-    transition: color 0.2s;
-
-    &:hover {
-      color: #333;
-    }
+    color: var(--bb-title, #333);
   }
 }
 
@@ -80,7 +63,8 @@
 .promotion-prompt {
   margin: 0 0 20px 0;
   text-align: center;
-  color: #666;
+  color: var(--bb-title);
+  opacity: 0.8;
   font-size: 14px;
 }
 
@@ -90,42 +74,20 @@
   gap: 12px;
 }
 
-.promotion-button {
-  display: flex;
+@import '../../button-template.css';
+
+.promotion-choice {
   flex-direction: column;
-  align-items: center;
-  justify-content: center;
-  gap: 8px;
+  height: auto;
   padding: 16px;
-  background: #f5f5f5;
-  border: 2px solid #ddd;
-  border-radius: 6px;
-  cursor: pointer;
-  transition: all 0.2s;
-  font-family: inherit;
-
-  &:hover {
-    background: #e8e8e8;
-    border-color: #999;
-    transform: translateY(-2px);
-    box-shadow: 0 2px 8px rgba(0, 0, 0, 0.1);
-  }
-
-  &:active {
-    transform: translateY(0);
-    box-shadow: none;
-  }
-
-  .piece-symbol {
-    font-size: 32px;
-    line-height: 1;
-  }
-
-  .piece-label {
-    font-size: 12px;
-    font-weight: 500;
-    color: #666;
-    text-transform: uppercase;
-    letter-spacing: 0.5px;
-  }
+  gap: 8px;
+}
+
+.promotion-choice .piece-symbol {
+  font-size: 32px;
+  line-height: 1;
+}
+
+.promotion-choice .piece-label {
+  font-size: 11px;
 }
diff --git a/src/app/components/promotion-dialog/promotion-dialog.component.html b/src/app/components/promotion-dialog/promotion-dialog.component.html
index 7cdb899..f93ad2b 100644
--- a/src/app/components/promotion-dialog/promotion-dialog.component.html
+++ b/src/app/components/promotion-dialog/promotion-dialog.component.html
@@ -2,7 +2,7 @@
   <div class="promotion-dialog">
     <div class="promotion-header">
       <h3>Pawn Promotion</h3>
-      <button class="close-btn" (click)="close()" aria-label="Close">&times;</button>
+      <button class="app-btn" (click)="close()" aria-label="Close" style="padding:0.2rem 0.5rem;min-width:unset;">&times;</button>
     </div>
     
     <div class="promotion-body">
@@ -11,7 +11,8 @@
       <div class="promotion-options">
         @for (piece of promotionPieces; track piece.type) {
           <button
-            class="promotion-button"
+            type="button"
+            class="app-btn promotion-choice"
             [attr.data-piece]="piece.type"
             (click)="selectPromotion(piece.type)"
             [title]="piece.label"
diff --git a/src/app/components/register-dialog/register-dialog.component.css b/src/app/components/register-dialog/register-dialog.component.css
index 31739c6..6a0a6a9 100644
--- a/src/app/components/register-dialog/register-dialog.component.css
+++ b/src/app/components/register-dialog/register-dialog.component.css
@@ -27,35 +27,17 @@
   text-align: center;
 }
 
+@import '../../button-template.css';
+
 .dialog-actions {
   display: flex;
   gap: 0.6rem;
   flex-wrap: wrap;
 }
 
-.dialog-btn {
+.dialog-actions .app-btn {
   flex: 1;
   min-width: 120px;
-  background: var(--btn-bg);
-  color: var(--btn-fg);
-  border: none;
-  border-radius: 2px;
-  padding: 0.55rem 0.75rem;
-  font-family: 'Space Mono', monospace;
-  font-size: 11px;
-  font-weight: 700;
-  letter-spacing: 1px;
-  cursor: pointer;
-  box-shadow: var(--btn-glow);
-}
-
-.dialog-btn:hover:enabled {
-  filter: brightness(1.12);
-}
-
-.dialog-btn:disabled {
-  opacity: 0.65;
-  cursor: not-allowed;
 }
 
 .dialog-input {
diff --git a/src/app/components/register-dialog/register-dialog.component.html b/src/app/components/register-dialog/register-dialog.component.html
index afda569..6562df8 100644
--- a/src/app/components/register-dialog/register-dialog.component.html
+++ b/src/app/components/register-dialog/register-dialog.component.html
@@ -29,9 +29,9 @@
       }
 
       <div class="dialog-actions">
-        <button type="button" class="dialog-btn" (click)="openLogin()">Already have an account?</button>
-        <button type="button" class="dialog-btn" (click)="closeDialog()">Cancel</button>
-        <button type="button" class="dialog-btn" (click)="onSubmit()" [disabled]="isLoading || registerForm.invalid">
+        <button type="button" class="app-btn" (click)="openLogin()">Already have an account?</button>
+        <button type="button" class="app-btn" (click)="closeDialog()">Cancel</button>
+        <button type="submit" class="app-btn" [disabled]="isLoading || registerForm.invalid">
           @if (isLoading) {
           <span class="spinner-border spinner-border-sm me-2" role="status" aria-hidden="true"></span>
           }
diff --git a/src/app/components/toolbar/toolbar.component.css b/src/app/components/toolbar/toolbar.component.css
index 53c2092..9f52ba7 100644
--- a/src/app/components/toolbar/toolbar.component.css
+++ b/src/app/components/toolbar/toolbar.component.css
@@ -17,3 +17,5 @@
 .gap-2 {
   gap: 0.5rem;
 }
+
+@import '../../button-template.css';
diff --git a/src/app/components/toolbar/toolbar.component.html b/src/app/components/toolbar/toolbar.component.html
index b6de546..01789f8 100644
--- a/src/app/components/toolbar/toolbar.component.html
+++ b/src/app/components/toolbar/toolbar.component.html
@@ -3,19 +3,19 @@
     <span class="navbar-brand">NowChess</span>
     <div class="ms-auto">
       <div class="d-flex align-items-center gap-2">
-        <button type="button" class="dialog-btn" (click)="toggleTheme()">
+        <button type="button" class="app-btn" (click)="toggleTheme()">
           {{ isDarkMode ? 'Light mode' : 'Dark mode' }}
         </button>
         @if (currentUser; as user) {
         <div class="d-flex align-items-center gap-2">
           <span style="color:var(--bb-title);font-weight:700">{{ user.username }}</span>
-          <button class="dialog-btn" (click)="logout()">Logout</button>
+          <button type="button" class="app-btn" (click)="logout()">Logout</button>
         </div>
         } @else {
-        <button class="dialog-btn" (click)="openLoginDialog()">
+        <button type="button" class="app-btn" (click)="openLoginDialog()">
           Login
         </button>
-        <button class="dialog-btn" (click)="openRegisterDialog()">
+        <button type="button" class="app-btn" (click)="openRegisterDialog()">
           Register
         </button>
         }
diff --git a/src/app/pages/game/game.component.css b/src/app/pages/game/game.component.css
index 541ccb3..5e32f0c 100644
--- a/src/app/pages/game/game.component.css
+++ b/src/app/pages/game/game.component.css
@@ -1,3 +1,5 @@
+@import '../../button-template.css';
+
 .game-shell {
   min-height: 100dvh;
   padding: clamp(var(--size-md), 2vw, var(--size-xl));
diff --git a/src/app/pages/game/game.component.html b/src/app/pages/game/game.component.html
index fc3a919..baad535 100644
--- a/src/app/pages/game/game.component.html
+++ b/src/app/pages/game/game.component.html
@@ -144,7 +144,7 @@
                 readonly
               ></textarea>
 
-              <button type="button" class="export-button" (click)="completeExport()">Done</button>
+              <button type="button" class="app-btn w-100" (click)="completeExport()">Done</button>
 
               @if (exportNotice) {
                 <p class="export-note">{{ exportNotice }}</p>
diff --git a/src/app/pages/welcome/welcome.component.css b/src/app/pages/welcome/welcome.component.css
index d0242fe..7317008 100644
--- a/src/app/pages/welcome/welcome.component.css
+++ b/src/app/pages/welcome/welcome.component.css
@@ -1,3 +1,5 @@
+@import '../../button-template.css';
+
 :host {
   display: block;
 }
diff --git a/src/app/pages/welcome/welcome.component.html b/src/app/pages/welcome/welcome.component.html
index 31210d2..0a4def3 100644
--- a/src/app/pages/welcome/welcome.component.html
+++ b/src/app/pages/welcome/welcome.component.html
@@ -37,7 +37,7 @@
             <div class="bb">
               <div class="bb-tag">JOIN</div>
               <div class="bb-title">JOIN<br />GAME</div>
-              <button type="button" class="bb-btn" (click)="openJoinDialog()" [disabled]="joiningGame">
+              <button type="button" class="app-btn" (click)="openJoinDialog()" [disabled]="joiningGame">
                 {{ joiningGame ? 'JOINING...' : 'JOIN GAME →' }}
               </button>
             </div>
@@ -62,7 +62,7 @@
             <div class="bb">
               <div class="bb-tag">BOT</div>
               <div class="bb-title">PLAY WITH<br />A BOT</div>
-              <button type="button" class="bb-btn" (click)="openDifficultyDialog()" [disabled]="creating">
+              <button type="button" class="app-btn" (click)="openDifficultyDialog()" [disabled]="creating">
                 {{ creating ? 'CREATING...' : 'GET STARTED →' }}
               </button>
             </div>
@@ -94,7 +94,7 @@
               <div class="bb-tag">WELCOME</div>
               <div class="bb-title" style="font-size:clamp(16px,1.8vw,26px);">WELCOME TO<br />NOWCHESS</div>
               <div class="bb-subtitle">Play your next move from the skyline.</div>
-              <button type="button" class="bb-btn" style="padding:7px 20px;font-size:11px;" (click)="startOneVsOne()"
+              <button type="button" class="app-btn" style="padding:7px 20px;font-size:11px;" (click)="startOneVsOne()"
                 [disabled]="creating">
                 {{ creating ? 'CREATING...' : 'START NOW →' }}
               </button>
@@ -121,7 +121,7 @@
             <div class="bb">
               <div class="bb-tag">OPTIONS</div>
               <div class="bb-title">MORE<br />OPTIONS</div>
-              <button type="button" class="bb-btn" (click)="openOptionsDialog()">OPEN MENU →</button>
+              <button type="button" class="app-btn" (click)="openOptionsDialog()">OPEN MENU →</button>
             </div>
           </div>
           <div class="wins" style="grid-template-columns:repeat(6,1fr);">
@@ -192,9 +192,9 @@
     <div class="dialog-card" (click)="$event.stopPropagation()">
       <div class="dialog-title">SELECT DIFFICULTY</div>
       <div class="dialog-actions">
-        <button type="button" class="dialog-btn" (click)="startVsBot('easy')" [disabled]="creating">EASY</button>
-        <button type="button" class="dialog-btn" (click)="startVsBot('medium')" [disabled]="creating">MEDIUM</button>
-        <button type="button" class="dialog-btn" (click)="startVsBot('hard')" [disabled]="creating">HARD</button>
+        <button type="button" class="app-btn" (click)="startVsBot('easy')" [disabled]="creating">EASY</button>
+        <button type="button" class="app-btn" (click)="startVsBot('medium')" [disabled]="creating">MEDIUM</button>
+        <button type="button" class="app-btn" (click)="startVsBot('hard')" [disabled]="creating">HARD</button>
       </div>
     </div>
   </div>
@@ -205,7 +205,7 @@
     <div class="dialog-card" (click)="$event.stopPropagation()">
       <div class="dialog-title">MORE OPTIONS</div>
       <div class="dialog-actions">
-        <button type="button" class="dialog-btn" (click)="openImportDialog()">IMPORT GAME</button>
+        <button type="button" class="app-btn" (click)="openImportDialog()">IMPORT GAME</button>
       </div>
     </div>
   </div>
@@ -218,11 +218,11 @@
       <input type="text" class="dialog-input" [(ngModel)]="gameIdInput" placeholder="Paste game ID here"
         [disabled]="joiningGame" (keyup.enter)="submitJoinGame()" />
       <div class="dialog-actions">
-        <button type="button" class="dialog-btn" (click)="submitJoinGame()"
+        <button type="button" class="app-btn" (click)="submitJoinGame()"
           [disabled]="joiningGame || !gameIdInput.trim()">
           {{ joiningGame ? 'JOINING...' : 'JOIN' }}
         </button>
-        <button type="button" class="dialog-btn" (click)="closeJoinDialog()" [disabled]="joiningGame">CANCEL</button>
+        <button type="button" class="app-btn" (click)="closeJoinDialog()" [disabled]="joiningGame">CANCEL</button>
       </div>
     </div>
   </div>
@@ -248,11 +248,11 @@
         [placeholder]="importMode === 'fen' ? 'Paste FEN here' : 'Paste PGN here'" [disabled]="importing"
         rows="5"></textarea>
       <div class="dialog-actions">
-        <button type="button" class="dialog-btn" (click)="submitImportGame()"
+        <button type="button" class="app-btn" (click)="submitImportGame()"
           [disabled]="importing || !importText.trim()">
           {{ importing ? 'IMPORTING...' : 'IMPORT' }}
         </button>
-        <button type="button" class="dialog-btn" (click)="closeImportDialog()" [disabled]="importing">CANCEL</button>
+        <button type="button" class="app-btn" (click)="closeImportDialog()" [disabled]="importing">CANCEL</button>
       </div>
     </div>
   </div>