refactor(core): optimize castling move logic and enhance move notation methods

2026-04-05 17:58:09 +02:00
parent 0778882db6
commit 08a8778227
2 changed files with 39 additions and 31 deletions
@@ -241,32 +241,41 @@ class GameEngine(
    move.moveType match
      case MoveType.CastleKingside  => "O-O"
      case MoveType.CastleQueenside => "O-O-O"
-      case MoveType.EnPassant =>
-        s"${move.from.file.toString.toLowerCase}x${move.to}"
-      case MoveType.Promotion(pp) =>
-        val ppChar = pp match
-          case PromotionPiece.Queen  => "Q"
-          case PromotionPiece.Rook   => "R"
-          case PromotionPiece.Bishop => "B"
-          case PromotionPiece.Knight => "N"
-        s"${move.to}=$ppChar"
-      case MoveType.Normal(isCapture) =>
-        boardBefore.pieceAt(move.from).map(_.pieceType) match
-          case Some(PieceType.Pawn) =>
-            if isCapture then s"${move.from.file.toString.toLowerCase}x${move.to}"
-            else move.to.toString
-          case Some(pt) =>
-            val letter = pt match
-              case PieceType.Knight => "N"
-              case PieceType.Bishop => "B"
-              case PieceType.Rook   => "R"
-              case PieceType.Queen  => "Q"
-              case PieceType.King   => "K"
-              case _                => ""
-            if isCapture then s"${letter}x${move.to}" else s"$letter${move.to}"
-          // $COVERAGE-OFF$ unreachable: executeMove is only called after a piece existence check
-          case None => move.to.toString
-          // $COVERAGE-ON$
+      case MoveType.EnPassant   => enPassantNotation(move)
+      case MoveType.Promotion(pp) => promotionNotation(move, pp)
+      case MoveType.Normal(isCapture) => normalMoveNotation(move, boardBefore, isCapture)
+
+  private def enPassantNotation(move: Move): String =
+    s"${move.from.file.toString.toLowerCase}x${move.to}"
+
+  private def promotionNotation(move: Move, piece: PromotionPiece): String =
+    val ppChar = piece match
+      case PromotionPiece.Queen  => "Q"
+      case PromotionPiece.Rook   => "R"
+      case PromotionPiece.Bishop => "B"
+      case PromotionPiece.Knight => "N"
+    s"${move.to}=$ppChar"
+
+  private def normalMoveNotation(move: Move, boardBefore: Board, isCapture: Boolean): String =
+    boardBefore.pieceAt(move.from).map(_.pieceType) match
+      case Some(PieceType.Pawn) =>
+        if isCapture then s"${move.from.file.toString.toLowerCase}x${move.to}"
+        else move.to.toString
+      case Some(pt) =>
+        val letter = pieceNotation(pt)
+        if isCapture then s"${letter}x${move.to}" else s"$letter${move.to}"
+      // $COVERAGE-OFF$ unreachable: executeMove is only called after a piece existence check
+      case None => move.to.toString
+      // $COVERAGE-ON$
+
+  private def pieceNotation(pieceType: PieceType): String =
+    pieceType match
+      case PieceType.Knight => "N"
+      case PieceType.Bishop => "B"
+      case PieceType.Rook   => "R"
+      case PieceType.Queen  => "Q"
+      case PieceType.King   => "K"
+      case _                => ""

  private def computeCaptured(context: GameContext, move: Move): Option[Piece] =
    move.moveType match