refactor(core): enhance castling logic to include rook movement and improve safety checks

modules/rule/src/main/scala/de/nowchess/rules/sets/DefaultRules.scala

@@ -139,9 +139,9 @@ object DefaultRules extends RuleSet:
     else
       val moves = scala.collection.mutable.ListBuffer[Move]()
       addCastleMove(context, moves, context.castlingRights.whiteKingSide,
-        "e1", "g1", "f1", MoveType.CastleKingside)
+        "e1", "g1", "f1", "h1", MoveType.CastleKingside)
       addCastleMove(context, moves, context.castlingRights.whiteQueenSide,
-        "e1", "c1", "d1", MoveType.CastleQueenside)
+        "e1", "c1", "d1", "a1", MoveType.CastleQueenside)
       moves.toList
 
   private def blackCastles(context: GameContext, from: Square): List[Move] =
@@ -150,9 +150,9 @@ object DefaultRules extends RuleSet:
     else
       val moves = scala.collection.mutable.ListBuffer[Move]()
       addCastleMove(context, moves, context.castlingRights.blackKingSide,
-        "e8", "g8", "f8", MoveType.CastleKingside)
+        "e8", "g8", "f8", "h8", MoveType.CastleKingside)
       addCastleMove(context, moves, context.castlingRights.blackQueenSide,
-        "e8", "c8", "d8", MoveType.CastleQueenside)
+        "e8", "c8", "d8", "a8", MoveType.CastleQueenside)
       moves.toList
 
   private def addCastleMove(
@@ -162,6 +162,7 @@ object DefaultRules extends RuleSet:
     kingFromAlg: String,
     kingToAlg: String,
     middleAlg: String,
+    rookFromAlg: String,
     moveType: MoveType
   ): Unit =
     if castlingRight then
@@ -169,8 +170,20 @@ object DefaultRules extends RuleSet:
       if squaresEmpty(context.board, clearSqs) then
         for
           kf <- Square.fromAlgebraic(kingFromAlg)
+          km <- Square.fromAlgebraic(middleAlg)
           kt <- Square.fromAlgebraic(kingToAlg)
-        do moves += Move(kf, kt, moveType)
+          rf <- Square.fromAlgebraic(rookFromAlg)
+        do
+          val color = context.turn
+          val kingPresent = context.board.pieceAt(kf).exists(p => p.color == color && p.pieceType == PieceType.King)
+          val rookPresent = context.board.pieceAt(rf).exists(p => p.color == color && p.pieceType == PieceType.Rook)
+          val squaresSafe =
+            !isAttackedBy(context.board, kf, color.opposite) &&
+            !isAttackedBy(context.board, km, color.opposite) &&
+            !isAttackedBy(context.board, kt, color.opposite)
+
+          if kingPresent && rookPresent && squaresSafe then
+            moves += Move(kf, kt, moveType)
 
   private def squaresEmpty(board: Board, squares: List[Square]): Boolean =
     squares.forall(sq => board.pieceAt(sq).isEmpty)