refactor: update meterRegistry usage to Option type and improve formatting
Build & Test (NowChessSystems) TeamCity build finished

This commit is contained in:
2026-05-10 22:56:57 +02:00
parent 9459203e0d
commit 7efdd69948
6 changed files with 31 additions and 20 deletions
+8 -5
View File
@@ -2,7 +2,7 @@
> **Stack:** raw-http | none | unknown | scala > **Stack:** raw-http | none | unknown | scala
> 0 routes + 40 rpc | 0 models | 0 components | 163 lib files | 1 env vars | 1 middleware > 0 routes + 40 rpc | 0 models | 0 components | 164 lib files | 1 env vars | 1 middleware
> **Token savings:** this file is ~0 tokens. Without it, AI exploration would cost ~0 tokens. **Saves ~0 tokens per conversation.** > **Token savings:** this file is ~0 tokens. Without it, AI exploration would cost ~0 tokens. **Saves ~0 tokens per conversation.**
--- ---
@@ -235,7 +235,7 @@
- function rebalanceInterval - function rebalanceInterval
- function rebalanceMinInterval - function rebalanceMinInterval
- function heartbeatTtl - function heartbeatTtl
- _...11 more_ - _...12 more_
- `modules/coordinator/src/main/scala/de/nowchess/coordinator/config/JacksonConfig.scala` — class JacksonConfig, function customize - `modules/coordinator/src/main/scala/de/nowchess/coordinator/config/JacksonConfig.scala` — class JacksonConfig, function customize
- `modules/coordinator/src/main/scala/de/nowchess/coordinator/config/NativeReflectionConfig.scala` — class NativeReflectionConfig - `modules/coordinator/src/main/scala/de/nowchess/coordinator/config/NativeReflectionConfig.scala` — class NativeReflectionConfig
- `modules/coordinator/src/main/scala/de/nowchess/coordinator/grpc/CoordinatorGrpcServer.scala` — class CoordinatorGrpcServer - `modules/coordinator/src/main/scala/de/nowchess/coordinator/grpc/CoordinatorGrpcServer.scala` — class CoordinatorGrpcServer
@@ -255,6 +255,7 @@
- _...1 more_ - _...1 more_
- `modules/coordinator/src/main/scala/de/nowchess/coordinator/service/AutoScaler.scala` - `modules/coordinator/src/main/scala/de/nowchess/coordinator/service/AutoScaler.scala`
- class AutoScaler - class AutoScaler
- function initMetrics
- function checkAndScale - function checkAndScale
- function scaleUp - function scaleUp
- function scaleDown - function scaleDown
@@ -273,12 +274,12 @@
- function watchK8sPods - function watchK8sPods
- `modules/coordinator/src/main/scala/de/nowchess/coordinator/service/InstanceRegistry.scala` - `modules/coordinator/src/main/scala/de/nowchess/coordinator/service/InstanceRegistry.scala`
- class InstanceRegistry - class InstanceRegistry
- function initMetrics
- function setRedisPrefix - function setRedisPrefix
- function getInstance - function getInstance
- function getAllInstances - function getAllInstances
- function updateInstanceFromRedis - function updateInstanceFromRedis
- function markInstanceDead - _...3 more_
- _...1 more_
- `modules/coordinator/src/main/scala/de/nowchess/coordinator/service/LoadBalancer.scala` - `modules/coordinator/src/main/scala/de/nowchess/coordinator/service/LoadBalancer.scala`
- class LoadBalancer - class LoadBalancer
- function setRedisPrefix - function setRedisPrefix
@@ -319,7 +320,7 @@
- function context - function context
- function pendingDrawOfferBy - function pendingDrawOfferBy
- function currentClockState - function currentClockState
- _...21 more_ - _...22 more_
- `modules/core/src/main/scala/de/nowchess/chess/exception/ApiException.scala` - `modules/core/src/main/scala/de/nowchess/chess/exception/ApiException.scala`
- class ApiException - class ApiException
- class GameNotFoundException - class GameNotFoundException
@@ -371,6 +372,7 @@
- function generateId - function generateId
- `modules/core/src/main/scala/de/nowchess/chess/registry/RedisGameRegistry.scala` - `modules/core/src/main/scala/de/nowchess/chess/registry/RedisGameRegistry.scala`
- class RedisGameRegistry - class RedisGameRegistry
- function initMetrics
- function generateId - function generateId
- function store - function store
- function get - function get
@@ -588,6 +590,7 @@
- _...6 more_ - _...6 more_
- `modules/rule/src/main/scala/de/nowchess/rules/sets/DefaultRules.scala` — class DefaultRules, function positionOf - `modules/rule/src/main/scala/de/nowchess/rules/sets/DefaultRules.scala` — class DefaultRules, function positionOf
- `modules/security/src/main/scala/de/nowchess/security/InternalAuthFilter.scala` — class InternalAuthFilter - `modules/security/src/main/scala/de/nowchess/security/InternalAuthFilter.scala` — class InternalAuthFilter
- `modules/security/src/main/scala/de/nowchess/security/InternalClientHeadersFactory.scala` — class InternalClientHeadersFactory
- `modules/security/src/main/scala/de/nowchess/security/InternalGrpcAuthInterceptor.scala` — class InternalGrpcAuthInterceptor - `modules/security/src/main/scala/de/nowchess/security/InternalGrpcAuthInterceptor.scala` — class InternalGrpcAuthInterceptor
- `modules/security/src/main/scala/de/nowchess/security/InternalGrpcSecretClientInterceptor.scala` — class InternalGrpcSecretClientInterceptor - `modules/security/src/main/scala/de/nowchess/security/InternalGrpcSecretClientInterceptor.scala` — class InternalGrpcSecretClientInterceptor
- `modules/security/src/main/scala/de/nowchess/security/InternalSecretClientFilter.scala` — class InternalSecretClientFilter - `modules/security/src/main/scala/de/nowchess/security/InternalSecretClientFilter.scala` — class InternalSecretClientFilter
+7 -4
View File
@@ -179,7 +179,7 @@
- function rebalanceInterval - function rebalanceInterval
- function rebalanceMinInterval - function rebalanceMinInterval
- function heartbeatTtl - function heartbeatTtl
- _...11 more_ - _...12 more_
- `modules/coordinator/src/main/scala/de/nowchess/coordinator/config/JacksonConfig.scala` — class JacksonConfig, function customize - `modules/coordinator/src/main/scala/de/nowchess/coordinator/config/JacksonConfig.scala` — class JacksonConfig, function customize
- `modules/coordinator/src/main/scala/de/nowchess/coordinator/config/NativeReflectionConfig.scala` — class NativeReflectionConfig - `modules/coordinator/src/main/scala/de/nowchess/coordinator/config/NativeReflectionConfig.scala` — class NativeReflectionConfig
- `modules/coordinator/src/main/scala/de/nowchess/coordinator/grpc/CoordinatorGrpcServer.scala` — class CoordinatorGrpcServer - `modules/coordinator/src/main/scala/de/nowchess/coordinator/grpc/CoordinatorGrpcServer.scala` — class CoordinatorGrpcServer
@@ -199,6 +199,7 @@
- _...1 more_ - _...1 more_
- `modules/coordinator/src/main/scala/de/nowchess/coordinator/service/AutoScaler.scala` - `modules/coordinator/src/main/scala/de/nowchess/coordinator/service/AutoScaler.scala`
- class AutoScaler - class AutoScaler
- function initMetrics
- function checkAndScale - function checkAndScale
- function scaleUp - function scaleUp
- function scaleDown - function scaleDown
@@ -217,12 +218,12 @@
- function watchK8sPods - function watchK8sPods
- `modules/coordinator/src/main/scala/de/nowchess/coordinator/service/InstanceRegistry.scala` - `modules/coordinator/src/main/scala/de/nowchess/coordinator/service/InstanceRegistry.scala`
- class InstanceRegistry - class InstanceRegistry
- function initMetrics
- function setRedisPrefix - function setRedisPrefix
- function getInstance - function getInstance
- function getAllInstances - function getAllInstances
- function updateInstanceFromRedis - function updateInstanceFromRedis
- function markInstanceDead - _...3 more_
- _...1 more_
- `modules/coordinator/src/main/scala/de/nowchess/coordinator/service/LoadBalancer.scala` - `modules/coordinator/src/main/scala/de/nowchess/coordinator/service/LoadBalancer.scala`
- class LoadBalancer - class LoadBalancer
- function setRedisPrefix - function setRedisPrefix
@@ -263,7 +264,7 @@
- function context - function context
- function pendingDrawOfferBy - function pendingDrawOfferBy
- function currentClockState - function currentClockState
- _...21 more_ - _...22 more_
- `modules/core/src/main/scala/de/nowchess/chess/exception/ApiException.scala` - `modules/core/src/main/scala/de/nowchess/chess/exception/ApiException.scala`
- class ApiException - class ApiException
- class GameNotFoundException - class GameNotFoundException
@@ -315,6 +316,7 @@
- function generateId - function generateId
- `modules/core/src/main/scala/de/nowchess/chess/registry/RedisGameRegistry.scala` - `modules/core/src/main/scala/de/nowchess/chess/registry/RedisGameRegistry.scala`
- class RedisGameRegistry - class RedisGameRegistry
- function initMetrics
- function generateId - function generateId
- function store - function store
- function get - function get
@@ -532,6 +534,7 @@
- _...6 more_ - _...6 more_
- `modules/rule/src/main/scala/de/nowchess/rules/sets/DefaultRules.scala` — class DefaultRules, function positionOf - `modules/rule/src/main/scala/de/nowchess/rules/sets/DefaultRules.scala` — class DefaultRules, function positionOf
- `modules/security/src/main/scala/de/nowchess/security/InternalAuthFilter.scala` — class InternalAuthFilter - `modules/security/src/main/scala/de/nowchess/security/InternalAuthFilter.scala` — class InternalAuthFilter
- `modules/security/src/main/scala/de/nowchess/security/InternalClientHeadersFactory.scala` — class InternalClientHeadersFactory
- `modules/security/src/main/scala/de/nowchess/security/InternalGrpcAuthInterceptor.scala` — class InternalGrpcAuthInterceptor - `modules/security/src/main/scala/de/nowchess/security/InternalGrpcAuthInterceptor.scala` — class InternalGrpcAuthInterceptor
- `modules/security/src/main/scala/de/nowchess/security/InternalGrpcSecretClientInterceptor.scala` — class InternalGrpcSecretClientInterceptor - `modules/security/src/main/scala/de/nowchess/security/InternalGrpcSecretClientInterceptor.scala` — class InternalGrpcSecretClientInterceptor
- `modules/security/src/main/scala/de/nowchess/security/InternalSecretClientFilter.scala` — class InternalSecretClientFilter - `modules/security/src/main/scala/de/nowchess/security/InternalSecretClientFilter.scala` — class InternalSecretClientFilter
@@ -61,7 +61,7 @@ class AccountService:
def login(req: LoginRequest): Either[AccountError, String] = def login(req: LoginRequest): Either[AccountError, String] =
val result = authenticateUser(req) val result = authenticateUser(req)
result match result match
case Right(_) => meterRegistry.counter("nowchess.auth.logins", "result", "success").increment() case Right(_) => meterRegistry.counter("nowchess.auth.logins", "result", "success").increment()
case Left(error) => case Left(error) =>
meterRegistry.counter("nowchess.auth.logins", "result", "failure").increment() meterRegistry.counter("nowchess.auth.logins", "result", "failure").increment()
meterRegistry.counter("nowchess.auth.login.failures", "reason", loginFailureReason(error)).increment() meterRegistry.counter("nowchess.auth.login.failures", "reason", loginFailureReason(error)).increment()
@@ -118,7 +118,11 @@ class ChallengeService:
result.foreach(_ => meterRegistry.counter("nowchess.challenges.declined").increment()) result.foreach(_ => meterRegistry.counter("nowchess.challenges.declined").increment())
result result
private def declineChallenge(challengeId: UUID, userId: UUID, req: DeclineRequest): Either[ChallengeError, Challenge] = private def declineChallenge(
challengeId: UUID,
userId: UUID,
req: DeclineRequest,
): Either[ChallengeError, Challenge] =
for for
challenge <- challengeRepository.findById(challengeId).toRight(ChallengeError.ChallengeNotFound) challenge <- challengeRepository.findById(challengeId).toRight(ChallengeError.ChallengeNotFound)
_ <- Either.cond(challenge.status == ChallengeStatus.Created, (), ChallengeError.ChallengeNotActive) _ <- Either.cond(challenge.status == ChallengeStatus.Created, (), ChallengeError.ChallengeNotActive)
@@ -15,7 +15,7 @@ final class AlphaBetaSearch(
tt: TranspositionTable = TranspositionTable(), tt: TranspositionTable = TranspositionTable(),
weights: Evaluation, weights: Evaluation,
numThreads: Int = Runtime.getRuntime.availableProcessors, numThreads: Int = Runtime.getRuntime.availableProcessors,
meterRegistry: MeterRegistry = null, meterRegistry: Option[MeterRegistry] = None,
): ):
private val INF = Int.MaxValue / 2 private val INF = Int.MaxValue / 2
@@ -108,9 +108,10 @@ final class AlphaBetaSearch(
result result
private def recordSearchMetrics(depthReached: Int): Unit = private def recordSearchMetrics(depthReached: Int): Unit =
if meterRegistry != null then meterRegistry.foreach { mr =>
meterRegistry.summary("nowchess.bot.search.nodes").record(nodeCount.get().toDouble) mr.summary("nowchess.bot.search.nodes").record(nodeCount.get().toDouble)
meterRegistry.summary("nowchess.bot.search.depth").record(depthReached.toDouble) mr.summary("nowchess.bot.search.depth").record(depthReached.toDouble)
}
private def isOutOfTime: Boolean = private def isOutOfTime: Boolean =
System.currentTimeMillis - timeStartMs.get >= timeLimitMs.get System.currentTimeMillis - timeStartMs.get >= timeLimitMs.get
@@ -19,11 +19,11 @@ import java.util.function.Consumer
class OfficialBotService: class OfficialBotService:
// scalafix:off DisableSyntax.var // scalafix:off DisableSyntax.var
@Inject var redis: RedisDataSource = uninitialized @Inject var redis: RedisDataSource = uninitialized
@Inject var redisConfig: RedisConfig = uninitialized @Inject var redisConfig: RedisConfig = uninitialized
@Inject var objectMapper: ObjectMapper = uninitialized @Inject var objectMapper: ObjectMapper = uninitialized
@Inject var botController: BotController = uninitialized @Inject var botController: BotController = uninitialized
@Inject var meterRegistry: MeterRegistry = uninitialized @Inject var meterRegistry: MeterRegistry = uninitialized
// scalafix:on DisableSyntax.var // scalafix:on DisableSyntax.var
private val terminalStatuses = private val terminalStatuses =