fix(rules): Code quality
linter corrections
This commit is contained in:
@@ -247,11 +247,13 @@ class RuleSetResourceTest:
|
|||||||
// ── position builders ─────────────────────────────────────────────
|
// ── position builders ─────────────────────────────────────────────
|
||||||
|
|
||||||
private def buildCheckContext(): GameContext =
|
private def buildCheckContext(): GameContext =
|
||||||
val board = Board(Map(
|
val board = Board(
|
||||||
|
Map(
|
||||||
Square(File.E, Rank.R1) -> Piece(Color.White, PieceType.King),
|
Square(File.E, Rank.R1) -> Piece(Color.White, PieceType.King),
|
||||||
Square(File.E, Rank.R8) -> Piece(Color.Black, PieceType.King),
|
Square(File.E, Rank.R8) -> Piece(Color.Black, PieceType.King),
|
||||||
Square(File.E, Rank.R3) -> Piece(Color.Black, PieceType.Rook),
|
Square(File.E, Rank.R3) -> Piece(Color.Black, PieceType.Rook),
|
||||||
))
|
),
|
||||||
|
)
|
||||||
GameContext(board, Color.White, CastlingRights.None, None, 0, List.empty, initialBoard = board)
|
GameContext(board, Color.White, CastlingRights.None, None, 0, List.empty, initialBoard = board)
|
||||||
|
|
||||||
private def buildFoolsMate(): GameContext =
|
private def buildFoolsMate(): GameContext =
|
||||||
@@ -263,18 +265,22 @@ class RuleSetResourceTest:
|
|||||||
}
|
}
|
||||||
|
|
||||||
private def buildStalemateContext(): GameContext =
|
private def buildStalemateContext(): GameContext =
|
||||||
val board = Board(Map(
|
val board = Board(
|
||||||
|
Map(
|
||||||
Square(File.H, Rank.R8) -> Piece(Color.Black, PieceType.King),
|
Square(File.H, Rank.R8) -> Piece(Color.Black, PieceType.King),
|
||||||
Square(File.F, Rank.R7) -> Piece(Color.White, PieceType.Queen),
|
Square(File.F, Rank.R7) -> Piece(Color.White, PieceType.Queen),
|
||||||
Square(File.G, Rank.R6) -> Piece(Color.White, PieceType.King),
|
Square(File.G, Rank.R6) -> Piece(Color.White, PieceType.King),
|
||||||
))
|
),
|
||||||
|
)
|
||||||
GameContext(board, Color.Black, CastlingRights.None, None, 0, List.empty, initialBoard = board)
|
GameContext(board, Color.Black, CastlingRights.None, None, 0, List.empty, initialBoard = board)
|
||||||
|
|
||||||
private def buildKingsOnlyContext(): GameContext =
|
private def buildKingsOnlyContext(): GameContext =
|
||||||
val board = Board(Map(
|
val board = Board(
|
||||||
|
Map(
|
||||||
Square(File.E, Rank.R1) -> Piece(Color.White, PieceType.King),
|
Square(File.E, Rank.R1) -> Piece(Color.White, PieceType.King),
|
||||||
Square(File.E, Rank.R8) -> Piece(Color.Black, PieceType.King),
|
Square(File.E, Rank.R8) -> Piece(Color.Black, PieceType.King),
|
||||||
))
|
),
|
||||||
|
)
|
||||||
GameContext(board, Color.White, CastlingRights.None, None, 0, List.empty, initialBoard = board)
|
GameContext(board, Color.White, CastlingRights.None, None, 0, List.empty, initialBoard = board)
|
||||||
|
|
||||||
private def buildThreefoldContext(): GameContext =
|
private def buildThreefoldContext(): GameContext =
|
||||||
|
|||||||
+17
-10
@@ -21,11 +21,13 @@ class RuleSetResourceUnitTest extends AnyFunSuite with Matchers:
|
|||||||
// ── position builders ─────────────────────────────────────────────
|
// ── position builders ─────────────────────────────────────────────
|
||||||
|
|
||||||
private def checkContext(): GameContext =
|
private def checkContext(): GameContext =
|
||||||
val board = Board(Map(
|
val board = Board(
|
||||||
|
Map(
|
||||||
Square(File.E, Rank.R1) -> Piece(Color.White, PieceType.King),
|
Square(File.E, Rank.R1) -> Piece(Color.White, PieceType.King),
|
||||||
Square(File.E, Rank.R8) -> Piece(Color.Black, PieceType.King),
|
Square(File.E, Rank.R8) -> Piece(Color.Black, PieceType.King),
|
||||||
Square(File.E, Rank.R3) -> Piece(Color.Black, PieceType.Rook),
|
Square(File.E, Rank.R3) -> Piece(Color.Black, PieceType.Rook),
|
||||||
))
|
),
|
||||||
|
)
|
||||||
GameContext(board, Color.White, CastlingRights.None, None, 0, List.empty, initialBoard = board)
|
GameContext(board, Color.White, CastlingRights.None, None, 0, List.empty, initialBoard = board)
|
||||||
|
|
||||||
private def foolsMate(): GameContext =
|
private def foolsMate(): GameContext =
|
||||||
@@ -37,18 +39,22 @@ class RuleSetResourceUnitTest extends AnyFunSuite with Matchers:
|
|||||||
}
|
}
|
||||||
|
|
||||||
private def stalemateContext(): GameContext =
|
private def stalemateContext(): GameContext =
|
||||||
val board = Board(Map(
|
val board = Board(
|
||||||
|
Map(
|
||||||
Square(File.H, Rank.R8) -> Piece(Color.Black, PieceType.King),
|
Square(File.H, Rank.R8) -> Piece(Color.Black, PieceType.King),
|
||||||
Square(File.F, Rank.R7) -> Piece(Color.White, PieceType.Queen),
|
Square(File.F, Rank.R7) -> Piece(Color.White, PieceType.Queen),
|
||||||
Square(File.G, Rank.R6) -> Piece(Color.White, PieceType.King),
|
Square(File.G, Rank.R6) -> Piece(Color.White, PieceType.King),
|
||||||
))
|
),
|
||||||
|
)
|
||||||
GameContext(board, Color.Black, CastlingRights.None, None, 0, List.empty, initialBoard = board)
|
GameContext(board, Color.Black, CastlingRights.None, None, 0, List.empty, initialBoard = board)
|
||||||
|
|
||||||
private def kingsOnlyContext(): GameContext =
|
private def kingsOnlyContext(): GameContext =
|
||||||
val board = Board(Map(
|
val board = Board(
|
||||||
|
Map(
|
||||||
Square(File.E, Rank.R1) -> Piece(Color.White, PieceType.King),
|
Square(File.E, Rank.R1) -> Piece(Color.White, PieceType.King),
|
||||||
Square(File.E, Rank.R8) -> Piece(Color.Black, PieceType.King),
|
Square(File.E, Rank.R8) -> Piece(Color.Black, PieceType.King),
|
||||||
))
|
),
|
||||||
|
)
|
||||||
GameContext(board, Color.White, CastlingRights.None, None, 0, List.empty, initialBoard = board)
|
GameContext(board, Color.White, CastlingRights.None, None, 0, List.empty, initialBoard = board)
|
||||||
|
|
||||||
private def threefoldContext(): GameContext =
|
private def threefoldContext(): GameContext =
|
||||||
@@ -100,9 +106,9 @@ class RuleSetResourceUnitTest extends AnyFunSuite with Matchers:
|
|||||||
|
|
||||||
test("isCheck throws BadRequestException for invalid context"):
|
test("isCheck throws BadRequestException for invalid context"):
|
||||||
an[BadRequestException] should be thrownBy
|
an[BadRequestException] should be thrownBy
|
||||||
resource.isCheck(ctx(GameContext.initial).copy(context =
|
resource.isCheck(
|
||||||
DtoMapper.fromGameContext(GameContext.initial).copy(turn = "Red"),
|
ctx(GameContext.initial).copy(context = DtoMapper.fromGameContext(GameContext.initial).copy(turn = "Red")),
|
||||||
))
|
)
|
||||||
|
|
||||||
// ── isCheckmate ───────────────────────────────────────────────────
|
// ── isCheckmate ───────────────────────────────────────────────────
|
||||||
|
|
||||||
@@ -154,7 +160,8 @@ class RuleSetResourceUnitTest extends AnyFunSuite with Matchers:
|
|||||||
resource.applyMove(ctxMv(GameContext.initial, move)).turn shouldBe "Black"
|
resource.applyMove(ctxMv(GameContext.initial, move)).turn shouldBe "Black"
|
||||||
|
|
||||||
test("applyMove throws BadRequestException for invalid move"):
|
test("applyMove throws BadRequestException for invalid move"):
|
||||||
val badMove = DtoMapper.fromMove(Move(Square(File.E, Rank.R2), Square(File.E, Rank.R4)))
|
val badMove = DtoMapper
|
||||||
|
.fromMove(Move(Square(File.E, Rank.R2), Square(File.E, Rank.R4)))
|
||||||
.copy(moveType = "unknown")
|
.copy(moveType = "unknown")
|
||||||
an[BadRequestException] should be thrownBy
|
an[BadRequestException] should be thrownBy
|
||||||
resource.applyMove(ContextMoveRequest(DtoMapper.fromGameContext(GameContext.initial), badMove))
|
resource.applyMove(ContextMoveRequest(DtoMapper.fromGameContext(GameContext.initial), badMove))
|
||||||
|
|||||||
Reference in New Issue
Block a user