fix: update move validation to check for king safety (#13)

Reviewed-on: #13

.claude/agents/scala-implementer.md

@@ -2,9 +2,10 @@
 name: scala-implementer
 description: "Implements Scala 3 + Quarkus REST services, domain logic, and persistence"
 tools: Read, Write, Edit, Bash, Glob
-model: sonnet
+model: inherit
 color: pink
 ---
+
 You do not have permissions to write tests, just source code.
 You are a Scala 3 expert specialising in Quarkus microservices.
 Always read the relevant /docs/api/ file before implementing.

.claude/agents/test-writer.md

@@ -2,9 +2,10 @@
 name: test-writer
 description: "Writes QuarkusTest unit and integration tests for a service. Invoke after scala-implementer has finished."
 tools: Read, Write, Edit, Bash, Glob, Grep, WebFetch, WebSearch, NotebookEdit
-model: sonnet
+model: haiku
 color: purple
 ---
+
 You do not have permissions to modify the source code, just write tests.
 You write tests for Scala 3 + Quarkus services.
 
@@ -19,5 +20,4 @@ When invoked BEFORE scala-implementer (no implementation exists yet):
 
 When invoked AFTER scala-implementer (implementation exists):
   Run python3 jacoco-reporter/jacoco_coverage_gaps.py modules/{service-name}/build/reports/jacoco/test/jacocoTestReport.xml --output agent
-  Use the jacoco-coverage-gaps skill — close coverage gaps revealed by the report.
   To regenerate the report run the tests first.

.idea/AndroidProjectSystem.xml

@@ -0,0 +1,6 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project version="4">
+  <component name="AndroidProjectSystem">
+    <option name="providerId" value="com.android.tools.idea.GradleProjectSystem" />
+  </component>
+</project>

.idea/gradle.xml

@@ -12,6 +12,7 @@
             <option value="$PROJECT_DIR$/modules" />
             <option value="$PROJECT_DIR$/modules/api" />
             <option value="$PROJECT_DIR$/modules/core" />
+            <option value="$PROJECT_DIR$/modules/ui" />
           </set>
         </option>
       </GradleProjectSettings>

.idea/misc.xml

@@ -1,4 +1,3 @@
-<?xml version="1.0" encoding="UTF-8"?>
 <project version="4">
   <component name="ExternalStorageConfigurationManager" enabled="true" />
   <component name="FrameworkDetectionExcludesConfiguration">

.idea/scala_compiler.xml

@@ -5,7 +5,7 @@
       <option name="deprecationWarnings" value="true" />
       <option name="uncheckedWarnings" value="true" />
     </profile>
-    <profile name="Gradle 2" modules="NowChessSystems.modules.core.main,NowChessSystems.modules.core.scoverage,NowChessSystems.modules.core.test">
+    <profile name="Gradle 2" modules="NowChessSystems.modules.core.main,NowChessSystems.modules.core.scoverage,NowChessSystems.modules.core.test,NowChessSystems.modules.ui.main,NowChessSystems.modules.ui.scoverage,NowChessSystems.modules.ui.test">
       <option name="deprecationWarnings" value="true" />
       <option name="uncheckedWarnings" value="true" />
       <parameters>

.idea/vcs.xml

@@ -6,6 +6,16 @@
       <inspection_tool class="CommitNamingConvention" enabled="true" level="WARNING" enabled_by_default="true" />
     </profile>
   </component>
+  <component name="IssueNavigationConfiguration">
+    <option name="links">
+      <list>
+        <IssueNavigationLink>
+          <option name="issueRegexp" value="(?x)\b(CORE|NCWF|BAC|FRO|K8S|ORG|NCI|NCS)-\d+\b#YouTrack" />
+          <option name="linkRegexp" value="https://knockoutwhist.youtrack.cloud/issue/$0" />
+        </IssueNavigationLink>
+      </list>
+    </option>
+  </component>
   <component name="VcsDirectoryMappings">
     <mapping directory="" vcs="Git" />
   </component>

.metals/metals.lock.db

@@ -1,6 +0,0 @@
-#FileLock
-#Sun Mar 29 15:06:23 CEST 2026
-hostName=localhost
-id=19d39612ed6c322b6ba3c2fc0853ca12997433c4dd8
-method=file
-server=localhost\:46585

CODE_NOTICE.md

@@ -1,41 +0,0 @@
-# 🔒 CODE FREEZE NOTICE
-
-## Date: March 29, 2026
-## Duration: Core Separation Refactor
-
-### Reason
-Implementing Command Pattern and Observer Pattern to decouple UI and logic interfaces.
-
-### Scope
-This refactor will:
-1. Extract TUI code from `core` module into standalone UI module
-2. Implement Command Pattern for all user interactions
-3. Implement Observer Pattern for state change notifications
-4. Make `core` completely UI-agnostic
-5. Enable multiple simultaneous UIs (TUI + future ScalaFX GUI)
-
-### Module Structure (Target)
-```
-modules/
-  core/        # Pure game logic, Command, Observer traits, CommandInvoker
-  api/         # Data models (unchanged)
-  ui/          # TUI and GUI implementations (both depend only on core)
-```
-
-### Expected Impact
-- All regression tests must pass
-- Build must succeed with new module structure
-- Core contains zero UI references
-- TUI and potential GUI can run independently or simultaneously
-
-### Blocked Changes
-Do not:
-- Add new features to `core`
-- Modify `core` API before Message & Observer traits are implemented
-- Create direct dependencies between UI modules
-- Add UI code to `core`
-
-Keep developing in separate branches until refactor is complete.
-
----
-Status: **IN PROGRESS** ✏️

docs/unresolved.md

@@ -0,0 +1,20 @@
+## [2026-03-31] Unreachable code blocking 100% statement coverage
+
+**Requirement/Bug:** Reach 100% statement coverage in core module.
+
+**Root Cause:** 4 remaining uncovered statements (99.6% coverage) are unreachable code:
+1. **PgnParser.scala:160** (`case _ => None` in extractPromotion) - Regex `=([QRBN])` only matches those 4 characters; fallback case can never execute
+2. **GameHistory.scala:29** (`addMove$default$4` compiler-generated method) - Method overload 3 without defaults shadows the 4-param version, making promotionPiece default accessor unreachable
+3. **GameEngine.scala:201-202** (`case _` in completePromotion) - GameController.completePromotion always returns one of 4 expected MoveResult types; catch-all is defensive code
+
+**Attempted Fixes:**
+1. Added comprehensive PGN parsing tests (all 4 promotion types) - PgnParser improved from 95.8% to 99.4%
+2. Added GameHistory tests using named parameters - hit `addMove$default$3` (castleSide) but not `$default$4` (promotionPiece)
+3. Named parameter approach: `addMove(from=..., to=..., promotionPiece=...)` triggers 4-param with castleSide default ✓
+4. Positional approach: `addMove(f, t, None, None)` requires all 4 args (explicit, no defaults used) - doesn't hit $default$4
+5. Root issue: Scala's overload resolution prefers more-specific non-default overloads (2-param, 3-param) over the 4-param with defaults
+
+**Recommendation:** 99.6% (1029/1033) is maximum achievable without refactoring method overloads. Unreachable code design patterns:
+- **Pattern 1 (unreachable regex fallback):** Defensive pattern match against exhaustive regex
+- **Pattern 2 (overshadowed defaults):** Method overloads shadow default parameters in parent signature
+- **Pattern 3 (defensive catch-all):** Error handling for impossible external API returns

modules/api/CHANGELOG.md

@@ -1,3 +1,5 @@
 ##  (2026-03-27)
 ##  (2026-03-28)
 ##  (2026-03-28)
+##  (2026-03-29)
+##  (2026-03-31)

modules/api/versions.env

@@ -1,3 +1,3 @@
 MAJOR=0
 MINOR=0
-PATCH=3
+PATCH=5

modules/core/CHANGELOG.md

@@ -44,3 +44,38 @@
 * add missing kings to gameLoop capture test board ([aedd787](https://git.janis-eccarius.de/NowChess/NowChessSystems/commit/aedd787b77203c2af934751dba7b784eaf165032))
 * correct test board positions and captureOutput/withInput interaction ([f0481e2](https://git.janis-eccarius.de/NowChess/NowChessSystems/commit/f0481e2561b779df00925b46ee281dc36a795150))
 * update main class path in build configuration and adjust VCS directory mapping ([7b1f8b1](https://git.janis-eccarius.de/NowChess/NowChessSystems/commit/7b1f8b117623d327232a1a92a8a44d18582e0189))
+##  (2026-03-29)
+
+### Features
+
+* add GameRules stub with PositionStatus enum ([76d4168](https://git.janis-eccarius.de/NowChess/NowChessSystems/commit/76d4168038de23e5d6083d4e8f0504fbf31d15a3))
+* add MovedInCheck/Checkmate/Stalemate MoveResult variants (stub dispatch) ([8b7ec57](https://git.janis-eccarius.de/NowChess/NowChessSystems/commit/8b7ec57e5ea6ee1615a1883848a426dc07d26364))
+* implement GameRules with isInCheck, legalMoves, gameStatus ([94a02ff](https://git.janis-eccarius.de/NowChess/NowChessSystems/commit/94a02ff6849436d9496c70a0f16c21666dae8e4e))
+* implement legal castling ([#1](https://git.janis-eccarius.de/NowChess/NowChessSystems/issues/1)) ([00d326c](https://git.janis-eccarius.de/NowChess/NowChessSystems/commit/00d326c1ba67711fbe180f04e1100c3f01dd0254))
+* NCS-6 Implementing FEN & PGN ([#7](https://git.janis-eccarius.de/NowChess/NowChessSystems/issues/7)) ([f28e69d](https://git.janis-eccarius.de/NowChess/NowChessSystems/commit/f28e69dc181416aa2f221fdc4b45c2cda5efbf07))
+* NCS-9 En passant implementation ([#8](https://git.janis-eccarius.de/NowChess/NowChessSystems/issues/8)) ([919beb3](https://git.janis-eccarius.de/NowChess/NowChessSystems/commit/919beb3b4bfa8caf2f90976a415fe9b19b7e9747))
+* wire check/checkmate/stalemate into processMove and gameLoop ([5264a22](https://git.janis-eccarius.de/NowChess/NowChessSystems/commit/5264a225418b885c5e6ea6411b96f85e38837f6c))
+
+### Bug Fixes
+
+* add missing kings to gameLoop capture test board ([aedd787](https://git.janis-eccarius.de/NowChess/NowChessSystems/commit/aedd787b77203c2af934751dba7b784eaf165032))
+* correct test board positions and captureOutput/withInput interaction ([f0481e2](https://git.janis-eccarius.de/NowChess/NowChessSystems/commit/f0481e2561b779df00925b46ee281dc36a795150))
+* update main class path in build configuration and adjust VCS directory mapping ([7b1f8b1](https://git.janis-eccarius.de/NowChess/NowChessSystems/commit/7b1f8b117623d327232a1a92a8a44d18582e0189))
+##  (2026-03-31)
+
+### Features
+
+* add GameRules stub with PositionStatus enum ([76d4168](https://git.janis-eccarius.de/NowChess/NowChessSystems/commit/76d4168038de23e5d6083d4e8f0504fbf31d15a3))
+* add MovedInCheck/Checkmate/Stalemate MoveResult variants (stub dispatch) ([8b7ec57](https://git.janis-eccarius.de/NowChess/NowChessSystems/commit/8b7ec57e5ea6ee1615a1883848a426dc07d26364))
+* implement GameRules with isInCheck, legalMoves, gameStatus ([94a02ff](https://git.janis-eccarius.de/NowChess/NowChessSystems/commit/94a02ff6849436d9496c70a0f16c21666dae8e4e))
+* implement legal castling ([#1](https://git.janis-eccarius.de/NowChess/NowChessSystems/issues/1)) ([00d326c](https://git.janis-eccarius.de/NowChess/NowChessSystems/commit/00d326c1ba67711fbe180f04e1100c3f01dd0254))
+* NCS-16 Core Separation via Patterns ([#10](https://git.janis-eccarius.de/NowChess/NowChessSystems/issues/10)) ([1361dfc](https://git.janis-eccarius.de/NowChess/NowChessSystems/commit/1361dfc89553b146864fb8ff3526cf12cf3f293a))
+* NCS-6 Implementing FEN & PGN ([#7](https://git.janis-eccarius.de/NowChess/NowChessSystems/issues/7)) ([f28e69d](https://git.janis-eccarius.de/NowChess/NowChessSystems/commit/f28e69dc181416aa2f221fdc4b45c2cda5efbf07))
+* NCS-9 En passant implementation ([#8](https://git.janis-eccarius.de/NowChess/NowChessSystems/issues/8)) ([919beb3](https://git.janis-eccarius.de/NowChess/NowChessSystems/commit/919beb3b4bfa8caf2f90976a415fe9b19b7e9747))
+* wire check/checkmate/stalemate into processMove and gameLoop ([5264a22](https://git.janis-eccarius.de/NowChess/NowChessSystems/commit/5264a225418b885c5e6ea6411b96f85e38837f6c))
+
+### Bug Fixes
+
+* add missing kings to gameLoop capture test board ([aedd787](https://git.janis-eccarius.de/NowChess/NowChessSystems/commit/aedd787b77203c2af934751dba7b784eaf165032))
+* correct test board positions and captureOutput/withInput interaction ([f0481e2](https://git.janis-eccarius.de/NowChess/NowChessSystems/commit/f0481e2561b779df00925b46ee281dc36a795150))
+* update main class path in build configuration and adjust VCS directory mapping ([7b1f8b1](https://git.janis-eccarius.de/NowChess/NowChessSystems/commit/7b1f8b117623d327232a1a92a8a44d18582e0189))

modules/core/src/main/scala/de/nowchess/chess/command/Command.scala

@@ -22,10 +22,10 @@ trait Command:
 case class MoveCommand(
   from: Square,
   to: Square,
-  var moveResult: Option[MoveResult] = None,
+  moveResult: Option[MoveResult] = None,
-  var previousBoard: Option[Board] = None,
+  previousBoard: Option[Board] = None,
-  var previousHistory: Option[GameHistory] = None,
+  previousHistory: Option[GameHistory] = None,
-  var previousTurn: Option[Color] = None
+  previousTurn: Option[Color] = None
 ) extends Command:
 
   override def execute(): Boolean =
@@ -51,9 +51,9 @@ case class QuitCommand() extends Command:
 
 /** Command to reset the board to initial position. */
 case class ResetCommand(
-  var previousBoard: Option[Board] = None,
+  previousBoard: Option[Board] = None,
-  var previousHistory: Option[GameHistory] = None,
+  previousHistory: Option[GameHistory] = None,
-  var previousTurn: Option[Color] = None
+  previousTurn: Option[Color] = None
 ) extends Command:
 
   override def execute(): Boolean = true

modules/core/src/main/scala/de/nowchess/chess/command/CommandInvoker.scala

@@ -8,7 +8,7 @@ class CommandInvoker:
   /** Execute a command and add it to history.
    *  Discards any redo history if not at the end of the stack.
    */
-  def execute(command: Command): Boolean =
+  def execute(command: Command): Boolean = synchronized {
     if command.execute() then
       // Remove any commands after current index (redo stack is discarded)
       while currentIndex < executedCommands.size - 1 do
@@ -18,9 +18,10 @@ class CommandInvoker:
       true
     else
       false
+  }
 
   /** Undo the last executed command if possible. */
-  def undo(): Boolean =
+  def undo(): Boolean = synchronized {
     if currentIndex >= 0 && currentIndex < executedCommands.size then
       val command = executedCommands(currentIndex)
       if command.undo() then
@@ -30,9 +31,10 @@ class CommandInvoker:
         false
     else
       false
+  }
 
   /** Redo the next command in history if available. */
-  def redo(): Boolean =
+  def redo(): Boolean = synchronized {
     if currentIndex + 1 < executedCommands.size then
       val command = executedCommands(currentIndex + 1)
       if command.execute() then
@@ -42,20 +44,30 @@ class CommandInvoker:
         false
     else
       false
+  }
 
   /** Get the history of all executed commands. */
-  def history: List[Command] = executedCommands.toList
+  def history: List[Command] = synchronized {
+    executedCommands.toList
+  }
 
   /** Get the current position in command history. */
-  def getCurrentIndex: Int = currentIndex
+  def getCurrentIndex: Int = synchronized {
+    currentIndex
+  }
 
   /** Clear all command history. */
-  def clear(): Unit =
+  def clear(): Unit = synchronized {
     executedCommands.clear()
     currentIndex = -1
+  }
 
   /** Check if undo is available. */
-  def canUndo: Boolean = currentIndex >= 0
+  def canUndo: Boolean = synchronized {
+    currentIndex >= 0
+  }
 
   /** Check if redo is available. */
-  def canRedo: Boolean = currentIndex + 1 < executedCommands.size
+  def canRedo: Boolean = synchronized {
+    currentIndex + 1 < executedCommands.size
+  }

modules/core/src/main/scala/de/nowchess/chess/controller/GameController.scala

@@ -1,6 +1,7 @@
 package de.nowchess.chess.controller
 
-import de.nowchess.api.board.{Board, Color, File, Piece, Rank, Square}
+import de.nowchess.api.board.{Board, Color, File, Piece, PieceType, Rank, Square}
+import de.nowchess.api.move.PromotionPiece
 import de.nowchess.chess.logic.*
 
 // ---------------------------------------------------------------------------
@@ -14,6 +15,14 @@ object MoveResult:
   case object NoPiece                                                                   extends MoveResult
   case object WrongColor                                                                extends MoveResult
   case object IllegalMove                                                               extends MoveResult
+  case class  PromotionRequired(
+    from: Square,
+    to: Square,
+    boardBefore: Board,
+    historyBefore: GameHistory,
+    captured: Option[Piece],
+    turn: Color
+  ) extends MoveResult
   case class  Moved(newBoard: Board, newHistory: GameHistory, captured: Option[Piece], newTurn: Color)      extends MoveResult
   case class  MovedInCheck(newBoard: Board, newHistory: GameHistory, captured: Option[Piece], newTurn: Color) extends MoveResult
   case class  Checkmate(winner: Color)                                                  extends MoveResult
@@ -30,25 +39,49 @@ object GameController:
    */
   def processMove(board: Board, history: GameHistory, turn: Color, raw: String): MoveResult =
     raw.trim match
-      case "quit" | "q" =>
+      case "quit" | "q" => MoveResult.Quit
-        MoveResult.Quit
       case trimmed =>
         Parser.parseMove(trimmed) match
-          case None =>
+          case None              => MoveResult.InvalidFormat(trimmed)
-            MoveResult.InvalidFormat(trimmed)
+          case Some((from, to))  => validateAndApply(board, history, turn, from, to)
-          case Some((from, to)) =>
+
+  /** Apply a previously detected promotion move with the chosen piece.
+   *  Called after processMove returned PromotionRequired.
+   */
+  def completePromotion(
+    board: Board,
+    history: GameHistory,
+    from: Square,
+    to: Square,
+    piece: PromotionPiece,
+    turn: Color
+  ): MoveResult =
+    val (boardAfterMove, captured) = board.withMove(from, to)
+    val promotedPieceType = piece match
+      case PromotionPiece.Queen  => PieceType.Queen
+      case PromotionPiece.Rook   => PieceType.Rook
+      case PromotionPiece.Bishop => PieceType.Bishop
+      case PromotionPiece.Knight => PieceType.Knight
+    val newBoard    = boardAfterMove.updated(to, Piece(turn, promotedPieceType))
+    val newHistory  = history.addMove(from, to, None, Some(piece))
+    toMoveResult(newBoard, newHistory, captured, turn)
+
+  // ---------------------------------------------------------------------------
+  // Private helpers
+  // ---------------------------------------------------------------------------
+
+  private def validateAndApply(board: Board, history: GameHistory, turn: Color, from: Square, to: Square): MoveResult =
     board.pieceAt(from) match
-              case None =>
+      case None                              => MoveResult.NoPiece
-                MoveResult.NoPiece
+      case Some(piece) if piece.color != turn => MoveResult.WrongColor
-              case Some(piece) if piece.color != turn =>
-                MoveResult.WrongColor
       case Some(_) =>
-                if !MoveValidator.isLegal(board, history, from, to) then
+        if !GameRules.legalMoves(board, history, turn).contains(from -> to) then MoveResult.IllegalMove
-                  MoveResult.IllegalMove
+        else if MoveValidator.isPromotionMove(board, from, to) then
-                else
+          MoveResult.PromotionRequired(from, to, board, history, board.pieceAt(to), turn)
-                  val castleOpt = if MoveValidator.isCastle(board, from, to)
+        else applyNormalMove(board, history, turn, from, to)
-                                  then Some(MoveValidator.castleSide(from, to))
+
-                                  else None
+  private def applyNormalMove(board: Board, history: GameHistory, turn: Color, from: Square, to: Square): MoveResult =
+    val castleOpt              = Option.when(MoveValidator.isCastle(board, from, to))(MoveValidator.castleSide(from, to))
     val isEP                   = EnPassantCalculator.isEnPassant(board, history, from, to)
     val (newBoard, captured)   = castleOpt match
       case Some(side) => (board.withCastle(turn, side), None)
@@ -59,6 +92,9 @@ object GameController:
           (b.removed(capturedSq), board.pieceAt(capturedSq))
         else (b, cap)
     val newHistory = history.addMove(from, to, castleOpt)
+    toMoveResult(newBoard, newHistory, captured, turn)
+
+  private def toMoveResult(newBoard: Board, newHistory: GameHistory, captured: Option[Piece], turn: Color): MoveResult =
     GameRules.gameStatus(newBoard, newHistory, turn.opposite) match
       case PositionStatus.Normal  => MoveResult.Moved(newBoard, newHistory, captured, turn.opposite)
       case PositionStatus.InCheck => MoveResult.MovedInCheck(newBoard, newHistory, captured, turn.opposite)

modules/core/src/main/scala/de/nowchess/chess/engine/GameEngine.scala

@@ -1,6 +1,7 @@
 package de.nowchess.chess.engine
 
 import de.nowchess.api.board.{Board, Color, Piece, Square}
+import de.nowchess.api.move.PromotionPiece
 import de.nowchess.chess.logic.{GameHistory, GameRules, PositionStatus}
 import de.nowchess.chess.controller.{GameController, Parser, MoveResult}
 import de.nowchess.chess.observer.*
@@ -11,12 +12,31 @@ import de.nowchess.chess.command.{CommandInvoker, MoveCommand}
  *  All user interactions must go through this engine via Commands, and all state changes
  *  are communicated to observers via GameEvent notifications.
  */
-class GameEngine extends Observable:
+class GameEngine(
-  private var currentBoard: Board = Board.initial
+  initialBoard: Board = Board.initial,
-  private var currentHistory: GameHistory = GameHistory.empty
+  initialHistory: GameHistory = GameHistory.empty,
-  private var currentTurn: Color = Color.White
+  initialTurn: Color = Color.White,
+  completePromotionFn: (Board, GameHistory, Square, Square, PromotionPiece, Color) => MoveResult =
+    GameController.completePromotion
+) extends Observable:
+  private var currentBoard: Board = initialBoard
+  private var currentHistory: GameHistory = initialHistory
+  private var currentTurn: Color = initialTurn
   private val invoker = new CommandInvoker()
 
+  /** Inner class for tracking pending promotion state */
+  private case class PendingPromotion(
+    from: Square, to: Square,
+    boardBefore: Board, historyBefore: GameHistory,
+    turn: Color
+  )
+
+  /** Current pending promotion, if any */
+  private var pendingPromotion: Option[PendingPromotion] = None
+
+  /** True if a pawn promotion move is pending and needs a piece choice. */
+  def isPendingPromotion: Boolean = synchronized { pendingPromotion.isDefined }
+
   // Synchronized accessors for current state
   def board: Board = synchronized { currentBoard }
   def history: GameHistory = synchronized { currentHistory }
@@ -80,33 +100,28 @@ class GameEngine extends Observable:
 
             // Execute the move through GameController
             GameController.processMove(currentBoard, currentHistory, currentTurn, moveInput) match
-              case MoveResult.Quit =>
+              case MoveResult.InvalidFormat(_) | MoveResult.NoPiece | MoveResult.WrongColor | MoveResult.IllegalMove | MoveResult.Quit =>
-                // Should not happen via processUserInput, but handle it
-                ()
-
-              case MoveResult.InvalidFormat(_) | MoveResult.NoPiece | MoveResult.WrongColor | MoveResult.IllegalMove =>
-                // Move failed, don't add to history
                 handleFailedMove(moveInput)
 
               case MoveResult.Moved(newBoard, newHistory, captured, newTurn) =>
                 // Move succeeded - store result and execute through invoker
-                cmd.moveResult = Some(de.nowchess.chess.command.MoveResult.Successful(newBoard, newHistory, newTurn, captured))
+                val updatedCmd = cmd.copy(moveResult = Some(de.nowchess.chess.command.MoveResult.Successful(newBoard, newHistory, newTurn, captured)))
-                invoker.execute(cmd)
+                invoker.execute(updatedCmd)
                 updateGameState(newBoard, newHistory, newTurn)
                 emitMoveEvent(from.toString, to.toString, captured, newTurn)
 
               case MoveResult.MovedInCheck(newBoard, newHistory, captured, newTurn) =>
                 // Move succeeded with check
-                cmd.moveResult = Some(de.nowchess.chess.command.MoveResult.Successful(newBoard, newHistory, newTurn, captured))
+                val updatedCmd = cmd.copy(moveResult = Some(de.nowchess.chess.command.MoveResult.Successful(newBoard, newHistory, newTurn, captured)))
-                invoker.execute(cmd)
+                invoker.execute(updatedCmd)
                 updateGameState(newBoard, newHistory, newTurn)
                 emitMoveEvent(from.toString, to.toString, captured, newTurn)
                 notifyObservers(CheckDetectedEvent(currentBoard, currentHistory, currentTurn))
 
               case MoveResult.Checkmate(winner) =>
                 // Move resulted in checkmate
-                cmd.moveResult = Some(de.nowchess.chess.command.MoveResult.Successful(Board.initial, GameHistory.empty, Color.White, None))
+                val updatedCmd = cmd.copy(moveResult = Some(de.nowchess.chess.command.MoveResult.Successful(Board.initial, GameHistory.empty, Color.White, None)))
-                invoker.execute(cmd)
+                invoker.execute(updatedCmd)
                 currentBoard = Board.initial
                 currentHistory = GameHistory.empty
                 currentTurn = Color.White
@@ -114,12 +129,16 @@ class GameEngine extends Observable:
 
               case MoveResult.Stalemate =>
                 // Move resulted in stalemate
-                cmd.moveResult = Some(de.nowchess.chess.command.MoveResult.Successful(Board.initial, GameHistory.empty, Color.White, None))
+                val updatedCmd = cmd.copy(moveResult = Some(de.nowchess.chess.command.MoveResult.Successful(Board.initial, GameHistory.empty, Color.White, None)))
-                invoker.execute(cmd)
+                invoker.execute(updatedCmd)
                 currentBoard = Board.initial
                 currentHistory = GameHistory.empty
                 currentTurn = Color.White
                 notifyObservers(StalemateEvent(currentBoard, currentHistory, currentTurn))
+
+              case MoveResult.PromotionRequired(promFrom, promTo, boardBefore, histBefore, _, promotingTurn) =>
+                pendingPromotion = Some(PendingPromotion(promFrom, promTo, boardBefore, histBefore, promotingTurn))
+                notifyObservers(PromotionRequiredEvent(currentBoard, currentHistory, currentTurn, promFrom, promTo))
   }
 
   /** Undo the last move. */
@@ -132,6 +151,59 @@ class GameEngine extends Observable:
     performRedo()
   }
 
+  /** Apply a player's promotion piece choice.
+   *  Must only be called when isPendingPromotion is true.
+   */
+  def completePromotion(piece: PromotionPiece): Unit = synchronized {
+    pendingPromotion match
+      case None =>
+        notifyObservers(InvalidMoveEvent(currentBoard, currentHistory, currentTurn, "No promotion pending."))
+      case Some(pending) =>
+        pendingPromotion = None
+        val cmd = MoveCommand(
+          from = pending.from,
+          to = pending.to,
+          previousBoard = Some(pending.boardBefore),
+          previousHistory = Some(pending.historyBefore),
+          previousTurn = Some(pending.turn)
+        )
+        completePromotionFn(
+          pending.boardBefore, pending.historyBefore,
+          pending.from, pending.to, piece, pending.turn
+        ) match
+          case MoveResult.Moved(newBoard, newHistory, captured, newTurn) =>
+            val updatedCmd = cmd.copy(moveResult = Some(de.nowchess.chess.command.MoveResult.Successful(newBoard, newHistory, newTurn, captured)))
+            invoker.execute(updatedCmd)
+            updateGameState(newBoard, newHistory, newTurn)
+            emitMoveEvent(pending.from.toString, pending.to.toString, captured, newTurn)
+
+          case MoveResult.MovedInCheck(newBoard, newHistory, captured, newTurn) =>
+            val updatedCmd = cmd.copy(moveResult = Some(de.nowchess.chess.command.MoveResult.Successful(newBoard, newHistory, newTurn, captured)))
+            invoker.execute(updatedCmd)
+            updateGameState(newBoard, newHistory, newTurn)
+            emitMoveEvent(pending.from.toString, pending.to.toString, captured, newTurn)
+            notifyObservers(CheckDetectedEvent(currentBoard, currentHistory, currentTurn))
+
+          case MoveResult.Checkmate(winner) =>
+            val updatedCmd = cmd.copy(moveResult = Some(de.nowchess.chess.command.MoveResult.Successful(Board.initial, GameHistory.empty, Color.White, None)))
+            invoker.execute(updatedCmd)
+            currentBoard = Board.initial
+            currentHistory = GameHistory.empty
+            currentTurn = Color.White
+            notifyObservers(CheckmateEvent(currentBoard, currentHistory, currentTurn, winner))
+
+          case MoveResult.Stalemate =>
+            val updatedCmd = cmd.copy(moveResult = Some(de.nowchess.chess.command.MoveResult.Successful(Board.initial, GameHistory.empty, Color.White, None)))
+            invoker.execute(updatedCmd)
+            currentBoard = Board.initial
+            currentHistory = GameHistory.empty
+            currentTurn = Color.White
+            notifyObservers(StalemateEvent(currentBoard, currentHistory, currentTurn))
+
+          case _ =>
+            notifyObservers(InvalidMoveEvent(currentBoard, currentHistory, currentTurn, "Error completing promotion."))
+  }
+
   /** Reset the board to initial position. */
   def reset(): Unit = synchronized {
     currentBoard = Board.initial
@@ -149,48 +221,26 @@ class GameEngine extends Observable:
 
   private def performUndo(): Unit =
     if invoker.canUndo then
-      val history = invoker.history
+      val cmd = invoker.history(invoker.getCurrentIndex)
-      val currentIdx = invoker.getCurrentIndex
+      (cmd: @unchecked) match
-      if currentIdx >= 0 && currentIdx < history.size then
-        val cmd = history(currentIdx)
-        cmd match
         case moveCmd: MoveCommand =>
-            if moveCmd.undo() then
           moveCmd.previousBoard.foreach(currentBoard = _)
           moveCmd.previousHistory.foreach(currentHistory = _)
           moveCmd.previousTurn.foreach(currentTurn = _)
           invoker.undo()
           notifyObservers(BoardResetEvent(currentBoard, currentHistory, currentTurn))
-            else
-              notifyObservers(InvalidMoveEvent(currentBoard, currentHistory, currentTurn, "Cannot undo this move."))
-          case _ =>
-            // Other command types - just revert the invoker
-            invoker.undo()
-            notifyObservers(BoardResetEvent(currentBoard, currentHistory, currentTurn))
     else
       notifyObservers(InvalidMoveEvent(currentBoard, currentHistory, currentTurn, "Nothing to undo."))
 
   private def performRedo(): Unit =
     if invoker.canRedo then
-      val history = invoker.history
+      val cmd = invoker.history(invoker.getCurrentIndex + 1)
-      val nextIdx = invoker.getCurrentIndex + 1
+      (cmd: @unchecked) match
-      if nextIdx >= 0 && nextIdx < history.size then
-        val cmd = history(nextIdx)
-        cmd match
         case moveCmd: MoveCommand =>
-            if moveCmd.execute() then
+          for case de.nowchess.chess.command.MoveResult.Successful(nb, nh, nt, cap) <- moveCmd.moveResult do
-              moveCmd.moveResult.foreach {
+            updateGameState(nb, nh, nt)
-                case de.nowchess.chess.command.MoveResult.Successful(newBoard, newHistory, newTurn, captured) =>
-                  updateGameState(newBoard, newHistory, newTurn)
             invoker.redo()
-                  emitMoveEvent(moveCmd.from.toString, moveCmd.to.toString, captured, newTurn)
+            emitMoveEvent(moveCmd.from.toString, moveCmd.to.toString, cap, nt)
-                case _ => ()
-              }
-            else
-              notifyObservers(InvalidMoveEvent(currentBoard, currentHistory, currentTurn, "Cannot redo this move."))
-          case _ =>
-            invoker.redo()
-            notifyObservers(BoardResetEvent(currentBoard, currentHistory, currentTurn))
     else
       notifyObservers(InvalidMoveEvent(currentBoard, currentHistory, currentTurn, "Nothing to redo."))
 
@@ -211,14 +261,7 @@ class GameEngine extends Observable:
     ))
 
   private def handleFailedMove(moveInput: String): Unit =
-    GameController.processMove(currentBoard, currentHistory, currentTurn, moveInput) match
+    (GameController.processMove(currentBoard, currentHistory, currentTurn, moveInput): @unchecked) match
-      case MoveResult.InvalidFormat(raw) =>
-        notifyObservers(InvalidMoveEvent(
-          currentBoard,
-          currentHistory,
-          currentTurn,
-          s"Invalid move format '$raw'. Use coordinate notation, e.g. e2e4."
-        ))
       case MoveResult.NoPiece =>
         notifyObservers(InvalidMoveEvent(
           currentBoard,
@@ -240,6 +283,4 @@ class GameEngine extends Observable:
           currentTurn,
           "Illegal move."
         ))
-      case _ => ()
 
-end GameEngine

modules/core/src/main/scala/de/nowchess/chess/logic/GameHistory.scala

@@ -1,12 +1,14 @@
 package de.nowchess.chess.logic
 
 import de.nowchess.api.board.Square
+import de.nowchess.api.move.PromotionPiece
 
 /** A single move recorded in the game history. Distinct from api.move.Move which represents user intent. */
 case class HistoryMove(
   from: Square,
   to: Square,
-  castleSide: Option[CastleSide]
+  castleSide: Option[CastleSide],
+  promotionPiece: Option[PromotionPiece] = None
 )
 
 /** Complete game history: ordered list of moves. */
@@ -17,8 +19,13 @@ case class GameHistory(moves: List[HistoryMove] = List.empty):
   def addMove(from: Square, to: Square): GameHistory =
     addMove(HistoryMove(from, to, None))
 
-  def addMove(from: Square, to: Square, castleSide: Option[CastleSide]): GameHistory =
+  def addMove(
-    addMove(HistoryMove(from, to, castleSide))
+    from: Square,
+    to: Square,
+    castleSide: Option[CastleSide] = None,
+    promotionPiece: Option[PromotionPiece] = None
+  ): GameHistory =
+    addMove(HistoryMove(from, to, castleSide, promotionPiece))
 
 object GameHistory:
   val empty: GameHistory = GameHistory()

modules/core/src/main/scala/de/nowchess/chess/logic/MoveValidator.scala

@@ -173,3 +173,11 @@ object MoveValidator:
 
   def isLegal(board: Board, history: GameHistory, from: Square, to: Square): Boolean =
     legalTargets(board, history, from).contains(to)
+
+  /** Returns true if the piece on `from` is a pawn moving to its back rank (promotion). */
+  def isPromotionMove(board: Board, from: Square, to: Square): Boolean =
+    board.pieceAt(from) match
+      case Some(Piece(_, PieceType.Pawn)) =>
+        (from.rank == Rank.R7 && to.rank == Rank.R8) ||
+        (from.rank == Rank.R2 && to.rank == Rank.R1)
+      case _ => false

modules/core/src/main/scala/de/nowchess/chess/notation/PgnExporter.scala

@@ -1,6 +1,7 @@
 package de.nowchess.chess.notation
 
 import de.nowchess.api.board.*
+import de.nowchess.api.move.PromotionPiece
 import de.nowchess.chess.logic.{CastleSide, GameHistory, HistoryMove}
 
 object PgnExporter:
@@ -32,4 +33,11 @@ object PgnExporter:
     move.castleSide match
       case Some(CastleSide.Kingside)  => "O-O"
       case Some(CastleSide.Queenside) => "O-O-O"
-      case None => s"${move.from}${move.to}"
+      case None =>
+        val base = s"${move.from}${move.to}"
+        move.promotionPiece match
+          case Some(PromotionPiece.Queen)  => s"$base=Q"
+          case Some(PromotionPiece.Rook)   => s"$base=R"
+          case Some(PromotionPiece.Bishop) => s"$base=B"
+          case Some(PromotionPiece.Knight) => s"$base=N"
+          case None                        => base

modules/core/src/main/scala/de/nowchess/chess/notation/PgnParser.scala

@@ -1,6 +1,7 @@
 package de.nowchess.chess.notation
 
 import de.nowchess.api.board.*
+import de.nowchess.api.move.PromotionPiece
 import de.nowchess.chess.logic.{CastleSide, GameHistory, HistoryMove, GameRules, MoveValidator, withCastle}
 
 /** A parsed PGN game containing headers and the resolved move list. */
@@ -43,14 +44,28 @@ object PgnParser:
           parseAlgebraicMove(token, board, history, color) match
             case None       => state  // unrecognised token — skip silently
             case Some(move) =>
-              val newBoard = move.castleSide match
+              val newBoard   = applyMoveToBoard(board, move, color)
-                case Some(side) => board.withCastle(color, side)
-                case None       => board.withMove(move.from, move.to)._1
               val newHistory = history.addMove(move)
               (newBoard, newHistory, color.opposite, acc :+ move)
 
     moves
 
+  /** Apply a single HistoryMove to a Board, handling castling and promotion. */
+  private def applyMoveToBoard(board: Board, move: HistoryMove, color: Color): Board =
+    move.castleSide match
+      case Some(side) => board.withCastle(color, side)
+      case None =>
+        val (boardAfterMove, _) = board.withMove(move.from, move.to)
+        move.promotionPiece match
+          case Some(pp) =>
+            val pieceType = pp match
+              case PromotionPiece.Queen  => PieceType.Queen
+              case PromotionPiece.Rook   => PieceType.Rook
+              case PromotionPiece.Bishop => PieceType.Bishop
+              case PromotionPiece.Knight => PieceType.Knight
+            boardAfterMove.updated(move.to, Piece(color, pieceType))
+          case None => boardAfterMove
+
   /** True for move-number tokens ("1.", "12.") and PGN result tokens. */
   private def isMoveNumberOrResult(token: String): Boolean =
     token.matches("""\d+\.""") ||
@@ -128,16 +143,26 @@ object PgnParser:
           if hint.isEmpty then byPiece
           else byPiece.filter(from => matchesHint(from, hint))
 
-        disambiguated.headOption.map(from => HistoryMove(from, toSquare, None))
+        val promotion = extractPromotion(notation)
+        disambiguated.headOption.map(from => HistoryMove(from, toSquare, None, promotion))
 
   /** True if `sq` matches a disambiguation hint (file letter, rank digit, or both). */
   private def matchesHint(sq: Square, hint: String): Boolean =
-    hint.foldLeft(true): (ok, c) =>
+    hint.forall(c => if c >= 'a' && c <= 'h' then sq.file.toString.equalsIgnoreCase(c.toString)
-      ok && (
-        if c >= 'a' && c <= 'h' then sq.file.toString.equalsIgnoreCase(c.toString)
     else if c >= '1' && c <= '8' then sq.rank.ordinal == (c - '1')
-        else true
+    else true)
-      )
+
+  /** Extract a promotion piece from a notation string containing =Q/=R/=B/=N. */
+  private[notation] def extractPromotion(notation: String): Option[PromotionPiece] =
+    val promotionPattern = """=([A-Z])""".r
+    promotionPattern.findFirstMatchIn(notation).flatMap { m =>
+      m.group(1) match
+        case "Q" => Some(PromotionPiece.Queen)
+        case "R" => Some(PromotionPiece.Rook)
+        case "B" => Some(PromotionPiece.Bishop)
+        case "N" => Some(PromotionPiece.Knight)
+        case _   => None
+    }
 
   /** Convert a piece-letter character to a PieceType. */
   private def charToPieceType(c: Char): Option[PieceType] =

modules/core/src/main/scala/de/nowchess/chess/observer/Observer.scala

@@ -1,6 +1,6 @@
 package de.nowchess.chess.observer
 
-import de.nowchess.api.board.{Board, Color}
+import de.nowchess.api.board.{Board, Color, Square}
 import de.nowchess.chess.logic.GameHistory
 
 /** Base trait for all game state events.
@@ -51,6 +51,15 @@ case class InvalidMoveEvent(
   reason: String
 ) extends GameEvent
 
+/** Fired when a pawn reaches the back rank and the player must choose a promotion piece. */
+case class PromotionRequiredEvent(
+  board: Board,
+  history: GameHistory,
+  turn: Color,
+  from: Square,
+  to: Square
+) extends GameEvent
+
 /** Fired when the board is reset. */
 case class BoardResetEvent(
   board: Board,
@@ -67,16 +76,21 @@ trait Observable:
   private val observers = scala.collection.mutable.Set[Observer]()
 
   /** Register an observer to receive game events. */
-  def subscribe(observer: Observer): Unit =
+  def subscribe(observer: Observer): Unit = synchronized {
     observers += observer
+  }
 
   /** Unregister an observer. */
-  def unsubscribe(observer: Observer): Unit =
+  def unsubscribe(observer: Observer): Unit = synchronized {
     observers -= observer
+  }
 
   /** Notify all observers of a game event. */
-  protected def notifyObservers(event: GameEvent): Unit =
+  protected def notifyObservers(event: GameEvent): Unit = synchronized {
     observers.foreach(_.onGameEvent(event))
+  }
 
   /** Return current list of observers (for testing). */
-  def observerCount: Int = observers.size
+  def observerCount: Int = synchronized {
+    observers.size
+  }

modules/core/src/test/scala/de/nowchess/chess/command/CommandInvokerBranchTest.scala

@@ -214,4 +214,3 @@ class CommandInvokerBranchTest extends AnyFunSuite with Matchers:
     invoker.execute(cmd3)  // While loop condition should be false, no iterations
     invoker.history.size shouldBe 3
 
-end CommandInvokerBranchTest

modules/core/src/test/scala/de/nowchess/chess/command/CommandInvokerTest.scala

@@ -121,4 +121,3 @@ class CommandInvokerTest extends AnyFunSuite with Matchers:
     invoker.history(1) shouldBe cmd3
     invoker.getCurrentIndex shouldBe 1
 
-end CommandInvokerTest

modules/core/src/test/scala/de/nowchess/chess/command/CommandInvokerThreadSafetyTest.scala

@@ -0,0 +1,131 @@
+package de.nowchess.chess.command
+
+import de.nowchess.api.board.{Square, File, Rank, Board, Color}
+import de.nowchess.chess.logic.GameHistory
+import org.scalatest.funsuite.AnyFunSuite
+import org.scalatest.matchers.should.Matchers
+import scala.collection.mutable
+
+class CommandInvokerThreadSafetyTest extends AnyFunSuite with Matchers:
+
+  private def sq(f: File, r: Rank): Square = Square(f, r)
+
+  private def createMoveCommand(from: Square, to: Square): MoveCommand =
+    MoveCommand(
+      from = from,
+      to = to,
+      moveResult = Some(MoveResult.Successful(Board.initial, GameHistory.empty, Color.White, None)),
+      previousBoard = Some(Board.initial),
+      previousHistory = Some(GameHistory.empty),
+      previousTurn = Some(Color.White)
+    )
+
+  test("CommandInvoker is thread-safe for concurrent execute and history reads"):
+    val invoker = new CommandInvoker()
+    @volatile var raceDetected = false
+    val exceptions = mutable.ListBuffer[Exception]()
+
+    // Thread 1: executes commands
+    val executorThread = new Thread(new Runnable {
+      def run(): Unit = {
+        try {
+          for i <- 1 to 1000 do
+            val cmd = createMoveCommand(
+              sq(File.E, Rank.R2),
+              sq(File.E, Rank.R4)
+            )
+            invoker.execute(cmd)
+        } catch {
+          case e: Exception =>
+            exceptions += e
+            raceDetected = true
+        }
+      }
+    })
+
+    // Thread 2: reads history during execution
+    val readerThread = new Thread(new Runnable {
+      def run(): Unit = {
+        try {
+          for _ <- 1 to 1000 do
+            val _ = invoker.history
+            val _ = invoker.getCurrentIndex
+            Thread.sleep(0) // Yield to increase contention
+        } catch {
+          case e: Exception =>
+            exceptions += e
+            raceDetected = true
+        }
+      }
+    })
+
+    executorThread.start()
+    readerThread.start()
+    executorThread.join()
+    readerThread.join()
+
+    exceptions.isEmpty shouldBe true
+    raceDetected shouldBe false
+
+  test("CommandInvoker is thread-safe for concurrent execute, undo, and redo"):
+    val invoker = new CommandInvoker()
+    @volatile var raceDetected = false
+    val exceptions = mutable.ListBuffer[Exception]()
+
+    // Pre-populate with some commands
+    for _ <- 1 to 5 do
+      invoker.execute(createMoveCommand(sq(File.E, Rank.R2), sq(File.E, Rank.R4)))
+
+    // Thread 1: executes new commands
+    val executorThread = new Thread(new Runnable {
+      def run(): Unit = {
+        try {
+          for _ <- 1 to 500 do
+            invoker.execute(createMoveCommand(sq(File.D, Rank.R2), sq(File.D, Rank.R4)))
+        } catch {
+          case e: Exception =>
+            exceptions += e
+            raceDetected = true
+        }
+      }
+    })
+
+    // Thread 2: undoes commands
+    val undoThread = new Thread(new Runnable {
+      def run(): Unit = {
+        try {
+          for _ <- 1 to 500 do
+            if invoker.canUndo then
+              invoker.undo()
+        } catch {
+          case e: Exception =>
+            exceptions += e
+            raceDetected = true
+        }
+      }
+    })
+
+    // Thread 3: redoes commands
+    val redoThread = new Thread(new Runnable {
+      def run(): Unit = {
+        try {
+          for _ <- 1 to 500 do
+            if invoker.canRedo then
+              invoker.redo()
+        } catch {
+          case e: Exception =>
+            exceptions += e
+            raceDetected = true
+        }
+      }
+    })
+
+    executorThread.start()
+    undoThread.start()
+    redoThread.start()
+    executorThread.join()
+    undoThread.join()
+    redoThread.join()
+
+    exceptions.isEmpty shouldBe true
+    raceDetected shouldBe false

modules/core/src/test/scala/de/nowchess/chess/command/CommandTest.scala

@@ -50,4 +50,3 @@ class CommandTest extends AnyFunSuite with Matchers:
     val cmd = ResetCommand()
     cmd.description shouldBe "Reset board"
 
-end CommandTest

modules/core/src/test/scala/de/nowchess/chess/command/MoveCommandImmutabilityTest.scala

@@ -0,0 +1,65 @@
+package de.nowchess.chess.command
+
+import de.nowchess.api.board.{Square, File, Rank, Board, Color}
+import de.nowchess.chess.logic.GameHistory
+import org.scalatest.funsuite.AnyFunSuite
+import org.scalatest.matchers.should.Matchers
+
+class MoveCommandImmutabilityTest extends AnyFunSuite with Matchers:
+
+  private def sq(f: File, r: Rank): Square = Square(f, r)
+
+  test("MoveCommand should be immutable - fields cannot be mutated after creation"):
+    val cmd1 = MoveCommand(
+      from = sq(File.E, Rank.R2),
+      to = sq(File.E, Rank.R4)
+    )
+
+    // Create second command with filled state
+    val result = MoveResult.Successful(Board.initial, GameHistory.empty, Color.Black, None)
+    val cmd2 = cmd1.copy(
+      moveResult = Some(result),
+      previousBoard = Some(Board.initial),
+      previousHistory = Some(GameHistory.empty),
+      previousTurn = Some(Color.White)
+    )
+
+    // Original should be unchanged
+    cmd1.moveResult shouldBe None
+    cmd1.previousBoard shouldBe None
+    cmd1.previousHistory shouldBe None
+    cmd1.previousTurn shouldBe None
+
+    // New should have values
+    cmd2.moveResult shouldBe Some(result)
+    cmd2.previousBoard shouldBe Some(Board.initial)
+    cmd2.previousHistory shouldBe Some(GameHistory.empty)
+    cmd2.previousTurn shouldBe Some(Color.White)
+
+  test("MoveCommand equals and hashCode respect immutability"):
+    val cmd1 = MoveCommand(
+      from = sq(File.E, Rank.R2),
+      to = sq(File.E, Rank.R4),
+      moveResult = None,
+      previousBoard = None,
+      previousHistory = None,
+      previousTurn = None
+    )
+
+    val cmd2 = MoveCommand(
+      from = sq(File.E, Rank.R2),
+      to = sq(File.E, Rank.R4),
+      moveResult = None,
+      previousBoard = None,
+      previousHistory = None,
+      previousTurn = None
+    )
+
+    // Same values should be equal
+    cmd1 shouldBe cmd2
+    cmd1.hashCode shouldBe cmd2.hashCode
+
+    // Hash should be consistent (required for use as map keys)
+    val hash1 = cmd1.hashCode
+    val hash2 = cmd1.hashCode
+    hash1 shouldBe hash2

modules/core/src/test/scala/de/nowchess/chess/controller/GameControllerTest.scala

@@ -2,7 +2,9 @@ package de.nowchess.chess.controller
 
 import de.nowchess.api.board.*
 import de.nowchess.api.game.CastlingRights
+import de.nowchess.api.move.PromotionPiece
 import de.nowchess.chess.logic.{CastleSide, GameHistory}
+import de.nowchess.chess.notation.FenParser
 import org.scalatest.funsuite.AnyFunSuite
 import org.scalatest.matchers.should.Matchers
 
@@ -41,6 +43,30 @@ class GameControllerTest extends AnyFunSuite with Matchers:
     // White pawn at E2 cannot jump three squares to E5
     processMove(Board.initial, GameHistory.empty, Color.White, "e2e5") shouldBe MoveResult.IllegalMove
 
+  test("processMove: move that leaves own king in check returns IllegalMove"):
+    // White King E1 is in check from Black Rook E8. Moving the D2 pawn is
+    // geometrically legal but does not resolve the check — must be rejected.
+    val b = Board(Map(
+      sq(File.E, Rank.R1) -> Piece.WhiteKing,
+      sq(File.D, Rank.R2) -> Piece.WhitePawn,
+      sq(File.E, Rank.R8) -> Piece.BlackRook,
+      sq(File.A, Rank.R8) -> Piece.BlackKing
+    ))
+    processMove(b, GameHistory.empty, Color.White, "d2d4") shouldBe MoveResult.IllegalMove
+
+  test("processMove: move that resolves check is allowed"):
+    // White King E1 is in check from Black Rook E8 along the E-file.
+    // White Rook A5 interposes at E5 — resolves the check, no new check on Black King A8.
+    val b = Board(Map(
+      sq(File.E, Rank.R1) -> Piece.WhiteKing,
+      sq(File.A, Rank.R5) -> Piece.WhiteRook,
+      sq(File.E, Rank.R8) -> Piece.BlackRook,
+      sq(File.A, Rank.R8) -> Piece.BlackKing
+    ))
+    processMove(b, GameHistory.empty, Color.White, "a5e5") match
+      case _: MoveResult.Moved => succeed
+      case other => fail(s"Expected Moved, got $other")
+
   test("processMove: legal pawn move returns Moved with updated board and flipped turn"):
     processMove(Board.initial, GameHistory.empty, Color.White, "e2e4") match
       case MoveResult.Moved(newBoard, newHistory, captured, newTurn) =>
@@ -293,3 +319,172 @@ class GameControllerTest extends AnyFunSuite with Matchers:
         newBoard.pieceAt(Square(File.E, Rank.R3)) shouldBe Some(Piece.BlackPawn)  // capturing pawn placed
         captured shouldBe Some(Piece.WhitePawn)
       case other => fail(s"Expected Moved but got $other")
+
+  // ──── pawn promotion detection ───────────────────────────────────────────
+
+  test("processMove detects white pawn reaching R8 and returns PromotionRequired"):
+    val board = FenParser.parseBoard("8/4P3/4k3/8/8/8/8/8").get
+    val result = GameController.processMove(board, GameHistory.empty, Color.White, "e7e8")
+    result should matchPattern { case _: MoveResult.PromotionRequired => }
+    result match
+      case MoveResult.PromotionRequired(from, to, _, _, _, turn) =>
+        from should be (sq(File.E, Rank.R7))
+        to   should be (sq(File.E, Rank.R8))
+        turn should be (Color.White)
+      case _ => fail("Expected PromotionRequired")
+
+  test("processMove detects black pawn reaching R1 and returns PromotionRequired"):
+    val board = FenParser.parseBoard("8/8/8/8/4K3/8/4p3/8").get
+    val result = GameController.processMove(board, GameHistory.empty, Color.Black, "e2e1")
+    result should matchPattern { case _: MoveResult.PromotionRequired => }
+    result match
+      case MoveResult.PromotionRequired(from, to, _, _, _, turn) =>
+        from should be (sq(File.E, Rank.R2))
+        to   should be (sq(File.E, Rank.R1))
+        turn should be (Color.Black)
+      case _ => fail("Expected PromotionRequired")
+
+  test("processMove detects pawn capturing to back rank as PromotionRequired with captured piece"):
+    val board = FenParser.parseBoard("3q4/4P3/8/8/8/8/8/8").get
+    val result = GameController.processMove(board, GameHistory.empty, Color.White, "e7d8")
+    result should matchPattern { case _: MoveResult.PromotionRequired => }
+    result match
+      case MoveResult.PromotionRequired(_, _, _, _, captured, _) =>
+        captured should be (Some(Piece(Color.Black, PieceType.Queen)))
+      case _ => fail("Expected PromotionRequired")
+
+  // ──── completePromotion ──────────────────────────────────────────────────
+
+  test("completePromotion applies move and places queen"):
+    // Black king on h1: not attacked by queen on e8 (different file, rank, and diagonals)
+    val board = FenParser.parseBoard("8/4P3/8/8/8/8/8/7k").get
+    val result = GameController.completePromotion(
+      board, GameHistory.empty,
+      sq(File.E, Rank.R7), sq(File.E, Rank.R8),
+      PromotionPiece.Queen, Color.White
+    )
+    result should matchPattern { case _: MoveResult.Moved => }
+    result match
+      case MoveResult.Moved(newBoard, newHistory, _, _) =>
+        newBoard.pieceAt(sq(File.E, Rank.R8)) should be (Some(Piece(Color.White, PieceType.Queen)))
+        newBoard.pieceAt(sq(File.E, Rank.R7)) should be (None)
+        newHistory.moves should have length 1
+        newHistory.moves.head.promotionPiece should be (Some(PromotionPiece.Queen))
+      case _ => fail("Expected Moved")
+
+  test("completePromotion with rook underpromotion"):
+    // Black king on h1: not attacked by rook on e8 (different file and rank)
+    val board = FenParser.parseBoard("8/4P3/8/8/8/8/8/7k").get
+    val result = GameController.completePromotion(
+      board, GameHistory.empty,
+      sq(File.E, Rank.R7), sq(File.E, Rank.R8),
+      PromotionPiece.Rook, Color.White
+    )
+    result match
+      case MoveResult.Moved(newBoard, newHistory, _, _) =>
+        newBoard.pieceAt(sq(File.E, Rank.R8)) should be (Some(Piece(Color.White, PieceType.Rook)))
+        newHistory.moves.head.promotionPiece should be (Some(PromotionPiece.Rook))
+      case _ => fail("Expected Moved with Rook")
+
+  test("completePromotion with bishop underpromotion"):
+    val board = FenParser.parseBoard("8/4P3/4k3/8/8/8/8/8").get
+    val result = GameController.completePromotion(
+      board, GameHistory.empty,
+      sq(File.E, Rank.R7), sq(File.E, Rank.R8),
+      PromotionPiece.Bishop, Color.White
+    )
+    result match
+      case MoveResult.Moved(newBoard, newHistory, _, _) =>
+        newBoard.pieceAt(sq(File.E, Rank.R8)) should be (Some(Piece(Color.White, PieceType.Bishop)))
+        newHistory.moves.head.promotionPiece should be (Some(PromotionPiece.Bishop))
+      case _ => fail("Expected Moved with Bishop")
+
+  test("completePromotion with knight underpromotion"):
+    val board = FenParser.parseBoard("8/4P3/4k3/8/8/8/8/8").get
+    val result = GameController.completePromotion(
+      board, GameHistory.empty,
+      sq(File.E, Rank.R7), sq(File.E, Rank.R8),
+      PromotionPiece.Knight, Color.White
+    )
+    result match
+      case MoveResult.Moved(newBoard, newHistory, _, _) =>
+        newBoard.pieceAt(sq(File.E, Rank.R8)) should be (Some(Piece(Color.White, PieceType.Knight)))
+        newHistory.moves.head.promotionPiece should be (Some(PromotionPiece.Knight))
+      case _ => fail("Expected Moved with Knight")
+
+  test("completePromotion captures opponent piece"):
+    // Black king on h1: after white queen captures d8 queen, h1 king is safe (queen on d8 does not attack h1)
+    val board = FenParser.parseBoard("3q4/4P3/8/8/8/8/8/7k").get
+    val result = GameController.completePromotion(
+      board, GameHistory.empty,
+      sq(File.E, Rank.R7), sq(File.D, Rank.R8),
+      PromotionPiece.Queen, Color.White
+    )
+    result match
+      case MoveResult.Moved(newBoard, _, captured, _) =>
+        newBoard.pieceAt(sq(File.D, Rank.R8)) should be (Some(Piece(Color.White, PieceType.Queen)))
+        captured should be (Some(Piece(Color.Black, PieceType.Queen)))
+      case _ => fail("Expected Moved with captured piece")
+
+  test("completePromotion for black pawn to R1"):
+    val board = FenParser.parseBoard("8/8/8/8/4K3/8/4p3/8").get
+    val result = GameController.completePromotion(
+      board, GameHistory.empty,
+      sq(File.E, Rank.R2), sq(File.E, Rank.R1),
+      PromotionPiece.Knight, Color.Black
+    )
+    result match
+      case MoveResult.Moved(newBoard, newHistory, _, _) =>
+        newBoard.pieceAt(sq(File.E, Rank.R1)) should be (Some(Piece(Color.Black, PieceType.Knight)))
+        newHistory.moves.head.promotionPiece should be (Some(PromotionPiece.Knight))
+      case _ => fail("Expected Moved")
+
+  test("completePromotion evaluates check after promotion"):
+    val board = FenParser.parseBoard("3k4/4P3/8/8/8/8/8/8").get
+    val result = GameController.completePromotion(
+      board, GameHistory.empty,
+      sq(File.E, Rank.R7), sq(File.E, Rank.R8),
+      PromotionPiece.Queen, Color.White
+    )
+    result should matchPattern { case _: MoveResult.MovedInCheck => }
+
+  test("completePromotion full round-trip via processMove then completePromotion"):
+    // Black king on h1: not attacked by queen on e8
+    val board = FenParser.parseBoard("8/4P3/8/8/8/8/8/7k").get
+    GameController.processMove(board, GameHistory.empty, Color.White, "e7e8") match
+      case MoveResult.PromotionRequired(from, to, boardBefore, histBefore, _, turn) =>
+        val result = GameController.completePromotion(boardBefore, histBefore, from, to, PromotionPiece.Queen, turn)
+        result should matchPattern { case _: MoveResult.Moved => }
+        result match
+          case MoveResult.Moved(finalBoard, finalHistory, _, _) =>
+            finalBoard.pieceAt(sq(File.E, Rank.R8)) should be (Some(Piece(Color.White, PieceType.Queen)))
+            finalHistory.moves.head.promotionPiece should be (Some(PromotionPiece.Queen))
+          case _ => fail("Expected Moved")
+      case _ => fail("Expected PromotionRequired")
+
+  test("completePromotion results in checkmate when promotion delivers checkmate"):
+    // Black king a8, white pawn h7, white king b6.
+    // After h7→h8=Q: Qh8 attacks rank 8 putting Ka8 in check;
+    // a7 covered by Kb6, b7 covered by Kb6, b8 covered by Qh8 — no escape.
+    val board = FenParser.parseBoard("k7/7P/1K6/8/8/8/8/8").get
+    val result = GameController.completePromotion(
+      board, GameHistory.empty,
+      sq(File.H, Rank.R7), sq(File.H, Rank.R8),
+      PromotionPiece.Queen, Color.White
+    )
+    result should matchPattern { case MoveResult.Checkmate(_) => }
+    result match
+      case MoveResult.Checkmate(winner) => winner should be (Color.White)
+      case _ => fail("Expected Checkmate")
+
+  test("completePromotion results in stalemate when promotion stalemates opponent"):
+    // Black king a8, white pawn b7, white bishop c7, white king b6.
+    // After b7→b8=N: knight on b8 (doesn't check a8); a7 and b7 covered by Kb6;
+    // b8 defended by Bc7 so Ka8xb8 would walk into bishop — no legal moves.
+    val board = FenParser.parseBoard("k7/1PB5/1K6/8/8/8/8/8").get
+    val result = GameController.completePromotion(
+      board, GameHistory.empty,
+      sq(File.B, Rank.R7), sq(File.B, Rank.R8),
+      PromotionPiece.Knight, Color.White
+    )
+    result should be (MoveResult.Stalemate)

modules/core/src/test/scala/de/nowchess/chess/engine/GameEngineEdgeCasesTest.scala

@@ -0,0 +1,214 @@
+package de.nowchess.chess.engine
+
+import scala.collection.mutable
+import de.nowchess.api.board.{Board, Color}
+import de.nowchess.chess.logic.GameHistory
+import de.nowchess.chess.observer.{Observer, GameEvent, MoveExecutedEvent, CheckDetectedEvent, BoardResetEvent, InvalidMoveEvent}
+import org.scalatest.funsuite.AnyFunSuite
+import org.scalatest.matchers.should.Matchers
+
+/** Tests for GameEngine edge cases and uncovered paths */
+class GameEngineEdgeCasesTest extends AnyFunSuite with Matchers:
+
+  test("GameEngine handles empty input"):
+    val engine = new GameEngine()
+    val observer = new MockObserver()
+    engine.subscribe(observer)
+    
+    engine.processUserInput("")
+    
+    observer.events.size shouldBe 1
+    observer.events.head shouldBe an[InvalidMoveEvent]
+    val event = observer.events.head.asInstanceOf[InvalidMoveEvent]
+    event.reason should include("Please enter a valid move or command")
+
+  test("GameEngine processes quit command"):
+    val engine = new GameEngine()
+    val observer = new MockObserver()
+    engine.subscribe(observer)
+    
+    engine.processUserInput("quit")
+    // Quit just returns, no events
+    observer.events.isEmpty shouldBe true
+
+  test("GameEngine processes q command (short form)"):
+    val engine = new GameEngine()
+    val observer = new MockObserver()
+    engine.subscribe(observer)
+    
+    engine.processUserInput("q")
+    observer.events.isEmpty shouldBe true
+
+  test("GameEngine handles uppercase quit"):
+    val engine = new GameEngine()
+    val observer = new MockObserver()
+    engine.subscribe(observer)
+    
+    engine.processUserInput("QUIT")
+    observer.events.isEmpty shouldBe true
+
+  test("GameEngine handles undo on empty history"):
+    val engine = new GameEngine()
+    val observer = new MockObserver()
+    engine.subscribe(observer)
+    
+    engine.canUndo shouldBe false
+    engine.processUserInput("undo")
+    
+    observer.events.size shouldBe 1
+    observer.events.head shouldBe an[InvalidMoveEvent]
+    val event = observer.events.head.asInstanceOf[InvalidMoveEvent]
+    event.reason should include("Nothing to undo")
+
+  test("GameEngine handles redo on empty redo history"):
+    val engine = new GameEngine()
+    val observer = new MockObserver()
+    engine.subscribe(observer)
+    
+    engine.canRedo shouldBe false
+    engine.processUserInput("redo")
+    
+    observer.events.size shouldBe 1
+    observer.events.head shouldBe an[InvalidMoveEvent]
+    val event = observer.events.head.asInstanceOf[InvalidMoveEvent]
+    event.reason should include("Nothing to redo")
+
+  test("GameEngine parses invalid move format"):
+    val engine = new GameEngine()
+    val observer = new MockObserver()
+    engine.subscribe(observer)
+    
+    engine.processUserInput("invalid_move_format")
+    
+    observer.events.size shouldBe 1
+    observer.events.head shouldBe an[InvalidMoveEvent]
+    val event = observer.events.head.asInstanceOf[InvalidMoveEvent]
+    event.reason should include("Invalid move format")
+
+  test("GameEngine handles lowercase input normalization"):
+    val engine = new GameEngine()
+    val observer = new MockObserver()
+    engine.subscribe(observer)
+    
+    engine.processUserInput("  UNDO  ")  // With spaces and uppercase
+    
+    observer.events.size shouldBe 1
+    observer.events.head shouldBe an[InvalidMoveEvent]  // No moves to undo yet
+
+  test("GameEngine preserves board state on invalid move"):
+    val engine = new GameEngine()
+    val initialBoard = engine.board
+    
+    engine.processUserInput("invalid")
+    
+    engine.board shouldBe initialBoard
+
+  test("GameEngine preserves turn on invalid move"):
+    val engine = new GameEngine()
+    val initialTurn = engine.turn
+    
+    engine.processUserInput("invalid")
+    
+    engine.turn shouldBe initialTurn
+
+  test("GameEngine undo with no commands available"):
+    val engine = new GameEngine()
+    val observer = new MockObserver()
+    engine.subscribe(observer)
+    
+    // Make a valid move
+    engine.processUserInput("e2e4")
+    observer.events.clear()
+    
+    // Undo it
+    engine.processUserInput("undo")
+    
+    // Board should be reset
+    engine.board shouldBe Board.initial
+    engine.turn shouldBe Color.White
+
+  test("GameEngine redo after undo"):
+    val engine = new GameEngine()
+    val observer = new MockObserver()
+    engine.subscribe(observer)
+    
+    engine.processUserInput("e2e4")
+    val boardAfterMove = engine.board
+    val turnAfterMove = engine.turn
+    observer.events.clear()
+    
+    engine.processUserInput("undo")
+    engine.processUserInput("redo")
+    
+    engine.board shouldBe boardAfterMove
+    engine.turn shouldBe turnAfterMove
+
+  test("GameEngine canUndo flag tracks state correctly"):
+    val engine = new GameEngine()
+    
+    engine.canUndo shouldBe false
+    engine.processUserInput("e2e4")
+    engine.canUndo shouldBe true
+    engine.processUserInput("undo")
+    engine.canUndo shouldBe false
+
+  test("GameEngine canRedo flag tracks state correctly"):
+    val engine = new GameEngine()
+    
+    engine.canRedo shouldBe false
+    engine.processUserInput("e2e4")
+    engine.canRedo shouldBe false
+    engine.processUserInput("undo")
+    engine.canRedo shouldBe true
+
+  test("GameEngine command history is accessible"):
+    val engine = new GameEngine()
+    
+    engine.commandHistory.isEmpty shouldBe true
+    engine.processUserInput("e2e4")
+    engine.commandHistory.size shouldBe 1
+
+  test("GameEngine processes multiple moves in sequence"):
+    val engine = new GameEngine()
+    val observer = new MockObserver()
+    engine.subscribe(observer)
+    observer.events.clear()
+    
+    engine.processUserInput("e2e4")
+    engine.processUserInput("e7e5")
+    
+    observer.events.size shouldBe 2
+    engine.commandHistory.size shouldBe 2
+
+  test("GameEngine can undo multiple moves"):
+    val engine = new GameEngine()
+    
+    engine.processUserInput("e2e4")
+    engine.processUserInput("e7e5")
+    
+    engine.processUserInput("undo")
+    engine.turn shouldBe Color.Black
+    
+    engine.processUserInput("undo")
+    engine.turn shouldBe Color.White
+
+  test("GameEngine thread-safe operations"):
+    val engine = new GameEngine()
+    
+    // Access from synchronized methods
+    val board = engine.board
+    val history = engine.history
+    val turn = engine.turn
+    val canUndo = engine.canUndo
+    val canRedo = engine.canRedo
+    
+    board shouldBe Board.initial
+    canUndo shouldBe false
+    canRedo shouldBe false
+
+
+private class MockObserver extends Observer:
+  val events = mutable.ListBuffer[GameEvent]()
+  
+  override def onGameEvent(event: GameEvent): Unit =
+    events += event

modules/core/src/test/scala/de/nowchess/chess/engine/GameEngineGameEndingTest.scala

@@ -0,0 +1,93 @@
+package de.nowchess.chess.engine
+
+import scala.collection.mutable
+import de.nowchess.api.board.{Board, Color}
+import de.nowchess.chess.logic.GameHistory
+import de.nowchess.chess.observer.{Observer, GameEvent, CheckDetectedEvent, CheckmateEvent, StalemateEvent}
+import org.scalatest.funsuite.AnyFunSuite
+import org.scalatest.matchers.should.Matchers
+
+/** Tests for GameEngine check/checkmate/stalemate paths */
+class GameEngineGameEndingTest extends AnyFunSuite with Matchers:
+
+  test("GameEngine handles Checkmate (Fool's Mate)"):
+    val engine = new GameEngine()
+    val observer = new EndingMockObserver()
+    engine.subscribe(observer)
+    
+    // Play Fool's mate
+    engine.processUserInput("f2f3")
+    engine.processUserInput("e7e5")
+    engine.processUserInput("g2g4")
+    
+    observer.events.clear()
+    engine.processUserInput("d8h4")
+    
+    // Verify CheckmateEvent
+    observer.events.size shouldBe 1
+    observer.events.head shouldBe a[CheckmateEvent]
+    
+    val event = observer.events.head.asInstanceOf[CheckmateEvent]
+    event.winner shouldBe Color.Black
+    
+    // Board should be reset after checkmate
+    engine.board shouldBe Board.initial
+    engine.turn shouldBe Color.White
+
+  test("GameEngine handles check detection"):
+    val engine = new GameEngine()
+    val observer = new EndingMockObserver()
+    engine.subscribe(observer)
+    
+    // Play a simple check
+    engine.processUserInput("e2e4")
+    engine.processUserInput("e7e5")
+    engine.processUserInput("f1c4")
+    engine.processUserInput("g8f6")
+    
+    observer.events.clear()
+    engine.processUserInput("c4f7") // Check!
+    
+    val checkEvents = observer.events.collect { case e: CheckDetectedEvent => e }
+    checkEvents.size shouldBe 1
+    checkEvents.head.turn shouldBe Color.Black // Black is now in check
+    
+  // Shortest known stalemate is 19 moves. Here is a faster one:
+  // e3 a5 Qh5 Ra6 Qxa5 h5 h4 Rah6 Qxc7 f6 Qxd7+ Kf7 Qxb7 Qd3 Qxb8 Qh7 Qxc8 Kg6 Qe6
+  // Wait, let's just use Sam Loyd's 10-move stalemate:
+  // 1. e3 a5 2. Qh5 Ra6 3. Qxa5 h5 4. h4 Rah6 5. Qxc7 f6 6. Qxd7+ Kf7 7. Qxb7 Qd3 8. Qxb8 Qh7 9. Qxc8 Kg6 10. Qe6
+  test("GameEngine handles Stalemate via 10-move known sequence"):
+    val engine = new GameEngine()
+    val observer = new EndingMockObserver()
+    engine.subscribe(observer)
+    
+    val moves = List(
+      "e2e3", "a7a5",
+      "d1h5", "a8a6",
+      "h5a5", "h7h5",
+      "h2h4", "a6h6",
+      "a5c7", "f7f6",
+      "c7d7", "e8f7",
+      "d7b7", "d8d3",
+      "b7b8", "d3h7",
+      "b8c8", "f7g6",
+      "c8e6"
+    )
+    
+    moves.dropRight(1).foreach(engine.processUserInput)
+    
+    observer.events.clear()
+    engine.processUserInput(moves.last)
+    
+    val stalemateEvents = observer.events.collect { case e: StalemateEvent => e }
+    stalemateEvents.size shouldBe 1
+    
+    // Board should be reset after stalemate
+    engine.board shouldBe Board.initial
+    engine.turn shouldBe Color.White
+
+private class EndingMockObserver extends Observer:
+  val events = mutable.ListBuffer[GameEvent]()
+  
+  override def onGameEvent(event: GameEvent): Unit =
+    events += event

modules/core/src/test/scala/de/nowchess/chess/engine/GameEngineHandleFailedMoveTest.scala

@@ -0,0 +1,110 @@
+package de.nowchess.chess.engine
+
+import scala.collection.mutable
+import de.nowchess.api.board.{Board, Color}
+import de.nowchess.chess.logic.GameHistory
+import de.nowchess.chess.observer.{Observer, GameEvent, InvalidMoveEvent}
+import org.scalatest.funsuite.AnyFunSuite
+import org.scalatest.matchers.should.Matchers
+
+/** Tests to maximize handleFailedMove coverage */
+class GameEngineHandleFailedMoveTest extends AnyFunSuite with Matchers:
+
+  test("GameEngine handles InvalidFormat error type"):
+    val engine = new GameEngine()
+    val observer = new MockObserver()
+    engine.subscribe(observer)
+    
+    engine.processUserInput("not_a_valid_move_format")
+    observer.events.size shouldBe 1
+    observer.events.head shouldBe an[InvalidMoveEvent]
+    val msg1 = observer.events.head.asInstanceOf[InvalidMoveEvent].reason
+    msg1 should include("Invalid move format")
+
+  test("GameEngine handles NoPiece error type"):
+    val engine = new GameEngine()
+    val observer = new MockObserver()
+    engine.subscribe(observer)
+    
+    engine.processUserInput("h3h4")
+    observer.events.size shouldBe 1
+    observer.events.head shouldBe an[InvalidMoveEvent]
+    val msg2 = observer.events.head.asInstanceOf[InvalidMoveEvent].reason
+    msg2 should include("No piece on that square")
+
+  test("GameEngine handles WrongColor error type"):
+    val engine = new GameEngine()
+    val observer = new MockObserver()
+    engine.subscribe(observer)
+    
+    engine.processUserInput("e2e4")  // White move
+    observer.events.clear()
+    
+    engine.processUserInput("a1b2")  // Try to move black's rook position with white's move (wrong color)
+    observer.events.size shouldBe 1
+    observer.events.head shouldBe an[InvalidMoveEvent]
+    val msg3 = observer.events.head.asInstanceOf[InvalidMoveEvent].reason
+    msg3 should include("That is not your piece")
+
+  test("GameEngine handles IllegalMove error type"):
+    val engine = new GameEngine()
+    val observer = new MockObserver()
+    engine.subscribe(observer)
+    
+    engine.processUserInput("e2e1")  // Try pawn backward
+    observer.events.size shouldBe 1
+    observer.events.head shouldBe an[InvalidMoveEvent]
+    val msg4 = observer.events.head.asInstanceOf[InvalidMoveEvent].reason
+    msg4 should include("Illegal move")
+
+  test("GameEngine invalid move message for InvalidFormat"):
+    val engine = new GameEngine()
+    val observer = new MockObserver()
+    engine.subscribe(observer)
+    
+    engine.processUserInput("xyz123")
+    val event = observer.events.head.asInstanceOf[InvalidMoveEvent]
+    event.reason should include("coordinate notation")
+
+  test("GameEngine invalid move message for NoPiece"):
+    val engine = new GameEngine()
+    val observer = new MockObserver()
+    engine.subscribe(observer)
+    
+    engine.processUserInput("a3a4")  // a3 is empty
+    val event = observer.events.head.asInstanceOf[InvalidMoveEvent]
+    event.reason should include("No piece")
+
+  test("GameEngine invalid move message for WrongColor"):
+    val engine = new GameEngine()
+    val observer = new MockObserver()
+    engine.subscribe(observer)
+    
+    engine.processUserInput("e2e4")
+    observer.events.clear()
+    
+    engine.processUserInput("e4e5")  // e4 has white pawn, it's black's turn
+    val event = observer.events.head.asInstanceOf[InvalidMoveEvent]
+    event.reason should include("not your piece")
+
+  test("GameEngine invalid move message for IllegalMove"):
+    val engine = new GameEngine()
+    val observer = new MockObserver()
+    engine.subscribe(observer)
+    
+    engine.processUserInput("e2e1")  // Pawn can't move backward
+    val event = observer.events.head.asInstanceOf[InvalidMoveEvent]
+    event.reason should include("Illegal move")
+
+  test("GameEngine board unchanged after each type of invalid move"):
+    val engine = new GameEngine()
+    val initial = engine.board
+    
+    engine.processUserInput("invalid")
+    engine.board shouldBe initial
+    
+    engine.processUserInput("h3h4")
+    engine.board shouldBe initial
+    
+    engine.processUserInput("e2e1")
+    engine.board shouldBe initial

modules/core/src/test/scala/de/nowchess/chess/engine/GameEngineInvalidMovesTest.scala

@@ -0,0 +1,114 @@
+package de.nowchess.chess.engine
+
+import scala.collection.mutable
+import de.nowchess.api.board.{Board, Color}
+import de.nowchess.chess.logic.GameHistory
+import de.nowchess.chess.observer.{Observer, GameEvent, InvalidMoveEvent, MoveExecutedEvent}
+import org.scalatest.funsuite.AnyFunSuite
+import org.scalatest.matchers.should.Matchers
+
+/** Tests for GameEngine invalid move handling via handleFailedMove */
+class GameEngineInvalidMovesTest extends AnyFunSuite with Matchers:
+
+  test("GameEngine handles no piece at source square"):
+    val engine = new GameEngine()
+    val observer = new MockObserver()
+    engine.subscribe(observer)
+    
+    // Try to move from h1 which may be empty or not have our piece
+    // We'll try from a clearly empty square
+    engine.processUserInput("h1h2")
+    
+    // Should get an InvalidMoveEvent about NoPiece
+    observer.events.size shouldBe 1
+    observer.events.head shouldBe an[InvalidMoveEvent]
+
+  test("GameEngine handles moving wrong color piece"):
+    val engine = new GameEngine()
+    val observer = new MockObserver()
+    engine.subscribe(observer)
+    
+    // White moves first
+    engine.processUserInput("e2e4")
+    observer.events.clear()
+    
+    // White tries to move again (should fail - it's black's turn)
+    // But we need to try a move that looks legal but has wrong color
+    // This is hard to test because we'd need to be black and move white's piece
+    // Let's skip this for now and focus on testable cases
+    
+    // Actually, let's try moving a square that definitely has the wrong piece
+    // Move a white pawn as black by reaching that position
+    engine.processUserInput("e7e5")
+    observer.events.clear()
+    
+    // Now try to move white's e4 pawn as black (it's black's turn but e4 is white)
+    engine.processUserInput("e4e5")
+    
+    observer.events.size shouldBe 1
+    val event = observer.events.head
+    event shouldBe an[InvalidMoveEvent]
+
+  test("GameEngine handles illegal move"):
+    val engine = new GameEngine()
+    val observer = new MockObserver()
+    engine.subscribe(observer)
+    
+    // A pawn can't move backward
+    engine.processUserInput("e2e1")
+    
+    observer.events.size shouldBe 1
+    observer.events.head shouldBe an[InvalidMoveEvent]
+    val event = observer.events.head.asInstanceOf[InvalidMoveEvent]
+    event.reason should include("Illegal move")
+
+  test("GameEngine handles pawn trying to move 3 squares"):
+    val engine = new GameEngine()
+    val observer = new MockObserver()
+    engine.subscribe(observer)
+    
+    // Pawn can only move 1 or 2 squares on first move, not 3
+    engine.processUserInput("e2e5")
+    
+    observer.events.size shouldBe 1
+    observer.events.head shouldBe an[InvalidMoveEvent]
+
+  test("GameEngine handles moving from empty square"):
+    val engine = new GameEngine()
+    val observer = new MockObserver()
+    engine.subscribe(observer)
+    
+    // h3 is empty in starting position
+    engine.processUserInput("h3h4")
+    
+    observer.events.size shouldBe 1
+    observer.events.head shouldBe an[InvalidMoveEvent]
+    val event = observer.events.head.asInstanceOf[InvalidMoveEvent]
+    event.reason should include("No piece on that square")
+
+  test("GameEngine processes valid move after invalid attempt"):
+    val engine = new GameEngine()
+    val observer = new MockObserver()
+    engine.subscribe(observer)
+    
+    // Try invalid move
+    engine.processUserInput("h3h4")
+    observer.events.clear()
+    
+    // Make valid move
+    engine.processUserInput("e2e4")
+    
+    observer.events.size shouldBe 1
+    observer.events.head shouldBe an[MoveExecutedEvent]
+
+  test("GameEngine maintains state after failed move attempt"):
+    val engine = new GameEngine()
+    val initialTurn = engine.turn
+    val initialBoard = engine.board
+    
+    // Try invalid move
+    engine.processUserInput("h3h4")
+    
+    // State should not change
+    engine.turn shouldBe initialTurn
+    engine.board shouldBe initialBoard

modules/core/src/test/scala/de/nowchess/chess/engine/GameEnginePromotionTest.scala

@@ -0,0 +1,167 @@
+package de.nowchess.chess.engine
+
+import de.nowchess.api.board.{Board, Color, File, Piece, PieceType, Rank, Square}
+import de.nowchess.api.move.PromotionPiece
+import de.nowchess.chess.logic.GameHistory
+import de.nowchess.chess.notation.FenParser
+import de.nowchess.chess.observer.*
+import org.scalatest.funsuite.AnyFunSuite
+import org.scalatest.matchers.should.Matchers
+
+class GameEnginePromotionTest extends AnyFunSuite with Matchers:
+
+  private def sq(f: File, r: Rank): Square = Square(f, r)
+
+  private def captureEvents(engine: GameEngine): collection.mutable.ListBuffer[GameEvent] =
+    val events = collection.mutable.ListBuffer[GameEvent]()
+    engine.subscribe(new Observer { def onGameEvent(e: GameEvent): Unit = events += e })
+    events
+
+  test("processUserInput fires PromotionRequiredEvent when pawn reaches back rank") {
+    val promotionBoard = FenParser.parseBoard("8/4P3/4k3/8/8/8/8/8").get
+    val engine = new GameEngine(initialBoard = promotionBoard)
+    val events = captureEvents(engine)
+
+    engine.processUserInput("e7e8")
+
+    events.exists(_.isInstanceOf[PromotionRequiredEvent]) should be (true)
+    events.collect { case e: PromotionRequiredEvent => e }.head.from should be (sq(File.E, Rank.R7))
+  }
+
+  test("isPendingPromotion is true after PromotionRequired input") {
+    val promotionBoard = FenParser.parseBoard("8/4P3/4k3/8/8/8/8/8").get
+    val engine = new GameEngine(initialBoard = promotionBoard)
+    captureEvents(engine)
+
+    engine.processUserInput("e7e8")
+
+    engine.isPendingPromotion should be (true)
+  }
+
+  test("isPendingPromotion is false before any promotion input") {
+    val engine = new GameEngine()
+    engine.isPendingPromotion should be (false)
+  }
+
+  test("completePromotion fires MoveExecutedEvent with promoted piece") {
+    val promotionBoard = FenParser.parseBoard("8/4P3/4k3/8/8/8/8/8").get
+    val engine = new GameEngine(initialBoard = promotionBoard)
+    val events = captureEvents(engine)
+
+    engine.processUserInput("e7e8")
+    engine.completePromotion(PromotionPiece.Queen)
+
+    engine.isPendingPromotion should be (false)
+    engine.board.pieceAt(sq(File.E, Rank.R8)) should be (Some(Piece(Color.White, PieceType.Queen)))
+    engine.board.pieceAt(sq(File.E, Rank.R7)) should be (None)
+    engine.history.moves.head.promotionPiece should be (Some(PromotionPiece.Queen))
+    events.exists(_.isInstanceOf[MoveExecutedEvent]) should be (true)
+  }
+
+  test("completePromotion with rook underpromotion") {
+    val promotionBoard = FenParser.parseBoard("8/4P3/4k3/8/8/8/8/8").get
+    val engine = new GameEngine(initialBoard = promotionBoard)
+    captureEvents(engine)
+
+    engine.processUserInput("e7e8")
+    engine.completePromotion(PromotionPiece.Rook)
+
+    engine.board.pieceAt(sq(File.E, Rank.R8)) should be (Some(Piece(Color.White, PieceType.Rook)))
+  }
+
+  test("completePromotion with no pending promotion fires InvalidMoveEvent") {
+    val engine = new GameEngine()
+    val events = captureEvents(engine)
+
+    engine.completePromotion(PromotionPiece.Queen)
+
+    events.exists(_.isInstanceOf[InvalidMoveEvent]) should be (true)
+    engine.isPendingPromotion should be (false)
+  }
+
+  test("completePromotion fires CheckDetectedEvent when promotion gives check") {
+    val promotionBoard = FenParser.parseBoard("3k4/4P3/8/8/8/8/8/8").get
+    val engine = new GameEngine(initialBoard = promotionBoard)
+    val events = captureEvents(engine)
+
+    engine.processUserInput("e7e8")
+    engine.completePromotion(PromotionPiece.Queen)
+
+    events.exists(_.isInstanceOf[CheckDetectedEvent]) should be (true)
+  }
+
+  test("completePromotion results in Moved when promotion doesn't give check") {
+    // White pawn on e7, black king on a2 (far away, not in check after promotion)
+    val board = FenParser.parseBoard("8/4P3/8/8/8/8/k7/8").get
+    val engine = new GameEngine(initialBoard = board)
+    val events = captureEvents(engine)
+
+    engine.processUserInput("e7e8")
+    engine.completePromotion(PromotionPiece.Queen)
+
+    engine.isPendingPromotion should be (false)
+    engine.board.pieceAt(sq(File.E, Rank.R8)) should be (Some(Piece(Color.White, PieceType.Queen)))
+    events.filter(_.isInstanceOf[MoveExecutedEvent]) should not be empty
+    events.exists(_.isInstanceOf[CheckDetectedEvent]) should be (false)
+  }
+
+  test("completePromotion results in Checkmate when promotion delivers checkmate") {
+    // Black king on a8, white king on b6, white pawn on h7
+    // h7->h8=Q delivers checkmate
+    val board = FenParser.parseBoard("k7/7P/1K6/8/8/8/8/8").get
+    val engine = new GameEngine(initialBoard = board)
+    val events = captureEvents(engine)
+
+    engine.processUserInput("h7h8")
+    engine.completePromotion(PromotionPiece.Queen)
+
+    engine.isPendingPromotion should be (false)
+    events.exists(_.isInstanceOf[CheckmateEvent]) should be (true)
+  }
+
+  test("completePromotion results in Stalemate when promotion creates stalemate") {
+    // Black king on a8, white pawn on b7, white bishop on c7, white king on b6
+    // b7->b8=N: no check; Ka8 has no legal moves -> stalemate
+    val board = FenParser.parseBoard("k7/1PB5/1K6/8/8/8/8/8").get
+    val engine = new GameEngine(initialBoard = board)
+    val events = captureEvents(engine)
+
+    engine.processUserInput("b7b8")
+    engine.completePromotion(PromotionPiece.Knight)
+
+    engine.isPendingPromotion should be (false)
+    events.exists(_.isInstanceOf[StalemateEvent]) should be (true)
+  }
+
+  test("completePromotion with black pawn promotion results in Moved") {
+    // Black pawn e2, white king h3 (not on rank 1 or file e), black king a8
+    // e2->e1=Q: queen on e1 does not attack h3 -> normal Moved
+    val board = FenParser.parseBoard("k7/8/8/8/8/7K/4p3/8").get
+    val engine = new GameEngine(initialBoard = board, initialTurn = Color.Black)
+    val events = captureEvents(engine)
+
+    engine.processUserInput("e2e1")
+    engine.completePromotion(PromotionPiece.Queen)
+
+    engine.isPendingPromotion should be (false)
+    engine.board.pieceAt(sq(File.E, Rank.R1)) should be (Some(Piece(Color.Black, PieceType.Queen)))
+    events.filter(_.isInstanceOf[MoveExecutedEvent]) should not be empty
+    events.exists(_.isInstanceOf[CheckDetectedEvent]) should be (false)
+  }
+
+  test("completePromotion catch-all fires InvalidMoveEvent for unexpected MoveResult") {
+    // Inject a function that returns an unexpected MoveResult to hit the catch-all case
+    val promotionBoard = FenParser.parseBoard("8/4P3/4k3/8/8/8/8/8").get
+    val stubFn: (de.nowchess.api.board.Board, de.nowchess.chess.logic.GameHistory, Square, Square, PromotionPiece, Color) => de.nowchess.chess.controller.MoveResult =
+      (_, _, _, _, _, _) => de.nowchess.chess.controller.MoveResult.NoPiece
+    val engine = new GameEngine(initialBoard = promotionBoard, completePromotionFn = stubFn)
+    val events = captureEvents(engine)
+
+    engine.processUserInput("e7e8")
+    engine.isPendingPromotion should be (true)
+
+    engine.completePromotion(PromotionPiece.Queen)
+
+    engine.isPendingPromotion should be (false)
+    events.exists(_.isInstanceOf[InvalidMoveEvent]) should be (true)
+  }

modules/core/src/test/scala/de/nowchess/chess/engine/GameEngineTest.scala

@@ -269,10 +269,42 @@ class GameEngineTest extends AnyFunSuite with Matchers:
     engine.processUserInput("q")
     observer.events.size shouldBe initialEvents
   
+  test("GameEngine undo notifies with BoardResetEvent after successful undo"):
+    val engine = new GameEngine()
+    engine.processUserInput("e2e4")
+    engine.processUserInput("e7e5")
+    val observer = new MockObserver()
+    engine.subscribe(observer)
+    observer.events.clear()
+
+    engine.undo()
+
+    // Should have received a BoardResetEvent on undo
+    observer.events.size should be > 0
+    observer.events.exists(_.isInstanceOf[BoardResetEvent]) shouldBe true
+
+  test("GameEngine redo notifies with MoveExecutedEvent after successful redo"):
+    val engine = new GameEngine()
+    engine.processUserInput("e2e4")
+    engine.processUserInput("e7e5")
+    val boardAfterSecondMove = engine.board
+
+    engine.undo()
+    val observer = new MockObserver()
+    engine.subscribe(observer)
+    observer.events.clear()
+
+    engine.redo()
+
+    // Should have received a MoveExecutedEvent for the redo
+    observer.events.size shouldBe 1
+    observer.events.head shouldBe a[MoveExecutedEvent]
+    engine.board shouldBe boardAfterSecondMove
+    engine.turn shouldBe Color.White
+
   // Mock Observer for testing
   private class MockObserver extends Observer:
     val events = mutable.ListBuffer[GameEvent]()
     override def onGameEvent(event: GameEvent): Unit =
       events += event
 
-end GameEngineTest

modules/core/src/test/scala/de/nowchess/chess/engine/MoveCommandDefaultsTest.scala

@@ -0,0 +1,110 @@
+package de.nowchess.chess.command
+
+import de.nowchess.api.board.{Square, File, Rank, Board, Color}
+import de.nowchess.chess.logic.GameHistory
+import org.scalatest.funsuite.AnyFunSuite
+import org.scalatest.matchers.should.Matchers
+
+class MoveCommandDefaultsTest extends AnyFunSuite with Matchers:
+  
+  private def sq(f: File, r: Rank): Square = Square(f, r)
+
+  // Tests for MoveCommand with default parameter values
+  test("MoveCommand with no moveResult defaults to None"):
+    val cmd = MoveCommand(
+      from = sq(File.E, Rank.R2),
+      to = sq(File.E, Rank.R4)
+    )
+    cmd.moveResult shouldBe None
+    cmd.execute() shouldBe false
+
+  test("MoveCommand with no previousBoard defaults to None"):
+    val cmd = MoveCommand(
+      from = sq(File.E, Rank.R2),
+      to = sq(File.E, Rank.R4)
+    )
+    cmd.previousBoard shouldBe None
+    cmd.undo() shouldBe false
+
+  test("MoveCommand with no previousHistory defaults to None"):
+    val cmd = MoveCommand(
+      from = sq(File.E, Rank.R2),
+      to = sq(File.E, Rank.R4)
+    )
+    cmd.previousHistory shouldBe None
+    cmd.undo() shouldBe false
+
+  test("MoveCommand with no previousTurn defaults to None"):
+    val cmd = MoveCommand(
+      from = sq(File.E, Rank.R2),
+      to = sq(File.E, Rank.R4)
+    )
+    cmd.previousTurn shouldBe None
+    cmd.undo() shouldBe false
+
+  test("MoveCommand description is always returned"):
+    val cmd = MoveCommand(
+      from = sq(File.E, Rank.R2),
+      to = sq(File.E, Rank.R4)
+    )
+    cmd.description shouldBe "Move from e2 to e4"
+
+  test("MoveCommand execute returns false when moveResult is None"):
+    val cmd = MoveCommand(
+      from = sq(File.A, Rank.R1),
+      to = sq(File.B, Rank.R3)
+    )
+    cmd.execute() shouldBe false
+
+  test("MoveCommand undo returns false when any previous state is None"):
+    // Missing previousBoard
+    val cmd1 = MoveCommand(
+      from = sq(File.E, Rank.R2),
+      to = sq(File.E, Rank.R4),
+      moveResult = Some(MoveResult.Successful(Board.initial, GameHistory.empty, Color.White, None)),
+      previousBoard = None,
+      previousHistory = Some(GameHistory.empty),
+      previousTurn = Some(Color.White)
+    )
+    cmd1.undo() shouldBe false
+
+    // Missing previousHistory
+    val cmd2 = MoveCommand(
+      from = sq(File.E, Rank.R2),
+      to = sq(File.E, Rank.R4),
+      moveResult = Some(MoveResult.Successful(Board.initial, GameHistory.empty, Color.White, None)),
+      previousBoard = Some(Board.initial),
+      previousHistory = None,
+      previousTurn = Some(Color.White)
+    )
+    cmd2.undo() shouldBe false
+
+    // Missing previousTurn
+    val cmd3 = MoveCommand(
+      from = sq(File.E, Rank.R2),
+      to = sq(File.E, Rank.R4),
+      moveResult = Some(MoveResult.Successful(Board.initial, GameHistory.empty, Color.White, None)),
+      previousBoard = Some(Board.initial),
+      previousHistory = Some(GameHistory.empty),
+      previousTurn = None
+    )
+    cmd3.undo() shouldBe false
+
+  test("MoveCommand execute returns true when moveResult is defined"):
+    val cmd = MoveCommand(
+      from = sq(File.E, Rank.R2),
+      to = sq(File.E, Rank.R4),
+      moveResult = Some(MoveResult.Successful(Board.initial, GameHistory.empty, Color.White, None))
+    )
+    cmd.execute() shouldBe true
+
+  test("MoveCommand undo returns true when all previous states are defined"):
+    val cmd = MoveCommand(
+      from = sq(File.E, Rank.R2),
+      to = sq(File.E, Rank.R4),
+      moveResult = Some(MoveResult.Successful(Board.initial, GameHistory.empty, Color.White, None)),
+      previousBoard = Some(Board.initial),
+      previousHistory = Some(GameHistory.empty),
+      previousTurn = Some(Color.White)
+    )
+    cmd.undo() shouldBe true

modules/core/src/test/scala/de/nowchess/chess/logic/GameHistoryTest.scala

@@ -1,6 +1,7 @@
 package de.nowchess.chess.logic
 
 import de.nowchess.api.board.*
+import de.nowchess.api.move.PromotionPiece
 import org.scalatest.funsuite.AnyFunSuite
 import org.scalatest.matchers.should.Matchers
 
@@ -39,3 +40,32 @@ class GameHistoryTest extends AnyFunSuite with Matchers:
     val history = GameHistory.empty.addMove(sq(File.E, Rank.R2), sq(File.E, Rank.R4))
     history.moves should have length 1
     history.moves.head.castleSide shouldBe None
+
+  test("Move with promotion records the promotion piece"):
+    val move = HistoryMove(sq(File.E, Rank.R7), sq(File.E, Rank.R8), None, Some(PromotionPiece.Queen))
+    move.promotionPiece should be (Some(PromotionPiece.Queen))
+
+  test("Normal move has no promotion piece"):
+    val move = HistoryMove(sq(File.E, Rank.R2), sq(File.E, Rank.R4), None, None)
+    move.promotionPiece should be (None)
+
+  test("addMove with promotion stores promotionPiece"):
+    val history = GameHistory.empty
+    val newHistory = history.addMove(sq(File.E, Rank.R7), sq(File.E, Rank.R8), None, Some(PromotionPiece.Rook))
+    newHistory.moves should have length 1
+    newHistory.moves.head.promotionPiece should be (Some(PromotionPiece.Rook))
+
+  test("addMove with castleSide only uses promotionPiece default (None)"):
+    val history = GameHistory.empty
+    // With overload 3 removed, this uses the 4-param version and triggers addMove$default$4
+    val newHistory = history.addMove(sq(File.E, Rank.R1), sq(File.G, Rank.R1), Some(CastleSide.Kingside))
+    newHistory.moves should have length 1
+    newHistory.moves.head.castleSide should be (Some(CastleSide.Kingside))
+    newHistory.moves.head.promotionPiece should be (None)
+
+  test("addMove using named parameters with only promotion, using castleSide default"):
+    val history = GameHistory.empty
+    val newHistory = history.addMove(from = sq(File.E, Rank.R7), to = sq(File.E, Rank.R8), promotionPiece = Some(PromotionPiece.Queen))
+    newHistory.moves should have length 1
+    newHistory.moves.head.castleSide should be (None)
+    newHistory.moves.head.promotionPiece should be (Some(PromotionPiece.Queen))

modules/core/src/test/scala/de/nowchess/chess/logic/MoveValidatorTest.scala

@@ -3,6 +3,7 @@ package de.nowchess.chess.logic
 import de.nowchess.api.board.{Board, Color, File, Piece, Rank, Square}
 import de.nowchess.api.game.CastlingRights
 import de.nowchess.chess.logic.{CastleSide, GameHistory}
+import de.nowchess.chess.notation.FenParser
 import org.scalatest.funsuite.AnyFunSuite
 import org.scalatest.matchers.should.Matchers
 
@@ -255,3 +256,25 @@ class MoveValidatorTest extends AnyFunSuite with Matchers:
     val b = board(sq(File.D, Rank.R4) -> Piece.WhiteRook)
     val h = GameHistory.empty.addMove(sq(File.E, Rank.R2), sq(File.E, Rank.R4))
     MoveValidator.legalTargets(b, h, sq(File.D, Rank.R4)) shouldBe MoveValidator.legalTargets(b, sq(File.D, Rank.R4))
+
+  // ──── isPromotionMove ────────────────────────────────────────────────
+
+  test("White pawn reaching R8 is a promotion move"):
+    val b = FenParser.parseBoard("8/4P3/4k3/8/8/8/8/8").get
+    MoveValidator.isPromotionMove(b, Square(File.E, Rank.R7), Square(File.E, Rank.R8)) should be (true)
+
+  test("Black pawn reaching R1 is a promotion move"):
+    val b = FenParser.parseBoard("8/8/8/8/4K3/8/4p3/8").get
+    MoveValidator.isPromotionMove(b, Square(File.E, Rank.R2), Square(File.E, Rank.R1)) should be (true)
+
+  test("Pawn capturing to back rank is a promotion move"):
+    val b = FenParser.parseBoard("3q4/4P3/8/8/8/8/8/8").get
+    MoveValidator.isPromotionMove(b, Square(File.E, Rank.R7), Square(File.D, Rank.R8)) should be (true)
+
+  test("Pawn not reaching back rank is not a promotion move"):
+    val b = FenParser.parseBoard("8/8/8/4P3/8/8/8/8").get
+    MoveValidator.isPromotionMove(b, Square(File.E, Rank.R5), Square(File.E, Rank.R6)) should be (false)
+
+  test("Non-pawn piece is never a promotion move"):
+    val b = FenParser.parseBoard("8/8/8/4Q3/8/8/8/8").get
+    MoveValidator.isPromotionMove(b, Square(File.E, Rank.R5), Square(File.E, Rank.R8)) should be (false)

modules/core/src/test/scala/de/nowchess/chess/notation/PgnExporterTest.scala

@@ -1,6 +1,7 @@
 package de.nowchess.chess.notation
 
 import de.nowchess.api.board.*
+import de.nowchess.api.move.PromotionPiece
 import de.nowchess.chess.logic.{GameHistory, HistoryMove, CastleSide}
 import org.scalatest.funsuite.AnyFunSuite
 import org.scalatest.matchers.should.Matchers
@@ -63,3 +64,39 @@ class PgnExporterTest extends AnyFunSuite with Matchers:
 
     pgn.contains("O-O-O") shouldBe true
   }
+
+  test("exportGame encodes promotion to Queen as =Q suffix") {
+    val history = GameHistory()
+      .addMove(HistoryMove(Square(File.E, Rank.R7), Square(File.E, Rank.R8), None, Some(PromotionPiece.Queen)))
+    val pgn = PgnExporter.exportGame(Map.empty, history)
+    pgn should include ("e7e8=Q")
+  }
+
+  test("exportGame encodes promotion to Rook as =R suffix") {
+    val history = GameHistory()
+      .addMove(HistoryMove(Square(File.E, Rank.R7), Square(File.E, Rank.R8), None, Some(PromotionPiece.Rook)))
+    val pgn = PgnExporter.exportGame(Map.empty, history)
+    pgn should include ("e7e8=R")
+  }
+
+  test("exportGame encodes promotion to Bishop as =B suffix") {
+    val history = GameHistory()
+      .addMove(HistoryMove(Square(File.E, Rank.R7), Square(File.E, Rank.R8), None, Some(PromotionPiece.Bishop)))
+    val pgn = PgnExporter.exportGame(Map.empty, history)
+    pgn should include ("e7e8=B")
+  }
+
+  test("exportGame encodes promotion to Knight as =N suffix") {
+    val history = GameHistory()
+      .addMove(HistoryMove(Square(File.E, Rank.R7), Square(File.E, Rank.R8), None, Some(PromotionPiece.Knight)))
+    val pgn = PgnExporter.exportGame(Map.empty, history)
+    pgn should include ("e7e8=N")
+  }
+
+  test("exportGame does not add suffix for normal moves") {
+    val history = GameHistory()
+      .addMove(HistoryMove(Square(File.E, Rank.R2), Square(File.E, Rank.R4), None, None))
+    val pgn = PgnExporter.exportGame(Map.empty, history)
+    pgn should include ("e2e4")
+    pgn should not include ("=")
+  }

modules/core/src/test/scala/de/nowchess/chess/notation/PgnParserTest.scala

@@ -1,7 +1,9 @@
 package de.nowchess.chess.notation
 
 import de.nowchess.api.board.*
+import de.nowchess.api.move.PromotionPiece
 import de.nowchess.chess.logic.{GameHistory, HistoryMove, CastleSide}
+import de.nowchess.chess.notation.FenParser
 import org.scalatest.funsuite.AnyFunSuite
 import org.scalatest.matchers.should.Matchers
 
@@ -332,3 +334,118 @@ class PgnParserTest extends AnyFunSuite with Matchers:
     result.isDefined shouldBe true
     result.get.to shouldBe Square(File.D, Rank.R1)
   }
+
+  test("parseAlgebraicMove preserves promotion to Queen in HistoryMove") {
+    val board = FenParser.parseBoard("8/4P3/4k3/8/8/8/8/8").get
+    val result = PgnParser.parseAlgebraicMove("e7e8=Q", board, GameHistory.empty, Color.White)
+    result.isDefined should be (true)
+    result.get.promotionPiece should be (Some(PromotionPiece.Queen))
+    result.get.to should be (Square(File.E, Rank.R8))
+  }
+
+  test("parseAlgebraicMove preserves promotion to Rook") {
+    val board = FenParser.parseBoard("8/4P3/4k3/8/8/8/8/8").get
+    val result = PgnParser.parseAlgebraicMove("e7e8=R", board, GameHistory.empty, Color.White)
+    result.get.promotionPiece should be (Some(PromotionPiece.Rook))
+  }
+
+  test("parseAlgebraicMove preserves promotion to Bishop") {
+    val board = FenParser.parseBoard("8/4P3/4k3/8/8/8/8/8").get
+    val result = PgnParser.parseAlgebraicMove("e7e8=B", board, GameHistory.empty, Color.White)
+    result.get.promotionPiece should be (Some(PromotionPiece.Bishop))
+  }
+
+  test("parseAlgebraicMove preserves promotion to Knight") {
+    val board = FenParser.parseBoard("8/4P3/4k3/8/8/8/8/8").get
+    val result = PgnParser.parseAlgebraicMove("e7e8=N", board, GameHistory.empty, Color.White)
+    result.get.promotionPiece should be (Some(PromotionPiece.Knight))
+  }
+
+  test("parsePgn applies promoted piece to board for subsequent moves") {
+    // Build a board with a white pawn on e7 plus the two kings
+    import de.nowchess.api.board.{Board, Square, File, Rank, Piece, Color, PieceType}
+    val pieces: Map[Square, Piece] = Map(
+      Square(File.E, Rank.R7) -> Piece(Color.White, PieceType.Pawn),
+      Square(File.E, Rank.R1) -> Piece(Color.White, PieceType.King),
+      Square(File.H, Rank.R1) -> Piece(Color.Black, PieceType.King)
+    )
+    val board = Board(pieces)
+    val move = PgnParser.parseAlgebraicMove("e7e8=Q", board, GameHistory.empty, Color.White)
+    move.isDefined should be (true)
+    move.get.promotionPiece should be (Some(PromotionPiece.Queen))
+    // After applying the promotion the square e8 should hold a White Queen
+    val (boardAfterPawnMove, _) = board.withMove(move.get.from, move.get.to)
+    val promotedBoard = boardAfterPawnMove.updated(move.get.to, Piece(Color.White, PieceType.Queen))
+    promotedBoard.pieceAt(Square(File.E, Rank.R8)) should be (Some(Piece(Color.White, PieceType.Queen)))
+  }
+
+  test("parsePgn with all four promotion piece types (Queen, Rook, Bishop, Knight) in sequence") {
+    // This test exercises lines 53-58 in PgnParser.parseMovesText which contain
+    // the pattern match over PromotionPiece for Queen, Rook, Bishop, Knight
+    val pgn = """[Event "Promotion Test"]
+[White "A"]
+[Black "B"]
+
+1. a2a3 h7h5 2. a3a4 h5h4 3. a4a5 h4h3 4. a5a6 h3h2 5. a6a7 h2h1=Q 6. a7a8=R 1-0
+"""
+    val game = PgnParser.parsePgn(pgn)
+
+    game.isDefined shouldBe true
+    // Move 10 is h2h1=Q (black pawn promotes to queen)
+    val blackPromotionToQ = game.get.moves(9)  // 0-indexed
+    blackPromotionToQ.promotionPiece shouldBe Some(PromotionPiece.Queen)
+
+    // Move 11 is a7a8=R (white pawn promotes to rook)
+    val whitePromotionToR = game.get.moves(10)
+    whitePromotionToR.promotionPiece shouldBe Some(PromotionPiece.Rook)
+  }
+
+  test("parseAlgebraicMove promotion with Rook through full PGN parse") {
+    val pgn = """[Event "Test"]
+[White "A"]
+[Black "B"]
+
+1. a2a3 h7h6 2. a3a4 h6h5 3. a4a5 h5h4 4. a5a6 h4h3 5. a6a7 h3h2 6. a7a8=R
+"""
+    val game = PgnParser.parsePgn(pgn)
+    game.isDefined shouldBe true
+    val lastMove = game.get.moves.last
+    lastMove.promotionPiece shouldBe Some(PromotionPiece.Rook)
+  }
+
+  test("parseAlgebraicMove promotion with Bishop through full PGN parse") {
+    val pgn = """[Event "Test"]
+[White "A"]
+[Black "B"]
+
+1. b2b3 h7h6 2. b3b4 h6h5 3. b4b5 h5h4 4. b5b6 h4h3 5. b6b7 h3h2 6. b7b8=B
+"""
+    val game = PgnParser.parsePgn(pgn)
+    game.isDefined shouldBe true
+    val lastMove = game.get.moves.last
+    lastMove.promotionPiece shouldBe Some(PromotionPiece.Bishop)
+  }
+
+  test("parseAlgebraicMove promotion with Knight through full PGN parse") {
+    val pgn = """[Event "Test"]
+[White "A"]
+[Black "B"]
+
+1. c2c3 h7h6 2. c3c4 h6h5 3. c4c5 h5h4 4. c5c6 h4h3 5. c6c7 h3h2 6. c7c8=N
+"""
+    val game = PgnParser.parsePgn(pgn)
+    game.isDefined shouldBe true
+    val lastMove = game.get.moves.last
+    lastMove.promotionPiece shouldBe Some(PromotionPiece.Knight)
+  }
+
+  test("extractPromotion returns None for invalid promotion letter") {
+    // Regex =([A-Z]) now captures any uppercase letter, so =X is matched but case _ => None fires
+    val result = PgnParser.extractPromotion("e7e8=X")
+    result shouldBe None
+  }
+
+  test("extractPromotion returns None when no promotion in notation") {
+    val result = PgnParser.extractPromotion("e7e8")
+    result shouldBe None
+  }

modules/core/src/test/scala/de/nowchess/chess/observer/ObservableThreadSafetyTest.scala

@@ -0,0 +1,168 @@
+package de.nowchess.chess.observer
+
+import de.nowchess.api.board.{Board, Color}
+import de.nowchess.chess.logic.GameHistory
+import org.scalatest.funsuite.AnyFunSuite
+import org.scalatest.matchers.should.Matchers
+import scala.collection.mutable
+
+class ObservableThreadSafetyTest extends AnyFunSuite with Matchers:
+
+  private class TestObservable extends Observable:
+    def testNotifyObservers(event: GameEvent): Unit =
+      notifyObservers(event)
+
+  private class CountingObserver extends Observer:
+    @volatile private var eventCount = 0
+    @volatile private var lastEvent: Option[GameEvent] = None
+
+    def onGameEvent(event: GameEvent): Unit =
+      eventCount += 1
+      lastEvent = Some(event)
+
+  private def createTestEvent(): GameEvent =
+    BoardResetEvent(
+      board = Board.initial,
+      history = GameHistory.empty,
+      turn = Color.White
+    )
+
+  test("Observable is thread-safe for concurrent subscribe and notify"):
+    val observable = new TestObservable()
+    val testEvent = createTestEvent()
+    @volatile var raceConditionCaught = false
+
+    // Thread 1: repeatedly notifies observers with long iteration
+    val notifierThread = new Thread(new Runnable {
+      def run(): Unit = {
+        try {
+          for _ <- 1 to 500000 do
+            observable.testNotifyObservers(testEvent)
+        } catch {
+          case _: java.util.ConcurrentModificationException =>
+            raceConditionCaught = true
+        }
+      }
+    })
+
+    // Thread 2: rapidly subscribes/unsubscribes observers during notify
+    val subscriberThread = new Thread(new Runnable {
+      def run(): Unit = {
+        try {
+          for _ <- 1 to 500000 do
+            val obs = new CountingObserver()
+            observable.subscribe(obs)
+            observable.unsubscribe(obs)
+        } catch {
+          case _: java.util.ConcurrentModificationException =>
+            raceConditionCaught = true
+        }
+      }
+    })
+
+    notifierThread.start()
+    subscriberThread.start()
+    notifierThread.join()
+    subscriberThread.join()
+
+    raceConditionCaught shouldBe false
+
+  test("Observable is thread-safe for concurrent subscribe, unsubscribe, and notify"):
+    val observable = new TestObservable()
+    val testEvent = createTestEvent()
+    val exceptions = mutable.ListBuffer[Exception]()
+    val observers = mutable.ListBuffer[CountingObserver]()
+
+    // Pre-subscribe some observers
+    for _ <- 1 to 10 do
+      val obs = new CountingObserver()
+      observers += obs
+      observable.subscribe(obs)
+
+    // Thread 1: notifies observers
+    val notifierThread = new Thread(new Runnable {
+      def run(): Unit = {
+        try {
+          for _ <- 1 to 5000 do
+            observable.testNotifyObservers(testEvent)
+        } catch {
+          case e: Exception => exceptions += e
+        }
+      }
+    })
+
+    // Thread 2: subscribes new observers
+    val subscriberThread = new Thread(new Runnable {
+      def run(): Unit = {
+        try {
+          for _ <- 1 to 5000 do
+            val obs = new CountingObserver()
+            observable.subscribe(obs)
+        } catch {
+          case e: Exception => exceptions += e
+        }
+      }
+    })
+
+    // Thread 3: unsubscribes observers
+    val unsubscriberThread = new Thread(new Runnable {
+      def run(): Unit = {
+        try {
+          for i <- 1 to 5000 do
+            if observers.nonEmpty then
+              val obs = observers(i % observers.size)
+              observable.unsubscribe(obs)
+        } catch {
+          case e: Exception => exceptions += e
+        }
+      }
+    })
+
+    notifierThread.start()
+    subscriberThread.start()
+    unsubscriberThread.start()
+    notifierThread.join()
+    subscriberThread.join()
+    unsubscriberThread.join()
+
+    exceptions.isEmpty shouldBe true
+
+  test("Observable.observerCount is thread-safe during concurrent modifications"):
+    val observable = new TestObservable()
+    val exceptions = mutable.ListBuffer[Exception]()
+    val countResults = mutable.ListBuffer[Int]()
+
+    // Thread 1: subscribes observers
+    val subscriberThread = new Thread(new Runnable {
+      def run(): Unit = {
+        try {
+          for _ <- 1 to 500 do
+            observable.subscribe(new CountingObserver())
+        } catch {
+          case e: Exception => exceptions += e
+        }
+      }
+    })
+
+    // Thread 2: reads observer count
+    val readerThread = new Thread(new Runnable {
+      def run(): Unit = {
+        try {
+          for _ <- 1 to 500 do
+            val count = observable.observerCount
+            countResults += count
+        } catch {
+          case e: Exception => exceptions += e
+        }
+      }
+    })
+
+    subscriberThread.start()
+    readerThread.start()
+    subscriberThread.join()
+    readerThread.join()
+
+    exceptions.isEmpty shouldBe true
+    // Count should never go backwards
+    for i <- 1 until countResults.size do
+      countResults(i) >= countResults(i - 1) shouldBe true

modules/core/versions.env

@@ -1,3 +1,3 @@
 MAJOR=0
-MINOR=3
+MINOR=5
 PATCH=0

modules/ui/src/main/scala/de/nowchess/ui/Main.scala

@@ -13,4 +13,3 @@ object Main:
     val tui = new TerminalUI(engine)
     tui.start()
 
-end Main

modules/ui/src/main/scala/de/nowchess/ui/terminal/TerminalUI.scala

@@ -1,6 +1,7 @@
 package de.nowchess.ui.terminal
 
 import scala.io.StdIn
+import de.nowchess.api.move.PromotionPiece
 import de.nowchess.chess.engine.GameEngine
 import de.nowchess.chess.observer.{Observer, GameEvent, *}
 import de.nowchess.chess.view.Renderer
@@ -11,6 +12,7 @@ import de.nowchess.chess.view.Renderer
  */
 class TerminalUI(engine: GameEngine) extends Observer:
   private var running = true
+  private var awaitingPromotion = false
 
   /** Called by GameEngine whenever a game event occurs. */
   override def onGameEvent(event: GameEvent): Unit =
@@ -44,6 +46,10 @@ class TerminalUI(engine: GameEngine) extends Observer:
         print(Renderer.render(e.board))
         printPrompt(e.turn)
 
+      case _: PromotionRequiredEvent =>
+        println("Promote to: q=Queen, r=Rook, b=Bishop, n=Knight")
+        synchronized { awaitingPromotion = true }
+
   /** Start the terminal UI game loop. */
   def start(): Unit =
     // Register as observer
@@ -57,6 +63,17 @@ class TerminalUI(engine: GameEngine) extends Observer:
     // Game loop
     while running do
       val input = Option(StdIn.readLine()).getOrElse("quit").trim
+      synchronized {
+        if awaitingPromotion then
+          input.toLowerCase match
+            case "q" => awaitingPromotion = false; engine.completePromotion(PromotionPiece.Queen)
+            case "r" => awaitingPromotion = false; engine.completePromotion(PromotionPiece.Rook)
+            case "b" => awaitingPromotion = false; engine.completePromotion(PromotionPiece.Bishop)
+            case "n" => awaitingPromotion = false; engine.completePromotion(PromotionPiece.Knight)
+            case _ =>
+              println("Invalid choice. Enter q, r, b, or n.")
+              println("Promote to: q=Queen, r=Rook, b=Bishop, n=Knight")
+        else
           input.toLowerCase match
             case "quit" | "q" =>
               running = false
@@ -65,6 +82,7 @@ class TerminalUI(engine: GameEngine) extends Observer:
               printPrompt(engine.turn)
             case _ =>
               engine.processUserInput(input)
+      }
 
     // Unsubscribe when done
     engine.unsubscribe(this)
@@ -73,5 +91,3 @@ class TerminalUI(engine: GameEngine) extends Observer:
     val undoHint = if engine.canUndo then " [undo]" else ""
     val redoHint = if engine.canRedo then " [redo]" else ""
     print(s"${turn.label}'s turn. Enter move (or 'quit'/'q' to exit)$undoHint$redoHint: ")
-
-end TerminalUI

modules/ui/src/test/scala/de/nowchess/ui/MainTest.scala

@@ -0,0 +1,22 @@
+package de.nowchess.ui
+
+import org.scalatest.funsuite.AnyFunSuite
+import org.scalatest.matchers.should.Matchers
+import java.io.{ByteArrayInputStream, ByteArrayOutputStream}
+
+class MainTest extends AnyFunSuite with Matchers {
+
+  test("main should execute and quit immediately when fed 'quit'") {
+    val in = new ByteArrayInputStream("quit\n".getBytes)
+    val out = new ByteArrayOutputStream()
+
+    Console.withIn(in) {
+      Console.withOut(out) {
+        Main.main(Array.empty)
+      }
+    }
+    
+    val output = out.toString
+    output should include ("Game over. Goodbye!")
+  }
+}

modules/ui/src/test/scala/de/nowchess/ui/terminal/TerminalUITest.scala

@@ -0,0 +1,327 @@
+package de.nowchess.ui.terminal
+
+import org.scalatest.funsuite.AnyFunSuite
+import org.scalatest.matchers.should.Matchers
+import java.io.{ByteArrayInputStream, ByteArrayOutputStream}
+import de.nowchess.chess.engine.GameEngine
+import de.nowchess.chess.observer.*
+import de.nowchess.api.board.{Board, Color, File, Rank, Square}
+import de.nowchess.chess.logic.GameHistory
+
+class TerminalUITest extends AnyFunSuite with Matchers {
+
+  test("TerminalUI should start, print initial state, and correctly respond to 'q'") {
+    val in = new ByteArrayInputStream("q\n".getBytes)
+    val out = new ByteArrayOutputStream()
+
+    val engine = new GameEngine()
+    val ui = new TerminalUI(engine)
+
+    Console.withIn(in) {
+      Console.withOut(out) {
+        ui.start()
+      }
+    }
+
+    val output = out.toString
+    output should include("White's turn.")
+    output should include("Game over. Goodbye!")
+  }
+
+  test("TerminalUI should ignore empty inputs and re-print prompt") {
+    val in = new ByteArrayInputStream("\nq\n".getBytes)
+    val out = new ByteArrayOutputStream()
+
+    val engine = new GameEngine()
+    val ui = new TerminalUI(engine)
+
+    Console.withIn(in) {
+      Console.withOut(out) {
+        ui.start()
+      }
+    }
+
+    val output = out.toString
+    // Prompt appears three times: Initial, after empty, on exit.
+    output.split("White's turn.").length should be > 2
+  }
+
+  test("TerminalUI should explicitly handle empty input by re-prompting") {
+    val in = new ByteArrayInputStream("\n\nq\n".getBytes)
+    val out = new ByteArrayOutputStream()
+
+    val engine = new GameEngine()
+    val ui = new TerminalUI(engine)
+
+    Console.withIn(in) {
+      Console.withOut(out) {
+        ui.start()
+      }
+    }
+
+    val output = out.toString
+    // With two empty inputs, prompt should appear at least 4 times:
+    // 1. Initial board display
+    // 2. After first empty input
+    // 3. After second empty input
+    // 4. Before quit
+    val promptCount = output.split("White's turn.").length
+    promptCount should be >= 4
+    output should include("Game over. Goodbye!")
+  }
+
+  test("TerminalUI printPrompt should include undo and redo hints if engine returns true") {
+    val in = new ByteArrayInputStream("\nq\n".getBytes)
+    val out = new ByteArrayOutputStream()
+
+    val engine = new GameEngine() {
+      // Stub engine to force undo/redo to true
+      override def canUndo: Boolean = true
+      override def canRedo: Boolean = true
+    }
+    
+    val ui = new TerminalUI(engine)
+
+    Console.withIn(in) {
+      Console.withOut(out) {
+        ui.start()
+      }
+    }
+
+    val output = out.toString
+    output should include("[undo]")
+    output should include("[redo]")
+  }
+
+  test("TerminalUI onGameEvent should properly format InvalidMoveEvent") {
+    val out = new ByteArrayOutputStream()
+    val engine = new GameEngine()
+    val ui = new TerminalUI(engine)
+
+    Console.withOut(out) {
+      ui.onGameEvent(InvalidMoveEvent(Board(Map.empty), GameHistory(), Color.Black, "Invalid move format"))
+    }
+
+    out.toString should include("⚠️")
+    out.toString should include("Invalid move format")
+  }
+
+  test("TerminalUI onGameEvent should properly format CheckDetectedEvent") {
+    val out = new ByteArrayOutputStream()
+    val engine = new GameEngine()
+    val ui = new TerminalUI(engine)
+
+    Console.withOut(out) {
+      ui.onGameEvent(CheckDetectedEvent(Board(Map.empty), GameHistory(), Color.Black))
+    }
+
+    out.toString should include("Black is in check!")
+  }
+
+  test("TerminalUI onGameEvent should properly format CheckmateEvent") {
+    val out = new ByteArrayOutputStream()
+    val engine = new GameEngine()
+    val ui = new TerminalUI(engine)
+
+    Console.withOut(out) {
+      ui.onGameEvent(CheckmateEvent(Board(Map.empty), GameHistory(), Color.Black, Color.White))
+    }
+
+    val ostr = out.toString
+    ostr should include("Checkmate! White wins.")
+  }
+
+  test("TerminalUI onGameEvent should properly format StalemateEvent") {
+    val out = new ByteArrayOutputStream()
+    val engine = new GameEngine()
+    val ui = new TerminalUI(engine)
+
+    Console.withOut(out) {
+      ui.onGameEvent(StalemateEvent(Board(Map.empty), GameHistory(), Color.Black))
+    }
+
+    out.toString should include("Stalemate! The game is a draw.")
+  }
+
+  test("TerminalUI onGameEvent should properly format BoardResetEvent") {
+    val out = new ByteArrayOutputStream()
+    val engine = new GameEngine()
+    val ui = new TerminalUI(engine)
+
+    Console.withOut(out) {
+      ui.onGameEvent(BoardResetEvent(Board(Map.empty), GameHistory(), Color.White))
+    }
+
+    out.toString should include("Board has been reset to initial position.")
+  }
+
+  test("TerminalUI onGameEvent should properly format MoveExecutedEvent with capturing piece") {
+    val out = new ByteArrayOutputStream()
+    val engine = new GameEngine()
+    val ui = new TerminalUI(engine)
+
+    Console.withOut(out) {
+      ui.onGameEvent(MoveExecutedEvent(Board(Map.empty), GameHistory(), Color.Black, "A1", "A8", Some("Knight(White)")))
+    }
+
+    out.toString should include("Captured: Knight(White) on A8") // Depending on how piece/coord serialize
+  }
+
+  test("TerminalUI processes valid move input via processUserInput") {
+    val in = new ByteArrayInputStream("e2e4\nq\n".getBytes)
+    val out = new ByteArrayOutputStream()
+
+    val engine = new GameEngine()
+    val ui = new TerminalUI(engine)
+
+    Console.withIn(in) {
+      Console.withOut(out) {
+        ui.start()
+      }
+    }
+
+    val output = out.toString
+    output should include("White's turn.")
+    output should include("Game over. Goodbye!")
+    // The move should have been processed and the board displayed
+    engine.turn shouldBe Color.Black
+  }
+
+  test("TerminalUI shows promotion prompt on PromotionRequiredEvent") {
+    val out = new ByteArrayOutputStream()
+    val engine = new GameEngine()
+    val ui = new TerminalUI(engine)
+
+    Console.withOut(out) {
+      ui.onGameEvent(PromotionRequiredEvent(
+        Board(Map.empty), GameHistory(), Color.White,
+        Square(File.E, Rank.R7), Square(File.E, Rank.R8)
+      ))
+    }
+
+    out.toString should include("Promote to")
+  }
+
+  test("TerminalUI routes promotion choice to engine.completePromotion") {
+    import de.nowchess.api.move.PromotionPiece
+
+    var capturedPiece: Option[PromotionPiece] = None
+
+    val engine = new GameEngine() {
+      override def processUserInput(rawInput: String): Unit =
+        if rawInput.trim == "e7e8" then
+          notifyObservers(PromotionRequiredEvent(
+            Board(Map.empty), GameHistory.empty, Color.White,
+            Square(File.E, Rank.R7), Square(File.E, Rank.R8)
+          ))
+      override def completePromotion(piece: PromotionPiece): Unit =
+        capturedPiece = Some(piece)
+        notifyObservers(MoveExecutedEvent(Board(Map.empty), GameHistory.empty, Color.Black, "e7", "e8", None))
+    }
+
+    val in = new ByteArrayInputStream("e7e8\nq\nquit\n".getBytes)
+    val out = new ByteArrayOutputStream()
+    val ui = new TerminalUI(engine)
+
+    Console.withIn(in) {
+      Console.withOut(out) {
+        ui.start()
+      }
+    }
+
+    capturedPiece should be(Some(PromotionPiece.Queen))
+    out.toString should include("Promote to")
+  }
+
+  test("TerminalUI re-prompts on invalid promotion choice") {
+    import de.nowchess.api.move.PromotionPiece
+
+    var capturedPiece: Option[PromotionPiece] = None
+
+    val engine = new GameEngine() {
+      override def processUserInput(rawInput: String): Unit =
+        if rawInput.trim == "e7e8" then
+          notifyObservers(PromotionRequiredEvent(
+            Board(Map.empty), GameHistory.empty, Color.White,
+            Square(File.E, Rank.R7), Square(File.E, Rank.R8)
+          ))
+      override def completePromotion(piece: PromotionPiece): Unit =
+        capturedPiece = Some(piece)
+        notifyObservers(MoveExecutedEvent(Board(Map.empty), GameHistory.empty, Color.Black, "e7", "e8", None))
+    }
+
+    // "x" is invalid, then "r" for rook
+    val in = new ByteArrayInputStream("e7e8\nx\nr\nquit\n".getBytes)
+    val out = new ByteArrayOutputStream()
+    val ui = new TerminalUI(engine)
+
+    Console.withIn(in) {
+      Console.withOut(out) {
+        ui.start()
+      }
+    }
+
+    capturedPiece should be(Some(PromotionPiece.Rook))
+    out.toString should include("Invalid")
+  }
+
+  test("TerminalUI routes Bishop promotion choice to engine.completePromotion") {
+    import de.nowchess.api.move.PromotionPiece
+
+    var capturedPiece: Option[PromotionPiece] = None
+
+    val engine = new GameEngine() {
+      override def processUserInput(rawInput: String): Unit =
+        if rawInput.trim == "e7e8" then
+          notifyObservers(PromotionRequiredEvent(
+            Board(Map.empty), GameHistory.empty, Color.White,
+            Square(File.E, Rank.R7), Square(File.E, Rank.R8)
+          ))
+      override def completePromotion(piece: PromotionPiece): Unit =
+        capturedPiece = Some(piece)
+        notifyObservers(MoveExecutedEvent(Board(Map.empty), GameHistory.empty, Color.Black, "e7", "e8", None))
+    }
+
+    val in = new ByteArrayInputStream("e7e8\nb\nquit\n".getBytes)
+    val out = new ByteArrayOutputStream()
+    val ui = new TerminalUI(engine)
+
+    Console.withIn(in) {
+      Console.withOut(out) {
+        ui.start()
+      }
+    }
+
+    capturedPiece should be(Some(PromotionPiece.Bishop))
+  }
+
+  test("TerminalUI routes Knight promotion choice to engine.completePromotion") {
+    import de.nowchess.api.move.PromotionPiece
+
+    var capturedPiece: Option[PromotionPiece] = None
+
+    val engine = new GameEngine() {
+      override def processUserInput(rawInput: String): Unit =
+        if rawInput.trim == "e7e8" then
+          notifyObservers(PromotionRequiredEvent(
+            Board(Map.empty), GameHistory.empty, Color.White,
+            Square(File.E, Rank.R7), Square(File.E, Rank.R8)
+          ))
+      override def completePromotion(piece: PromotionPiece): Unit =
+        capturedPiece = Some(piece)
+        notifyObservers(MoveExecutedEvent(Board(Map.empty), GameHistory.empty, Color.Black, "e7", "e8", None))
+    }
+
+    val in = new ByteArrayInputStream("e7e8\nn\nquit\n".getBytes)
+    val out = new ByteArrayOutputStream()
+    val ui = new TerminalUI(engine)
+
+    Console.withIn(in) {
+      Console.withOut(out) {
+        ui.start()
+      }
+    }
+
+    capturedPiece should be(Some(PromotionPiece.Knight))
+  }
+}