KnockOutWhist/KnockOutWhist-Web
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 32 Wiki Activity

feat(ui): added js routing, updated ingame ui, added tricktable #50

Merged
lq64 merged 5 commits from Game-playable-without-forms-or-buttons-#41 into main 2025-11-12 11:44:21 +01:00
Conversation 2 Commits 5 Files Changed 12 +473 -160
lq64 commented 2025-11-11 16:50:58 +01:00
Owner
Copy Link

This merge request has full JS routing for calling specific endpoints. Game is fully playable but doesn't have polling yet. This version already has the UI changes adressed in MR #43 so first merge MR #43 and then this one or only merge this one because it already has the UI changes :)

This merge request has full JS routing for calling specific endpoints. Game is fully playable but doesn't have polling yet. This version already has the UI changes adressed in MR #43 so first merge MR #43 and then this one or only merge this one because it already has the UI changes :)
lq64 added 5 commits 2025-11-11 16:50:58 +01:00
feat(ui): changed Background color, centered Lobby a71752df2f 
Added a background color for the mainmenu and the lobby + centered lobby
feat(ui): Tricktable c948e5e800 
Added a trick-table displaying the players with their won tricks sorted by the person with the most tricks
feat(ui): Ingame layout 33989efedc 
Added a horizontal end for the container to not stretch endlessly to the sides. Covered sides with lobby background and adjusted the blur behind the cards to match the playing area.
feat(ui): added js routing for create game b508d2f428 
added js routing for create game, removed the form and button
feat(ui): added complete js routing for create game 6d958cdd9e 
added complete js routing for each button. Removed every form and replaced buttons with divs
Janis requested changes 2025-11-12 09:20:04 +01:00
Dismissed
Janis left a comment
Owner
Copy Link

Code looks good. The name of the MR doesn't follow conventional commits.

Code looks good. The name of the MR doesn't follow conventional commits.
lq64 changed title from Game-playable-without-forms-or-buttons-#41 to feat(ui): added js routing, updated ingame ui, added tricktable 2025-11-12 11:43:26 +01:00
Janis approved these changes 2025-11-12 11:43:38 +01:00
lq64 merged commit c220e54bb8 into main 2025-11-12 11:44:21 +01:00
lq64 deleted branch Game-playable-without-forms-or-buttons-#41 2025-11-12 11:44:21 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Janis
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Planning/Needs estimate
Planning/Needs refinement
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Size
L
2
Between 4h and 6h of work
Size
M
3
Between 2h and 4h of work
Size
S
4
Between 1h and 2h of work
Size
XL
1
Between 6h and 12h of work
Size
XS
5
Less than 1h of work
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Tests
Flaky tests
4
Tests
Implemented
3
Tests
In progress
2
Tests
Missing
1
Tests
Not required
Type
Epic
3
Type
Subtask
1
Type
User Story
2
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Janis lq64 svc.teamcity
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KnockOutWhist/KnockOutWhist-Web#50
No description provided.
Delete Branch "Game-playable-without-forms-or-buttons-#41"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?