NowChess/NowChessSystems
4
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

WIP: feat: NCS-4 Currying #11

Closed
lq64 wants to merge 3 commits from feat/NCS-4 into main
pull from: feat/NCS-4
merge into: NowChess:main
Conversation 0 Commits 3 Files Changed 7
+156 -91
lq64 commented 2026-03-31 18:15:12 +02:00
Owner
Copy Link
Copy Source

Summary

  • Curried the 6 public methods of MoveValidator — (board[, history]) is now
    the first parameter group, computation parameters (from, to, color) form the second
  • Curried the 3 public methods of GameRules — same split pattern
  • Updated all call sites: GameRules internals, MoveValidator internals,
    GameController, PgnParser, and both test suites
  • Applied partial application where board is fixed across a loop
    (isInCheck, legalMoves) as a style gain

Test Plan

  • ./gradlew :modules:core:test — all 263 tests green
  • No behaviour changes — pure style refactoring, test suite is the regression guard
## Summary - Curried the 6 public methods of `MoveValidator` — `(board[, history])` is now the first parameter group, computation parameters (`from`, `to`, `color`) form the second - Curried the 3 public methods of `GameRules` — same split pattern - Updated all call sites: `GameRules` internals, `MoveValidator` internals, `GameController`, `PgnParser`, and both test suites - Applied partial application where `board` is fixed across a loop (`isInCheck`, `legalMoves`) as a style gain ## Test Plan - [ ] `./gradlew :modules:core:test` — all 263 tests green - [ ] No behaviour changes — pure style refactoring, test suite is the regression guard
lq64 added 3 commits 2026-03-31 18:15:13 +02:00
docs: add currying public API design spec 87806d516f 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
refactor: NCS-4 curry MoveValidator public API and update all call sites 38936b2e10 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
refactor: NCS-4 curry GameRules public API and update all call sites
Build & Test (NowChessSystems) TeamCity build failed
Details
538705d438 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
lq64 changed title from feat/NCS-4 to feat: NCS-4 Currying 2026-04-01 10:38:13 +02:00
Janis marked the pull request as work in progress 2026-04-01 18:34:56 +02:00
Janis closed this pull request 2026-04-07 08:35:20 +02:00
Some checks are pending
Build & Test (NowChessSystems) TeamCity build failed
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Janis (Janis) lq64 (Leon Hermann) shosho996 (Shahd Lala) svc.teamcity
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NowChess/NowChessSystems#11
Delete Branch "feat/NCS-4"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?