NowChess/NowChessSystems
4
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

refactor: NCS-19 Currying #18

Merged
Janis merged 1 commits from feat/NCS-19 into main 2026-04-06 21:03:17 +02:00
Conversation 1 Commits 1 Files Changed 9
+59 -59
lq64 commented 2026-04-06 16:10:28 +02:00
Owner
Copy Link
Copy Source

Summary

  • Curried candidateMoves, legalMoves, and applyMove in the RuleSet trait to separate (context) as the world being
    operated on from the computation parameter
  • Updated DefaultRules overrides and all internal call sites
  • Updated all external call sites: GameEngine, PgnParser, PgnExporter, ChessBoardView, and all affected tests

Test plan

  • All existing tests pass (./gradlew build)
  • No behaviour changes — pure style refactoring, existing test suite is the regression guard
Summary - Curried candidateMoves, legalMoves, and applyMove in the RuleSet trait to separate (context) as the world being operated on from the computation parameter - Updated DefaultRules overrides and all internal call sites - Updated all external call sites: GameEngine, PgnParser, PgnExporter, ChessBoardView, and all affected tests Test plan - All existing tests pass (./gradlew build) - No behaviour changes — pure style refactoring, existing test suite is the regression guard
lq64 added 1 commit 2026-04-06 16:10:29 +02:00
refactor(rule): Currying
Build & Test (NowChessSystems) TeamCity build finished
Details
152411f27e 
Added Currying
lq64 marked the pull request as ready for review 2026-04-06 16:20:23 +02:00
Janis approved these changes 2026-04-06 21:03:08 +02:00
Janis merged commit 217f14f899 into main 2026-04-06 21:03:17 +02:00
Janis deleted branch feat/NCS-19 2026-04-06 21:03:17 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Janis
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Janis (Janis) lq64 (Leon Hermann) shosho996 (Shahd Lala) svc.teamcity
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NowChess/NowChessSystems#18
Delete Branch "feat/NCS-19"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?