NowChess/NowChessSystems
4
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

feat: NCS-29 #19

Closed
shosho996 wants to merge 7 commits from feat/NCS-29 into main
pull from: feat/NCS-29
merge into: NowChess:main
Conversation 5 Commits 7 Files Changed 44
+1609 -532
shosho996 commented 2026-04-06 22:32:30 +02:00
Owner
Copy Link
Copy Source
No description provided.
shosho996 changed title from feat: I/O json export import, tests should be 100% to feat: NCS-29 2026-04-06 22:33:08 +02:00
Janis requested changes 2026-04-07 08:32:15 +02:00
Janis left a comment
Member
Copy Link
Copy Source

There are a few empty files which should probably be deleted. We should probably use a Library for JSON

There are a few empty files which should probably be deleted. We should probably use a Library for JSON
modules/io/src/main/scala/de/nowchess/io/json/JsonExporter.scala Outdated
@@ -0,0 +35,4 @@
"moves": $moves,
"capturedPieces": $captured,
"timestamp": "$timestamp"
}"""
Janis commented 2026-04-07 08:29:16 +02:00
Member
Copy Link
Copy Source

We should probably use a Library like we used in the SE Project

We should probably use a Library like we used in the SE Project
shosho996 marked this conversation as resolved
modules/ui/chess_game.json Outdated
@@ -0,0 +38,4 @@
"byBlack": ["Pawn"]
},
"timestamp": "2026-04-06T11:39:00.746137480Z[UTC]"
}
Janis commented 2026-04-07 08:28:28 +02:00
Member
Copy Link
Copy Source

I wouldn't check this in

I wouldn't check this in
Janis marked this conversation as resolved
Janis requested changes 2026-04-09 20:38:18 +02:00
Janis left a comment
Member
Copy Link
Copy Source

This branch is out of date and needs fixes. It contains an older version of main and due to the force push lost the connection to main. Cherry Picking recommended.

This branch is out of date and needs fixes. It contains an older version of main and due to the force push lost the connection to main. Cherry Picking recommended.
modules/ui/chess_game.json Outdated
@@ -0,0 +1,203 @@
{
Janis commented 2026-04-09 20:35:53 +02:00
Member
Copy Link
Copy Source

Is there a reason this is added?

Is there a reason this is added?
shosho996 commented 2026-04-10 14:58:33 +02:00
Author
Owner
Copy Link
Copy Source

you mean the file? no reason i just exported it , i can delete it if it bother

you mean the file? no reason i just exported it , i can delete it if it bother
Janis commented 2026-04-11 11:01:22 +02:00
Member
Copy Link
Copy Source

Only check in required files

Only check in required files
shosho996 marked this conversation as resolved
Janis commented 2026-04-11 18:51:50 +02:00
Member
Copy Link
Copy Source

The diff is still way too big. Recommending cherry picking

The diff is still way too big. Recommending cherry picking
shosho996 added 2 commits 2026-04-12 17:35:18 +02:00
feat: I/O json export import with 100% coverage 3e1e79ebee 
- Full FEN parser tests
- Json exporter with all move types covered
- CastleKingside branch coverage

Co-Authored-By: Claude Opus 4.6
fix: removed unneeded file
Build & Test (NowChessSystems) TeamCity build finished
Details
7980a044cc
shosho996 force-pushed feat/NCS-29 from afa685acd2 to 7980a044cc 2026-04-12 17:35:18 +02:00 Compare
shosho996 added 1 commit 2026-04-12 17:41:57 +02:00
fix: conflicts?????
Build & Test (NowChessSystems) TeamCity build finished
Details
64b65cd27f
Janis added 4 commits 2026-04-12 19:04:39 +02:00
feat: I/O json export import with 100% coverage
Build & Test (NowChessSystems) TeamCity build finished
Details
2cec27d471 
- Full FEN parser tests
- Json exporter with all move types covered
- CastleKingside branch coverage

Co-Authored-By: Claude Opus 4.6
fix: removed unneeded file
Build & Test (NowChessSystems) TeamCity build finished
Details
afa685acd2
chore: branch 'main' into feat/NCS-29 b45d3717ae 
# Conflicts:
#	CLAUDE.md
#	modules/io/CHANGELOG.md
#	modules/io/versions.env
#	modules/rule/CHANGELOG.md
#	modules/rule/versions.env
chore: remote-tracking branch 'origin/feat/NCS-29' into feat/NCS-29
Build & Test (NowChessSystems) TeamCity build finished
Details
650b06c661 
# Conflicts:
#	build.gradle.kts
shosho996 commented 2026-04-12 19:15:26 +02:00
Author
Owner
Copy Link
Copy Source

EHRE

EHRE
Janis commented 2026-04-12 19:28:08 +02:00
Member
Copy Link
Copy Source

Closed in favor of #28

Closed in favor of #28
Janis closed this pull request 2026-04-12 19:28:08 +02:00
Janis deleted branch feat/NCS-29 2026-04-12 19:28:20 +02:00
Some checks are pending
Build & Test (NowChessSystems) TeamCity build finished
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Janis
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Janis (Janis) lq64 (Leon Hermann) shosho996 (Shahd Lala) svc.teamcity
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NowChess/NowChessSystems#19
Delete Branch "feat/NCS-29"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?