NowChess/NowChessSystems
4
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

feat: NCS-52 Rules as a microservice #36

Merged
Janis merged 14 commits from feat/NCS-52 into main 2026-04-22 09:29:16 +02:00
Conversation 5 Commits 14 Files Changed 53
+1654 -75
lq64 commented 2026-04-21 13:03:46 +02:00
Owner
Copy Link
Copy Source

Implemented module rules as a microservice.

Summary

  • Adds Quarkus to the rule module, making it independently deployable as a standalone microservice on port 8081
  • Exposes all RuleSet methods via a REST API at /api/rules (candidate moves, legal moves, check/checkmate/stalemate/draw detection, apply
    move)
  • Introduces DTOs and a DtoMapper for serializing/deserializing chess types (board, moves, game context) as flat JSON strings
  • Adds JacksonConfig for Scala module registration and an application.yml for the rule service
  • Includes Dockerfiles for JVM, legacy-jar, native, and native-micro targets
  • Full test coverage: 17 @QuarkusTest HTTP-level tests + 29 DtoMapper unit tests (100% condition coverage)

Test plan

  • ./compile — all modules build successfully
  • ./test — all tests pass (rule module: 107 tests total)
  • ./coverage — 100% condition coverage in rule module
  • Rule service runs standalone: ./gradlew :modules:rule:quarkusDev starts on port 8081
  • GET /api/rules/candidate-moves returns valid moves for initial position
  • GET /api/rules/is-check returns false for initial position
Implemented module rules as a microservice. ## Summary - Adds Quarkus to the `rule` module, making it independently deployable as a standalone microservice on port 8081 - Exposes all `RuleSet` methods via a REST API at `/api/rules` (candidate moves, legal moves, check/checkmate/stalemate/draw detection, apply move) - Introduces DTOs and a `DtoMapper` for serializing/deserializing chess types (board, moves, game context) as flat JSON strings - Adds `JacksonConfig` for Scala module registration and an `application.yml` for the rule service - Includes Dockerfiles for JVM, legacy-jar, native, and native-micro targets - Full test coverage: 17 `@QuarkusTest` HTTP-level tests + 29 `DtoMapper` unit tests (100% condition coverage) ## Test plan - [ ] `./compile` — all modules build successfully - [ ] `./test` — all tests pass (rule module: 107 tests total) - [ ] `./coverage` — 100% condition coverage in `rule` module - [ ] Rule service runs standalone: `./gradlew :modules:rule:quarkusDev` starts on port 8081 - [ ] `GET /api/rules/candidate-moves` returns valid moves for initial position - [ ] `GET /api/rules/is-check` returns `false` for initial position
Janis requested changes 2026-04-21 13:33:14 +02:00
Janis left a comment
Member
Copy Link
Copy Source

Contains changes that revert last commit

Contains changes that revert last commit
Janis commented 2026-04-21 13:34:35 +02:00
Member
Copy Link
Copy Source

Recommend Cherry Picking a176f9e7ca

Recommend Cherry Picking a176f9e7ca4084ad65fc75ce71764c2edfe06a03
lq64 commented 2026-04-21 15:46:06 +02:00
Author
Owner
Copy Link
Copy Source

Recommend Cherry Picking a176f9e7ca

Can you give me an example of where?

> Recommend Cherry Picking a176f9e7ca4084ad65fc75ce71764c2edfe06a03 Can you give me an example of where?
Janis requested changes 2026-04-21 19:25:36 +02:00
Janis left a comment
Member
Copy Link
Copy Source

Hauptsächlich die manuellen DTOs fixen

Hauptsächlich die manuellen DTOs fixen
modules/core/src/main/resources/resources/application.yml Outdated
@@ -0,0 +1,2 @@
greeting:
Janis commented 2026-04-21 19:24:19 +02:00
Member
Copy Link
Copy Source

Bidde nicht adden

Bidde nicht adden
modules/core/src/main/resources/resources/import.sql Outdated
@@ -0,0 +1,6 @@
-- This file allow to write SQL commands that will be emitted in test and dev.
Janis commented 2026-04-21 19:24:27 +02:00
Member
Copy Link
Copy Source

Das hier auch nicht

Das hier auch nicht
modules/core/src/main/scala/de/nowchess/chess/config/JacksonConfig.scala Outdated
@@ -13,5 +13,5 @@ class JacksonConfig extends ObjectMapperCustomizer:
override def version(): Version =
// scalafix:off DisableSyntax.null
new Version(2, 21, 1, null, "com.fasterxml.jackson.module", "jackson-module-scala")
// scalafix:on DisableSyntax.null
Janis commented 2026-04-21 19:24:39 +02:00
Member
Copy Link
Copy Source

Die arme Datei

Die arme Datei
modules/rule/src/main/scala/de/nowchess/rules/dto/Dtos.scala Outdated
@@ -0,0 +16,4 @@
promotionPiece: Option[String],
)
case class GameContextDto(
Janis commented 2026-04-21 19:24:01 +02:00
Member
Copy Link
Copy Source

Warum wird der Context gemappt? Kann man doch direkt verwenden

Warum wird der Context gemappt? Kann man doch direkt verwenden
Janis commented 2026-04-21 19:27:22 +02:00
Member
Copy Link
Copy Source

Schau dir bitte das IO Modul an

Schau dir bitte das IO Modul an
lq64 added 5 commits 2026-04-21 19:43:36 +02:00
feat(rule): Rules as a microservice 0be2ad43e8 
Added rules as a microservice
fix(rule): Rules as a microservice 5a186db349 
Added rules as a microservice
test(rules): Rules as a microservice c09a618dba 
Added tests to rules
fix(rules): Code quality 9f33e2e3db 
linter corrections
fix(rules): Code quality
Build & Test (NowChessSystems) TeamCity build finished
Details
4a69198e3d 
Fixed problem with dependency
lq64 force-pushed feat/NCS-52 from c0e2a21688 to 4a69198e3d 2026-04-21 19:43:36 +02:00 Compare
lq64 added 1 commit 2026-04-21 20:42:48 +02:00
fix(rules): Serializers
Build & Test (NowChessSystems) TeamCity build failed
Details
74f846c95c 
Added serializers like in IO
lq64 added 1 commit 2026-04-21 21:00:42 +02:00
fix(rules): Serializers
Build & Test (NowChessSystems) TeamCity build failed
Details
d096ae4f18 
Added serializers like in IO
lq64 added 1 commit 2026-04-21 21:05:15 +02:00
fix(rules): Serializers
Build & Test (NowChessSystems) TeamCity build failed
Details
990caa5c96 
Added Native Reflection Config
lq64 added 1 commit 2026-04-21 21:15:20 +02:00
fix(rules): Serializers
Build & Test (NowChessSystems) TeamCity build finished
Details
74b7a174c2 
Added small changes
lq64 added 1 commit 2026-04-21 23:34:46 +02:00
feat(core): core dependecy to rules
Build & Test (NowChessSystems) TeamCity build failed
Details
fc720166bf 
Added communication between core and rules via REST
lq64 added 1 commit 2026-04-22 00:03:17 +02:00
fix(core): core dependecy to rules
Build & Test (NowChessSystems) TeamCity build failed
Details
26f3154cda 
small fixes
lq64 added 1 commit 2026-04-22 00:23:42 +02:00
test(core): core dependecy to rules
Build & Test (NowChessSystems) TeamCity build failed
Details
db25eaef2e 
Added tests
lq64 added 1 commit 2026-04-22 09:08:11 +02:00
test(core): core dependecy to rules
Build & Test (NowChessSystems) TeamCity build failed
Details
030469c820 
Added Quarkus file into ignore list
Janis added 1 commit 2026-04-22 09:29:04 +02:00
chore: remote-tracking branch 'origin/main' into feat/NCS-52
Build & Test (NowChessSystems) TeamCity build failed
Details
e9ccae6594 
# Conflicts:
#	modules/core/build.gradle.kts
#	modules/core/src/main/scala/de/nowchess/chess/config/JacksonConfig.scala
#	modules/core/src/main/scala/de/nowchess/chess/engine/GameEngine.scala
#	modules/core/src/test/scala/de/nowchess/chess/engine/GameEngineIntegrationTest.scala
#	modules/core/src/test/scala/de/nowchess/chess/engine/GameEngineLoadGameTest.scala
Janis merged commit e73b6a7514 into main 2026-04-22 09:29:16 +02:00
Janis deleted branch feat/NCS-52 2026-04-22 09:29:16 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Janis
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Janis (Janis) lq64 (Leon Hermann) shosho996 (Shahd Lala) svc.teamcity
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NowChess/NowChessSystems#36
Delete Branch "feat/NCS-52"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?