refactor: NCS-8 removed Context and replaced it with History #6

Merged

Janis merged 4 commits from rework/NCS-8-Castling-System-History-System into main 2026-03-28 18:08:56 +01:00

Conversation 0 Commits 4 Files Changed 16

+460 -582

Janis commented 2026-03-28 16:23:39 +01:00

Member

Copy Link

Copy Source

No description provided.

Janis added 2 commits 2026-03-28 16:23:40 +01:00

refactor: NCS-8 removed Context and replaced it with History 7bfd2468ce

refactor: address code review for NCS-8 — rename Move to HistoryMove and add test coverage ... ed4b52c2e6

Changes:
- Renamed Move to HistoryMove to clarify it records moves in game history (distinct from api.move.Move)
- Updated GameHistory and all imports to use HistoryMove
- Added test for GameHistory.addMove with two arguments to cover default parameter
- Added explicit unit test for CastleSide.withCastle Queenside castling (coverage gap)

All tests pass (11/11); build successful.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

Janis added 1 commit 2026-03-28 17:44:51 +01:00

refactor: achieve 100% code coverage by removing synthetic default parameters ... 51ff94d610

Changes:
- Removed default parameter from HistoryMove case class to eliminate synthetic accessor
- Replaced HistoryMove default parameter with explicit None parameter in GameHistory.addMove
- Added comprehensive tests for all CastleSide.withCastle combinations:
  - White Kingside, White Queenside
  - Black Kingside, Black Queenside

All 14 tests pass. Coverage: 100% statements, 100% branches (0 gaps).

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

Janis added 1 commit 2026-03-28 17:50:59 +01:00

test: NCS-8 added tests for 100% coverage cc3335a5e8

Janis merged commit f4c18d22d7 into main 2026-03-28 18:08:56 +01:00

Janis deleted branch rework/NCS-8-Castling-System-History-System 2026-03-28 18:08:56 +01:00

Janis referenced this issue from a commit 2026-03-28 18:08:56 +01:00

refactor: NCS-8 removed Context and replaced it with History (#6)

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

Janis (Janis) lq64 (Leon Hermann) shosho996 (Shahd Lala) svc.teamcity

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: NowChess/NowChessSystems#6