refactor: NCS-22 NCS-23 reworked modules and tests #17

2026-04-06T09:00:48+02:00

Janis commented

2026-04-06 09:00:48 +02:00

No description provided.

Janis added 41 commits 2026-04-06 09:00:48 +02:00

feat(api): add immutable GameContext type 8a198cbdf6

Bundles complete game state (board, turn, castling rights, en passant, halfMoveClock, moves)
with immutable builder methods for functional state transitions.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

refactor(rule): update RuleSet to use GameContext 60e43027fa

Replace Situation parameter with GameContext across all RuleSet methods
to align with the new game state abstraction. Updated imports to use the
api module's types (GameContext, Square, Move).

StandardRules will need to be updated in Task 3 to implement the new
interface signature and use api types instead of maichess.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

refactor(rule): implement StandardRules with GameContext c59cc2ddcf

build: configure rule module and add dependency from core 8d9996bfed

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

refactor(core): remove GameController, update events to GameContext, verify build cd6cce163d

Task 6: Updated all GameEvent case classes to use context: GameContext instead of separate board/history/turn
Task 7: Deleted old logic files and restored as compatibility layer in modules/api
Task 8: Verified build - main source compilation succeeds

Changes:
- Updated Observer.scala events: all GameEvent subclasses now accept GameContext
- Restored GameHistory and HistoryMove to modules/api as compatibility types
- Restored logic files (GameRules, MoveValidator, etc.) with updated imports
- Updated GameEngine to use currentContext helper for event creation
- Updated GameController to convert CastleSide to String for HistoryMove
- Updated PgnParser/PgnExporter to work with String representation of castling
- Added modules:rule to settings.gradle.kts for dependency resolution
- All main source code compiles successfully; tests expected to need refactoring

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

refactor(core): remove duplicate logic files (moved to StandardRules) 7516828fb1

refactor(core): delete GameController (replaced by GameEngine + RuleSet) 2b23b62b74

refactor(core): cleanup UI and notation imports for NCS-22 interface abstraction

Build & Test (NowChessSystems) TeamCity build failed

Details

b184d50265

- Removed unused CastleSide import from PgnExporter
- Updated TerminalUI and GUIObserver to use GameContext
- Temporarily disabled GUI FEN/PGN import-export (requires full rework with GameContext)
- Deleted unused logic files and GameController per spec

Note: GameEngine still needs final refactoring to use RuleSet + GameContext.
Core architecture (api -> rule -> core) is structurally complete.

refactor(core): NCS-22 update GameEngine to use GameContext and integrate Rule module

Build & Test (NowChessSystems) TeamCity build failed

Details

3d9a108bdc

refactor(core): NCS-22 update GameEngine to use GameContext and integrate Rule module

Build & Test (NowChessSystems) TeamCity build failed

Details

9e5ef5a059

refactor(core): add tests for GameEngine move notation and event handling

Build & Test (NowChessSystems) TeamCity build failed

Details

6283db85c0

refactor(core): migrate GameState to GameContext and update FEN handling

Build & Test (NowChessSystems) TeamCity build failed

Details

c08e5f8c62

refactor(core): add IO module and integrate GameContext import/export traits 6def31dd80

refactor(core): integrate Rule module and update GameContext handling 9b3bbfbcb7

refactor(core): enhance GameEngine and GUI for undo/redo functionality and integrate FEN/PGN export/import

Build & Test (NowChessSystems) TeamCity build failed

Details

fa5cdf4e9c

docs: add IO interface refactor design spec e2fe56ea87

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

refactor(io): change GameContextImport return type from Option to Either f6f05ff2a1

Update GameContextImport trait to return Either[String, GameContext] instead of
Option[GameContext] to provide better error context during parsing. Update FenParser
implementation to convert Option to Either using toRight().

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix(io): update GameContextExport to Scala 3 syntax and add importGameContext tests 6fcb880b93

- Update GameContextExport trait to use Scala 3 syntax (colon-based) to match GameContextImport
- Add test coverage for FenParser.importGameContext method:
  * Valid FEN string returns Right[GameContext] with correct context data
  * Invalid FEN string returns Left[String] with error message

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

refactor(io): implement FenParser.parseFen returning Either with detailed error messages c0a3592d3d

Update parseFen to return Either[String, GameContext] with specific error messages for each validation failure:
- Invalid parts count: reports expected 6 fields
- Invalid board: clear message about board position
- Invalid color: explains expected 'w' or 'b'
- Invalid castling, en passant, and move counts with clear descriptions

Simplify importGameContext to delegate directly to parseFen.

Keep helper methods (parseColor, parseCastling, parseEnPassant, etc.) returning Option as before.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix(io): update FEN tests to use Either API after parseFen signature change 3214386556

FenParser.parseFen now returns Either[String, GameContext] instead of Option.
Updated all tests to use Either combinators (isRight, isLeft, fold) instead
of Option methods (isDefined, get). Both FenParserTest and FenExporterTest
now properly handle the Either-based return type.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

test(io): add comprehensive error path coverage to FenParserTest 9f48f7afeb

Added 3 new tests for missing error paths:
- Invalid en passant square parsing (e.g., "x5")
- Half-move clock non-integer (e.g., "abc")
- Full-move number non-integer (e.g., "abc")

Updated 3 existing error tests to verify error messages:
- "expected 6" for invalid parts count
- "color" for invalid active color
- "castling" for invalid castling rights

All error assertions now use .fold() to verify message content, improving test robustness. Test count increased from 19 to 22.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(io): implement PgnParser.importGameContext with move replay 7c42260d14

Implement the importGameContext method to validate PGN input via validatePgn()
and replay each move using DefaultRules.applyMove to populate GameContext.moves.
Returns final GameContext with all moves applied or error message on failure.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

refactor(io): remove dead code from PgnParser.importGameContext 2d07f1f75a

Remove unnecessary if/else check (lines 49-50) that could never be true.
DefaultRules.applyMove always calls .withMove(move) on the context,
so finalCtx.moves is always populated when game.moves.nonEmpty.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

test(io): add importGameContext tests to PgnParserTest f0316013fc

Added three test cases to validate importGameContext method:
1. Valid PGN with moves returns Right with populated GameContext
2. Invalid PGN (illegal move) returns Left with error message
3. PGN with no moves returns Right with initial position

Tests use coordinate notation (e.g., e2e4) compatible with importGameContext's move replay mechanism.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(io): implement PgnExporter.exportGameContext with move replay 09a70ed435

PgnExporter now extends GameContextExport and implements exportGameContext,
which replays moves from GameContext.initial to reconstruct HistoryMove records
with proper castling/promotion info before generating PGN.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix(io): add error handling for missing piece in PgnExporter replay 16a9632e69

Replace unsafe fallback to Pawn with explicit exception on invariant
violation. This ensures data corruption in GameContext.moves is detected
immediately rather than producing silently incorrect PGN output.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

test(io): add exportGameContext tests 8b5303fdab

Add two simple tests for exportGameContext functionality:
1. Test that moves are preserved in PGN output
2. Test that empty game exports headers with proper terminator

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

refactor(core): add loadGame/exportGame, remove loadPgn from GameEngine e88f502ffc

- Add imports for GameContextImport and GameContextExport
- Add loadGame(importer, input) method to load game from importer
- Add exportGame(exporter) method to export current game context
- Remove entire loadPgn method (replaced by loadGame)
- Remove GameEngineLoadPgnTest (tests old loadPgn API)

loadGame supports both move replay and direct position loading:
- If no moves, sets position directly via loadPosition
- If moves exist, replays through command system for undo/redo support
- Notifies PgnLoadedEvent on success

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

test(core): add GameEngineLoadGameTest for loadGame/exportGame 17fa13c82a

Add 3 focused tests for GameEngine load/export functionality:
- loadGame with PgnParser validates PGN parsing and undo/redo state
- loadGame with FenParser validates position loading without move replay
- exportGame with PgnExporter validates PGN output

Fix: PgnParser now extends GameContextImport trait for consistency with FenParser.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

refactor(core): streamline FEN and PGN export/import methods in ChessBoardView a1b7cc7f4a

refactor(core): replace GameHistory with HistoryMove in PGN export logic 432385c7b0

refactor(core): enhance MoveType to support capture flag and update related logic

Build & Test (NowChessSystems) TeamCity build failed

Details

1fc5e43e77

refactor(core): simplify castling logic and improve move translation methods

Build & Test (NowChessSystems) TeamCity build failed

Details

0778882db6

refactor(core): optimize castling move logic and enhance move notation methods

Build & Test (NowChessSystems) TeamCity build failed